jyapayne/langflow
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

(frontend): Remove NATIVE_CATEGORIES constant and simplify logic for checking template code value in GenericNode component (#2008)

Browse source 
This pull request removes the `NATIVE_CATEGORIES` constant and
simplifies the logic for checking the template code value in the
`GenericNode` component. The logic now checks if the
`data.node.template.code.value` exists before proceeding. Additionally,
the logic for checking the template code value has been simplified by
removing the unnecessary check for
`NATIVE_CATEGORIES.includes(types[data.type])`.
This commit is contained in:
Gabriel Luiz Freitas Almeida 2024-05-29 17:26:15 -07:00 • committed by GitHub
commit 63314b05f1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/frontend/src/customNodes/genericNode/index.tsx
View file

@ -10,7 +10,6 @@ import Loading from "../../components/ui/loading";
import { Textarea } from "../../components/ui/textarea"; import { Textarea } from "../../components/ui/textarea";
import Xmark from "../../components/ui/xmark"; import Xmark from "../../components/ui/xmark";
import { import {
NATIVE_CATEGORIES,
RUN_TIMESTAMP_PREFIX, RUN_TIMESTAMP_PREFIX,
STATUS_BUILD, STATUS_BUILD,
STATUS_BUILDING, STATUS_BUILDING,
@ -77,18 +76,14 @@ export default function GenericNode({
// This one should run only once // This one should run only once
// first check if data.type in NATIVE_CATEGORIES // first check if data.type in NATIVE_CATEGORIES
// if not return // if not return
if ( if (!data.node?.template?.code?.value) return;
!NATIVE_CATEGORIES.includes(types[data.type]) ||
!data.node?.template?.code?.value
)
return;
const thisNodeTemplate = templates[data.type].template; const thisNodeTemplate = templates[data.type].template;
// if the template does not have a code key // if the template does not have a code key
// return // return
if (!thisNodeTemplate.code) return; if (!thisNodeTemplate.code) return;
const currentCode = thisNodeTemplate.code?.value; const currentCode = thisNodeTemplate.code?.value;
const thisNodesCode = data.node!.template?.code?.value; const thisNodesCode = data.node!.template?.code?.value;
const componentsToIgnore = ["Custom Component", "Prompt"]; const componentsToIgnore = ["Custom Component"];
if ( if (
currentCode !== thisNodesCode && currentCode !== thisNodesCode &&
!componentsToIgnore.includes(data.node!.display_name) !componentsToIgnore.includes(data.node!.display_name)