From 6457725d13f9a0a7e0ed3cbd4c1ce31d0ac54d4f Mon Sep 17 00:00:00 2001 From: anovazzi1 Date: Tue, 29 Aug 2023 22:29:41 -0300 Subject: [PATCH] fix(genericModal/index.tsx): remove debugger statement for cleaner code fix(genericModal/index.tsx): update condition for setting nodeClass to avoid unnecessary re-rendering --- src/frontend/package-lock.json | 12 ++++++------ src/frontend/src/modals/genericModal/index.tsx | 6 ++++-- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/src/frontend/package-lock.json b/src/frontend/package-lock.json index 93805f8ef..b8af76667 100644 --- a/src/frontend/package-lock.json +++ b/src/frontend/package-lock.json @@ -5514,9 +5514,9 @@ } }, "node_modules/fraction.js": { - "version": "4.3.0", - "resolved": "https://registry.npmjs.org/fraction.js/-/fraction.js-4.3.0.tgz", - "integrity": "sha512-btalnXjFelOv2cy86KzHWhUuMb622/AD8ce/MCH9C36xe7QRXjJZA+19fP+G5LT0fdRcbOHErMI3SPM11ZaVDg==", + "version": "4.3.1", + "resolved": "https://registry.npmjs.org/fraction.js/-/fraction.js-4.3.1.tgz", + "integrity": "sha512-nx0cki48JBA6ThPeUpeKCNpdhEl/9bRS+dAEYnRUod+Z1jhFfC3K/mBLorZZntqHM+GTH3/dkkpfoT3QITYe7g==", "dev": true, "engines": { "node": "*" @@ -14721,9 +14721,9 @@ } }, "fraction.js": { - "version": "4.3.0", - "resolved": "https://registry.npmjs.org/fraction.js/-/fraction.js-4.3.0.tgz", - "integrity": "sha512-btalnXjFelOv2cy86KzHWhUuMb622/AD8ce/MCH9C36xe7QRXjJZA+19fP+G5LT0fdRcbOHErMI3SPM11ZaVDg==", + "version": "4.3.1", + "resolved": "https://registry.npmjs.org/fraction.js/-/fraction.js-4.3.1.tgz", + "integrity": "sha512-nx0cki48JBA6ThPeUpeKCNpdhEl/9bRS+dAEYnRUod+Z1jhFfC3K/mBLorZZntqHM+GTH3/dkkpfoT3QITYe7g==", "dev": true }, "fs-extra": { diff --git a/src/frontend/src/modals/genericModal/index.tsx b/src/frontend/src/modals/genericModal/index.tsx index 7e48635ba..ee0431108 100644 --- a/src/frontend/src/modals/genericModal/index.tsx +++ b/src/frontend/src/modals/genericModal/index.tsx @@ -124,7 +124,8 @@ export default function GenericModal({ //nodeClass is always null on tweaks postValidatePrompt(field_name, inputValue, nodeClass!) .then((apiReturn) => { - if (apiReturn.data && nodeClass) { + // debugger; + if (apiReturn.data) { let inputVariables = apiReturn.data.input_variables ?? []; if (inputVariables && inputVariables.length === 0) { setIsEdit(true); @@ -136,7 +137,8 @@ export default function GenericModal({ setSuccessData({ title: "Prompt is ready", }); - if(apiReturn.data?.frontend_node) setNodeClass!(apiReturn.data?.frontend_node); + + if(JSON.stringify(apiReturn.data?.frontend_node)!==JSON.stringify({})) setNodeClass!(apiReturn.data?.frontend_node); setModalOpen(closeModal); setValue(inputValue); }