From 6675592737e4ce9499ee9240fd9588cd6a15679b Mon Sep 17 00:00:00 2001 From: Gabriel Luiz Freitas Almeida Date: Thu, 6 Jul 2023 17:35:25 -0300 Subject: [PATCH] =?UTF-8?q?=F0=9F=94=A7=20refactor(base.py):=20remove=20un?= =?UTF-8?q?necessary=20condition=20in=20get=5Fsignature=20method=20The=20c?= =?UTF-8?q?ondition=20`name=20in=20settings.`=20is=20removed=20from?= =?UTF-8?q?=20the=20`get=5Fsignature`=20method=20in=20the=20`base.py`=20fi?= =?UTF-8?q?les=20of=20the=20`agents`,=20`chains`,=20`memories`,=20and=20`p?= =?UTF-8?q?rompts`=20modules.=20This=20condition=20was=20unnecessary=20as?= =?UTF-8?q?=20it=20was=20already=20checked=20in=20the=20`get=5Fcustom=5Fno?= =?UTF-8?q?des`=20function.=20Removing=20this=20condition=20simplifies=20t?= =?UTF-8?q?he=20code=20and=20improves=20readability.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/backend/langflow/interface/agents/base.py | 5 +---- src/backend/langflow/interface/chains/base.py | 5 +---- src/backend/langflow/interface/memories/base.py | 5 +---- src/backend/langflow/interface/prompts/base.py | 5 +---- 4 files changed, 4 insertions(+), 16 deletions(-) diff --git a/src/backend/langflow/interface/agents/base.py b/src/backend/langflow/interface/agents/base.py index 2aa9fc4c2..b272144bc 100644 --- a/src/backend/langflow/interface/agents/base.py +++ b/src/backend/langflow/interface/agents/base.py @@ -32,10 +32,7 @@ class AgentCreator(LangChainTypeCreator): def get_signature(self, name: str) -> Optional[Dict]: try: - if ( - name in get_custom_nodes(self.type_name).keys() - and name in settings.agents - ): + if name in get_custom_nodes(self.type_name).keys(): return get_custom_nodes(self.type_name)[name] elif name in self.from_method_nodes: return build_template_from_method( diff --git a/src/backend/langflow/interface/chains/base.py b/src/backend/langflow/interface/chains/base.py index 9459f49e5..ff7e1ee33 100644 --- a/src/backend/langflow/interface/chains/base.py +++ b/src/backend/langflow/interface/chains/base.py @@ -45,10 +45,7 @@ class ChainCreator(LangChainTypeCreator): def get_signature(self, name: str) -> Optional[Dict]: try: - if ( - name in get_custom_nodes(self.type_name).keys() - and name in settings.chains - ): + if name in get_custom_nodes(self.type_name).keys(): return get_custom_nodes(self.type_name)[name] elif name in self.from_method_nodes.keys(): return build_template_from_method( diff --git a/src/backend/langflow/interface/memories/base.py b/src/backend/langflow/interface/memories/base.py index 9d3ceb30f..0f97a02fe 100644 --- a/src/backend/langflow/interface/memories/base.py +++ b/src/backend/langflow/interface/memories/base.py @@ -32,10 +32,7 @@ class MemoryCreator(LangChainTypeCreator): def get_signature(self, name: str) -> Optional[Dict]: """Get the signature of a memory.""" try: - if ( - name in get_custom_nodes(self.type_name).keys() - and name in settings.memories - ): + if name in get_custom_nodes(self.type_name).keys(): return get_custom_nodes(self.type_name)[name] elif name in self.from_method_nodes: return build_template_from_method( diff --git a/src/backend/langflow/interface/prompts/base.py b/src/backend/langflow/interface/prompts/base.py index ef4f03991..39bd94c5b 100644 --- a/src/backend/langflow/interface/prompts/base.py +++ b/src/backend/langflow/interface/prompts/base.py @@ -40,10 +40,7 @@ class PromptCreator(LangChainTypeCreator): def get_signature(self, name: str) -> Optional[Dict]: try: - if ( - name in get_custom_nodes(self.type_name).keys() - and name in settings.prompts - ): + if name in get_custom_nodes(self.type_name).keys(): return get_custom_nodes(self.type_name)[name] return build_template_from_class(name, self.type_to_loader_dict) except ValueError as exc: