From 673736807376b208afcac2070566436871a2d0b9 Mon Sep 17 00:00:00 2001
From: anovazzi1 <otavio2204@gmail.com>
Date: Thu, 21 Nov 2024 21:40:39 -0300
Subject: [PATCH] fix: Improve wait time in saveComponents.spec.ts (#4673)

Improve the wait time in the saveComponents.spec.ts file to ensure that the necessary elements are loaded before interacting with them. This helps prevent potential errors and improves the reliability of the test.
---
 .../tests/core/features/saveComponents.spec.ts         | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/frontend/tests/core/features/saveComponents.spec.ts b/src/frontend/tests/core/features/saveComponents.spec.ts
index b6e0777d9..7e969d88c 100644
--- a/src/frontend/tests/core/features/saveComponents.spec.ts
+++ b/src/frontend/tests/core/features/saveComponents.spec.ts
@@ -17,14 +17,15 @@ test.describe("save component tests", () => {
 
     while (modalCount === 0) {
       await page.getByText("New Flow", { exact: true }).click();
-      await page.waitForTimeout(3000);
+      await page.waitForSelector('[data-testid="modal-title"]', {
+        timeout: 3000,
+      });
       modalCount = await page.getByTestId("modal-title")?.count();
     }
     await page.waitForSelector('[data-testid="blank-flow"]', {
       timeout: 30000,
     });
     await page.getByTestId("blank-flow").click();
-    await page.waitForTimeout(1000);
 
     // Read your file into a buffer.
     const jsonContent = readFileSync(
@@ -43,8 +44,6 @@ test.describe("save component tests", () => {
       return dt;
     }, jsonContent);
 
-    page.waitForTimeout(1000);
-
     // Now dispatch
     await page.dispatchEvent(
       "//*[@id='react-flow-id']/div[1]/div[1]/div",
@@ -95,7 +94,7 @@ test.describe("save component tests", () => {
     await page.getByTestId("more-options-modal").click();
 
     await page.getByTestId("icon-SaveAll").click();
-
+    // timeout to handle case where there is already a saved component with the same name
     await page.waitForTimeout(1000);
 
     const replaceButton = await page.getByTestId("replace-button").isVisible();
@@ -105,7 +104,6 @@ test.describe("save component tests", () => {
     }
     await page.getByTestId("sidebar-search-input").click();
     await page.getByTestId("sidebar-search-input").fill("group");
-    await page.waitForTimeout(1000);
 
     await page
       .getByText("Group")