From 6f001c64bef14c1203da87e00870c24e8aebb508 Mon Sep 17 00:00:00 2001 From: Anand Dev Singh Date: Fri, 16 Aug 2024 02:45:12 +0530 Subject: [PATCH] fix: Corrected Changed the data type of number field from string to number (#3363) * Changed the data type of number field from string to number * [autofix.ci] apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> --- src/frontend/src/components/intComponent/index.tsx | 8 ++++---- .../src/components/parameterRenderComponent/index.tsx | 2 +- src/frontend/src/types/components/index.ts | 4 ++-- src/frontend/src/utils/reactflowUtils.ts | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/frontend/src/components/intComponent/index.tsx b/src/frontend/src/components/intComponent/index.tsx index cc9bb73fe..10bcad7bf 100644 --- a/src/frontend/src/components/intComponent/index.tsx +++ b/src/frontend/src/components/intComponent/index.tsx @@ -21,8 +21,8 @@ export default function IntComponent({ const min = -Infinity; // Clear component state useEffect(() => { - if (disabled && value !== "") { - onChange("", undefined, true); + if (disabled && value !== 0) { + onChange(0, undefined, true); } }, [disabled, onChange]); @@ -35,7 +35,7 @@ export default function IntComponent({ const handleChangeInput = (e: React.ChangeEvent) => { setCursor(e.target.selectionStart); - onChange(e.target.value); + onChange(Number(e.target.value)); }; return ( @@ -46,7 +46,7 @@ export default function IntComponent({ min={rangeSpec?.min ?? min} max={rangeSpec?.max ?? undefined} onChange={(value) => { - onChange(value); + onChange(Number(value)); }} value={value ?? ""} > diff --git a/src/frontend/src/components/parameterRenderComponent/index.tsx b/src/frontend/src/components/parameterRenderComponent/index.tsx index 0ce36524f..50953999f 100644 --- a/src/frontend/src/components/parameterRenderComponent/index.tsx +++ b/src/frontend/src/components/parameterRenderComponent/index.tsx @@ -108,7 +108,7 @@ export function ParameterRenderComponent({ id={`int_${id}`} disabled={disabled} editNode={editNode} - value={templateValue ?? ""} + value={templateValue ?? 0} onChange={onChange} /> ) : templateData.type === "file" ? ( diff --git a/src/frontend/src/types/components/index.ts b/src/frontend/src/types/components/index.ts index fb1722ed0..c5f2db077 100644 --- a/src/frontend/src/types/components/index.ts +++ b/src/frontend/src/types/components/index.ts @@ -269,10 +269,10 @@ export type RangeSpecType = { }; export type IntComponentType = { - value: string; + value: number; disabled?: boolean; rangeSpec: RangeSpecType; - onChange: (value: string, dbValue?: boolean, skipSnapshot?: boolean) => void; + onChange: (value: number, dbValue?: boolean, skipSnapshot?: boolean) => void; editNode?: boolean; id?: string; }; diff --git a/src/frontend/src/utils/reactflowUtils.ts b/src/frontend/src/utils/reactflowUtils.ts index b6104d019..84467951d 100644 --- a/src/frontend/src/utils/reactflowUtils.ts +++ b/src/frontend/src/utils/reactflowUtils.ts @@ -636,7 +636,7 @@ export function handleKeyDown( e: | React.KeyboardEvent | React.KeyboardEvent, - inputValue: string | string[] | null | undefined, + inputValue: string | number | string[] | null | undefined, block: string, ) { //condition to fix bug control+backspace on Windows/Linux