📝 (index.tsx): add data-testid attributes to the toolbar select items to improve testability

♻️ (toolbarSelectItem/index.tsx): remove unused import and refactor code to include data-testid attribute in the rendered element
📝 (index.ts): add dataTestId property to the toolbarSelectItemProps type to reflect the addition of data-testid attribute in the component
📝 (auto_login.spec.ts): increase timeout for page.waitForTimeout to 16 seconds and test.setTimeout to 140 seconds to accommodate slower test execution
📝 (keyPairListComponent.spec.ts): increase timeout for page.waitForTimeout to 20 seconds to accommodate slower test execution
This commit is contained in:
cristhianzl 2024-03-15 15:56:13 -03:00
commit 70c083451e
5 changed files with 31 additions and 21 deletions

View file

@ -453,6 +453,7 @@ export default function NodeToolbarComponent({
shift={false} shift={false}
value={"Edit"} value={"Edit"}
icon={"Settings2"} icon={"Settings2"}
dataTestId="edit-button-modal"
/> />
</SelectItem> </SelectItem>
)} )}
@ -463,6 +464,7 @@ export default function NodeToolbarComponent({
shift={false} shift={false}
value={"Duplicate"} value={"Duplicate"}
icon={"Copy"} icon={"Copy"}
dataTestId="duplicate-button-modal"
/> />
</SelectItem> </SelectItem>
<SelectItem value={"copy"}> <SelectItem value={"copy"}>
@ -472,6 +474,7 @@ export default function NodeToolbarComponent({
shift={false} shift={false}
value={"Copy"} value={"Copy"}
icon={"Clipboard"} icon={"Clipboard"}
dataTestId="copy-button-modal"
/> />
</SelectItem> </SelectItem>
{isOutdated && ( {isOutdated && (
@ -482,6 +485,7 @@ export default function NodeToolbarComponent({
shift={false} shift={false}
value={"Update"} value={"Update"}
icon={"Code"} icon={"Code"}
dataTestId="update-button-modal"
/> />
</SelectItem> </SelectItem>
)} )}
@ -499,6 +503,7 @@ export default function NodeToolbarComponent({
styleObj={{ styleObj={{
iconClasses: "relative top-0.5 -m-1 mr-1 h-6 w-6", iconClasses: "relative top-0.5 -m-1 mr-1 h-6 w-6",
}} }}
dataTestId="share-button-modal"
/> />
</SelectItem> </SelectItem>
)} )}
@ -523,6 +528,7 @@ export default function NodeToolbarComponent({
shift={true} shift={true}
value={"Docs"} value={"Docs"}
icon={"FileText"} icon={"FileText"}
dataTestId="docs-button-modal"
/> />
</SelectItem> </SelectItem>
{isMinimal && ( {isMinimal && (

View file

@ -1,4 +1,3 @@
import { useEffect } from "react";
import ForwardedIconComponent from "../../../../../components/genericIconComponent"; import ForwardedIconComponent from "../../../../../components/genericIconComponent";
import { toolbarSelectItemProps } from "../../../../../types/components"; import { toolbarSelectItemProps } from "../../../../../types/components";
@ -9,10 +8,10 @@ export default function ToolbarSelectItem({
value, value,
icon, icon,
styleObj, styleObj,
dataTestId,
}: toolbarSelectItemProps) { }: toolbarSelectItemProps) {
return ( return (
<div className="flex"> <div className="flex" data-testid={dataTestId}>
<ForwardedIconComponent <ForwardedIconComponent
name={icon} name={icon}
className={`relative top-0.5 mr-2 h-4 w-4 ${styleObj?.iconClasses}`} className={`relative top-0.5 mr-2 h-4 w-4 ${styleObj?.iconClasses}`}
@ -21,24 +20,28 @@ export default function ToolbarSelectItem({
{isMac ? ( {isMac ? (
<ForwardedIconComponent <ForwardedIconComponent
name="Command" name="Command"
className={`absolute right-[${shift ? "2rem" : "1.15rem"}] top-[0.65em] h-3.5 w-3.5 stroke-2 ${styleObj?.commandClasses}`} className={`absolute right-[${
shift ? "2rem" : "1.15rem"
}] top-[0.65em] h-3.5 w-3.5 stroke-2 ${styleObj?.commandClasses}`}
></ForwardedIconComponent> ></ForwardedIconComponent>
) : ( ) : (
<span className={`absolute right-[${shift ? "2.10rem" : "1.15rem"}] top-[0.43em] stroke-2 ${styleObj?.ctrlClasses}`}> <span
{shift ? ( className={`absolute right-[${
"Ctrl" shift ? "2.10rem" : "1.15rem"
) : ( }] top-[0.43em] stroke-2 ${styleObj?.ctrlClasses}`}
"Ctrl +" >
)} {shift ? "Ctrl" : "Ctrl +"}
</span> </span>
)} )}
{shift && ( {shift && (
<ForwardedIconComponent <ForwardedIconComponent
name="ArrowBigUp" name="ArrowBigUp"
className={`absolute right-[1.15rem] top-[0.65em] h-3.5 w-3.5 stroke-2 ${styleObj?.shiftClasses}`} className={`absolute right-[1.15rem] top-[0.65em] h-3.5 w-3.5 stroke-2 ${styleObj?.shiftClasses}`}
/> />
)} )}
<span className={`absolute right-2 top-[0.43em] ${styleObj?.keyClasses}`}>{keyboardKey}</span> <span className={`absolute right-2 top-[0.43em] ${styleObj?.keyClasses}`}>
{keyboardKey}
</span>
</div> </div>
); );
} }

View file

@ -702,5 +702,6 @@ export type toolbarSelectItemProps = {
ctrlClasses?: string; ctrlClasses?: string;
keyClasses?: string; keyClasses?: string;
valueClasses?: string; valueClasses?: string;
} };
dataTestId: string;
}; };

View file

@ -1,7 +1,7 @@
import { test } from "@playwright/test"; import { test } from "@playwright/test";
test.beforeEach(async ({ page }) => { test.beforeEach(async ({ page }) => {
await page.waitForTimeout(1000); await page.waitForTimeout(16000);
test.setTimeout(120000); test.setTimeout(140000);
}); });
test.describe("Auto_login tests", () => { test.describe("Auto_login tests", () => {
test("auto_login sign in", async ({ page }) => { test("auto_login sign in", async ({ page }) => {

View file

@ -1,6 +1,6 @@
import { expect, test } from "@playwright/test"; import { expect, test } from "@playwright/test";
test.beforeEach(async ({ page }) => { test.beforeEach(async ({ page }) => {
await page.waitForTimeout(10000); await page.waitForTimeout(20000);
test.setTimeout(120000); test.setTimeout(120000);
}); });
test("KeypairListComponent", async ({ page }) => { test("KeypairListComponent", async ({ page }) => {