From 728c625407dd2f743a6489b83b19e75f14b85ba0 Mon Sep 17 00:00:00 2001 From: Cristhian Zanforlin Lousa Date: Fri, 14 Jul 2023 11:39:07 -0300 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20fix(ApiModal/index.tsx):=20remov?= =?UTF-8?q?e=20unused=20code=20and=20refactor=20useEffect=20dependencies?= =?UTF-8?q?=20for=20better=20performance=20and=20readability?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/frontend/src/modals/ApiModal/index.tsx | 52 +++------------------- 1 file changed, 5 insertions(+), 47 deletions(-) diff --git a/src/frontend/src/modals/ApiModal/index.tsx b/src/frontend/src/modals/ApiModal/index.tsx index b42eda101..ba246f7d7 100644 --- a/src/frontend/src/modals/ApiModal/index.tsx +++ b/src/frontend/src/modals/ApiModal/index.tsx @@ -110,56 +110,14 @@ const ApiModal = forwardRef( }, ]; - useEffect(() => { - if (closeEdit !== "") { - tweak.current = getTweak; - if (tweak.current.length > 0) { - setActiveTab("3"); - openAccordions(); - } else { - startTweaks(); - } - } else { - if (tweak?.current) { - startTweaks(); - } - } - }, [closeEdit]); useEffect(() => { + tweaksList.current = []; filterNodes(); - }, []); + + }, [flow["data"]["nodes"]]); - // useEffect(() => { - - // if(flow["data"]["nodes"].length == 0){ - // tweak.current = []; - // setTweak(tweak.current); - - // } - - // else{ - // if (tweak.current.length > 0) { - // tweak.current = getTweak; - - // } else { - // startTweaks(); - // } - // } - - - - // }, [flow["data"]["nodes"]]); - - function startTweaks() { - const t = buildTweaks(flow); - Object.keys(t).length == 0 ? tweak.current = [] : tweak?.current?.push(t); - setTweak(tweak.current); - } - - useEffect(() => { - filterNodes(); - }, []); + if (Object.keys(tweaksCode).length > 0) { tabs.push({ @@ -289,7 +247,7 @@ const ApiModal = forwardRef( } const setOpen = (x: boolean) => { - setCloseEdit(""); + x ? setCloseEdit("apimodal") : setCloseEdit(""); };