From eaf70303ee50bf56e2ceb18109145571810d9c5c Mon Sep 17 00:00:00 2001 From: Lucas Oliveira Date: Thu, 24 Aug 2023 10:52:23 -0300 Subject: [PATCH 1/2] Fixed bug where name is not changed when description changes --- src/frontend/src/components/EditFlowSettingsComponent/index.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/src/frontend/src/components/EditFlowSettingsComponent/index.tsx b/src/frontend/src/components/EditFlowSettingsComponent/index.tsx index be5a6db8d..dc4c60eb3 100644 --- a/src/frontend/src/components/EditFlowSettingsComponent/index.tsx +++ b/src/frontend/src/components/EditFlowSettingsComponent/index.tsx @@ -67,7 +67,6 @@ export const EditFlowSettings: React.FC = ({ }, [name, description]); const handleDescriptionChange = (event: ChangeEvent) => { - flows.find((f) => f.id === tabId).description = event.target.value; setCurrentDescription(flows.find((f) => f.id === tabId).description); setDescription(event.target.value); }; From 1e5fc970130e83f9d8bb984af6137e6fb6d1ff3f Mon Sep 17 00:00:00 2001 From: Lucas Oliveira Date: Thu, 24 Aug 2023 20:21:09 -0300 Subject: [PATCH 2/2] Bug fixed --- .../EditFlowSettingsComponent/index.tsx | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/src/frontend/src/components/EditFlowSettingsComponent/index.tsx b/src/frontend/src/components/EditFlowSettingsComponent/index.tsx index dc4c60eb3..9bd1bc2f7 100644 --- a/src/frontend/src/components/EditFlowSettingsComponent/index.tsx +++ b/src/frontend/src/components/EditFlowSettingsComponent/index.tsx @@ -54,20 +54,9 @@ export const EditFlowSettings: React.FC = ({ } } setName(value); - setCurrentName(value); }; - const [currentName, setCurrentName] = useState(name); - - const [currentDescription, setCurrentDescription] = useState(description); - - useEffect(() => { - setCurrentName(name); - setCurrentDescription(description); - }, [name, description]); - const handleDescriptionChange = (event: ChangeEvent) => { - setCurrentDescription(flows.find((f) => f.id === tabId).description); setDescription(event.target.value); }; @@ -88,7 +77,7 @@ export const EditFlowSettings: React.FC = ({ onChange={handleNameChange} type="text" name="name" - value={currentName ?? ""} + value={name ?? ""} placeholder="File name" id="name" maxLength={maxLength} @@ -103,7 +92,7 @@ export const EditFlowSettings: React.FC = ({ name="description" id="description" onChange={handleDescriptionChange} - value={currentDescription} + value={description} placeholder="Flow description" className="mt-2 max-h-[100px] font-normal" rows={3}