From 7549cbb90b80ab32304ebb1ba1dbdb83671e68a8 Mon Sep 17 00:00:00 2001 From: anovazzi1 Date: Tue, 21 Nov 2023 17:19:49 -0300 Subject: [PATCH] fix(cardComponent): update ShadTooltip content to always display "Private" for private cards fix(API): update parameter name from status to isPrivate for consistency and clarity fix(StorePage): update parameter name from status to isPrivate to match API changes and improve semantics --- src/frontend/src/components/cardComponent/index.tsx | 2 +- src/frontend/src/controllers/API/index.ts | 8 ++++---- src/frontend/src/pages/StorePage/index.tsx | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/frontend/src/components/cardComponent/index.tsx b/src/frontend/src/components/cardComponent/index.tsx index f19e041be..e7f442091 100644 --- a/src/frontend/src/components/cardComponent/index.tsx +++ b/src/frontend/src/components/cardComponent/index.tsx @@ -145,7 +145,7 @@ export default function CollectionCardComponent({ {data?.metadata !== undefined && (
{data.private && ( - + diff --git a/src/frontend/src/controllers/API/index.ts b/src/frontend/src/controllers/API/index.ts index a754d1563..863596d64 100644 --- a/src/frontend/src/controllers/API/index.ts +++ b/src/frontend/src/controllers/API/index.ts @@ -600,7 +600,7 @@ export async function getStoreComponents({ sort = "-count(liked_by)", tags = [] || null, liked = null, - status = null, + isPrivate = null, search = null, filterByUser = null, }: { @@ -610,7 +610,7 @@ export async function getStoreComponents({ sort?: string; tags?: string[] | null; liked?: boolean | null; - status?: string | null; + isPrivate?: boolean | null; search?: string | null; filterByUser?: boolean | null; }): Promise { @@ -620,8 +620,8 @@ export async function getStoreComponents({ if (search !== undefined && search !== null) { queryParams.push(`search=${search}`); } - if (status !== undefined && status !== null) { - queryParams.push(`status=${status}`); + if (isPrivate !== undefined && isPrivate !== null) { + queryParams.push(`private=${isPrivate}`); } if (tags !== undefined && tags !== null && tags.length > 0) { queryParams.push(`tags=${tags.join(encodeURIComponent(","))}`); diff --git a/src/frontend/src/pages/StorePage/index.tsx b/src/frontend/src/pages/StorePage/index.tsx index 815847d2a..7c0a86369 100644 --- a/src/frontend/src/pages/StorePage/index.tsx +++ b/src/frontend/src/pages/StorePage/index.tsx @@ -111,7 +111,7 @@ export default function StorePage(): JSX.Element { sort: pageOrder === "Popular" ? "-count(downloads)" : "name", tags: filteredCategories, liked: selectFilter === "likedbyme" && validApiKey ? true : null, - status: null, + isPrivate: null, search: inputText === "" ? null : inputText, filterByUser: selectFilter === "createdbyme" && validApiKey ? true : null, })