From 7cebb8215f0d3db4fdcad35d6eb1f5d3d200160e Mon Sep 17 00:00:00 2001 From: Gabriel Luiz Freitas Almeida Date: Thu, 22 Jun 2023 22:18:01 -0300 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20fix(vector=5Fstore.py):=20remove?= =?UTF-8?q?=20redundant=20code=20and=20fix=20parameter=20naming=20The=20`i?= =?UTF-8?q?nitialize=5Fchroma`=20function=20had=20redundant=20code=20that?= =?UTF-8?q?=20was=20removed.=20The=20`embedding=5Ffunction`=20parameter=20?= =?UTF-8?q?was=20renamed=20to=20`embedding`=20to=20match=20the=20parameter?= =?UTF-8?q?=20name=20used=20in=20the=20`class=5Fobject`=20constructor.=20T?= =?UTF-8?q?he=20`documents`=20and=20`texts`=20parameters=20were=20being=20?= =?UTF-8?q?used=20interchangeably,=20so=20the=20code=20was=20updated=20to?= =?UTF-8?q?=20use=20only=20`documents`.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/backend/langflow/interface/initialize/vector_store.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/backend/langflow/interface/initialize/vector_store.py b/src/backend/langflow/interface/initialize/vector_store.py index 2f8c0c5ac..d878ec41b 100644 --- a/src/backend/langflow/interface/initialize/vector_store.py +++ b/src/backend/langflow/interface/initialize/vector_store.py @@ -122,6 +122,11 @@ def initialize_chroma(class_object: Type[Chroma], params: dict): """Initialize a ChromaDB object from the params""" persist = params.pop("persist", False) if not docs_in_params(params): + params.pop("documents", None) + params.pop("texts", None) + params["embedding_function"] = params.pop("embedding") + chromadb = class_object(**params) + else: if "texts" in params: params["documents"] = params.pop("texts") for doc in params["documents"]: @@ -131,8 +136,6 @@ def initialize_chroma(class_object: Type[Chroma], params: dict): if value is None: doc.metadata[key] = "" chromadb = class_object.from_documents(**params) - else: - chromadb = class_object(**params) if persist: chromadb.persist() return chromadb