From 85647091f75945e9a7391aca8ba1d4ddb8c20954 Mon Sep 17 00:00:00 2001 From: Gabriel Luiz Freitas Almeida Date: Wed, 1 Nov 2023 09:52:35 -0300 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20fix(store.py):=20change=20return?= =?UTF-8?q?=20value=20from=20dictionary=20to=20UsersLikesResponse=20object?= =?UTF-8?q?=20to=20improve=20readability=20and=20maintainability?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 🐛 fix(service.py): handle case when component is not found and raise ValueError to provide more informative error message --- src/backend/langflow/api/v1/store.py | 2 +- src/backend/langflow/services/store/service.py | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/backend/langflow/api/v1/store.py b/src/backend/langflow/api/v1/store.py index f89c22e3f..d52870031 100644 --- a/src/backend/langflow/api/v1/store.py +++ b/src/backend/langflow/api/v1/store.py @@ -202,6 +202,6 @@ def like_component( likes_count = store_service.get_component_likes_count( store_api_Key, component_id ) - return {"likes": likes_count, "liked_by_user": result} + return UsersLikesResponse(likes_count=likes_count, liked_by_user=result) except Exception as exc: raise HTTPException(status_code=500, detail=str(exc)) diff --git a/src/backend/langflow/services/store/service.py b/src/backend/langflow/services/store/service.py index 23c0d9656..dd039f691 100644 --- a/src/backend/langflow/services/store/service.py +++ b/src/backend/langflow/services/store/service.py @@ -314,7 +314,10 @@ class StoreService(Service): params = { "fields": ",".join(["id", "count(liked_by)"]), } - likes = self._get(url, api_key, params) + result = self._get(url, api_key, params) + if len(result) == 0: + raise ValueError("Component not found") + likes = result[0]["liked_by_count"] return likes def like_component(self, api_key: str, component_id: str) -> bool: