From 877d4dc0ed34c8f09b8d5d9ec3062230c3bcf3cc Mon Sep 17 00:00:00 2001 From: anovazzi1 Date: Thu, 28 Nov 2024 14:41:52 -0300 Subject: [PATCH] Refactor: Improve performance of sliderComponent tests (#4923) --- src/frontend/tests/core/unit/sliderComponent.spec.ts | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/frontend/tests/core/unit/sliderComponent.spec.ts b/src/frontend/tests/core/unit/sliderComponent.spec.ts index 0ac3e4982..d1263401f 100644 --- a/src/frontend/tests/core/unit/sliderComponent.spec.ts +++ b/src/frontend/tests/core/unit/sliderComponent.spec.ts @@ -29,7 +29,9 @@ test( while (modalCount === 0) { await page.getByText("New Flow", { exact: true }).click(); - await page.waitForTimeout(3000); + await page.waitForSelector('[data-testid="modal-title"]', { + timeout: 3000, + }); modalCount = await page.getByTestId("modal-title")?.count(); } @@ -43,7 +45,9 @@ test( await page.getByTestId("sidebar-search-input").click(); await page.getByTestId("sidebar-search-input").fill("ollama"); - await page.waitForTimeout(1000); + await page.waitForSelector('[data-testid="modelsOllama"]', { + timeout: 3000, + }); await page .getByTestId("modelsOllama") @@ -75,7 +79,6 @@ test( await page.keyboard.press("Backspace"); await page.locator("textarea").last().fill(cleanCode); await page.locator('//*[@id="checkAndSaveBtn"]').click(); - await page.waitForTimeout(500); await page.getByTestId("fit_view").click(); @@ -83,6 +86,8 @@ test( await moveSlider(page, "right", false); + // wait for the slider to update + await page.waitForTimeout(500); await page.getByTestId("zoom_out").click();