From ec7a5fdbd67dc4fcedb5f75d535cd42892e7f503 Mon Sep 17 00:00:00 2001 From: Cristhian Zanforlin Lousa Date: Fri, 8 Sep 2023 10:45:43 -0300 Subject: [PATCH 1/3] =?UTF-8?q?=F0=9F=90=9B=20fix(floatComponent):=20updat?= =?UTF-8?q?e=20min=20and=20max=20values=20to=20-2=20and=20+2=20respectivel?= =?UTF-8?q?y=20for=20better=20range=20=F0=9F=94=A7=20chore(floatComponent)?= =?UTF-8?q?:=20update=20placeholder=20text=20to=20reflect=20the=20new=20ra?= =?UTF-8?q?nge=20of=20-2=20to=202?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/frontend/src/components/floatComponent/index.tsx | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/frontend/src/components/floatComponent/index.tsx b/src/frontend/src/components/floatComponent/index.tsx index 88e958fc9..46c5b98f2 100644 --- a/src/frontend/src/components/floatComponent/index.tsx +++ b/src/frontend/src/components/floatComponent/index.tsx @@ -10,8 +10,8 @@ export default function FloatComponent({ editNode = false, }: FloatComponentType): JSX.Element { const step = 0.1; - const min = 0; - const max = 1; + const min = -2; + const max = +2; // Clear component state useEffect(() => { @@ -27,10 +27,10 @@ export default function FloatComponent({ step={step} min={min} onInput={(event: React.ChangeEvent) => { - if (event.target.value < min.toString()) { + if (Number(event.target.value) < min) { event.target.value = min.toString(); } - if (event.target.value > max.toString()) { + if (Number(event.target.value) > max) { event.target.value = max.toString(); } }} @@ -39,7 +39,7 @@ export default function FloatComponent({ disabled={disabled} className={editNode ? "input-edit-node" : ""} placeholder={ - editNode ? "Number 0 to 1" : "Type a number from zero to one" + editNode ? "Number -2 to 2" : "Type a number from minus two to two" } onChange={(event) => { onChange(event.target.value); From e6afd6704f09c112bbaf469ea0d192cb25768e45 Mon Sep 17 00:00:00 2001 From: Cristhian Zanforlin Lousa Date: Fri, 8 Sep 2023 10:46:09 -0300 Subject: [PATCH 2/3] =?UTF-8?q?=F0=9F=90=9B=20fix(floatComponent):=20fix?= =?UTF-8?q?=20typo=20in=20max=20variable=20assignment=20to=20remove=20unne?= =?UTF-8?q?cessary=20plus=20sign?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/frontend/src/components/floatComponent/index.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/frontend/src/components/floatComponent/index.tsx b/src/frontend/src/components/floatComponent/index.tsx index 46c5b98f2..454d3b601 100644 --- a/src/frontend/src/components/floatComponent/index.tsx +++ b/src/frontend/src/components/floatComponent/index.tsx @@ -11,7 +11,7 @@ export default function FloatComponent({ }: FloatComponentType): JSX.Element { const step = 0.1; const min = -2; - const max = +2; + const max = 2; // Clear component state useEffect(() => { From 4c0874ee8326d3fb53f7e4fe473acc96dc5b46bb Mon Sep 17 00:00:00 2001 From: Cristhian Zanforlin Lousa Date: Mon, 11 Sep 2023 09:22:21 -0300 Subject: [PATCH 3/3] =?UTF-8?q?=F0=9F=90=9B=20fix(intComponent):=20fix=20c?= =?UTF-8?q?omparison=20bug=20in=20onInput=20event=20handler=20to=20correct?= =?UTF-8?q?ly=20compare=20input=20value=20with=20min=20value?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/frontend/src/components/intComponent/index.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/frontend/src/components/intComponent/index.tsx b/src/frontend/src/components/intComponent/index.tsx index 110f593c4..dffb1b1f8 100644 --- a/src/frontend/src/components/intComponent/index.tsx +++ b/src/frontend/src/components/intComponent/index.tsx @@ -44,7 +44,7 @@ export default function IntComponent({ step="1" min={min} onInput={(event: React.ChangeEvent) => { - if (event.target.value < min.toString()) { + if (Number(event.target.value) < min) { event.target.value = min.toString(); } }}