jyapayne/langflow
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

🐛 fix(custom_component.py): handle case when return_type is None to prevent errors

Browse source 
🐛 fix(test_custom_component.py): update assertion to expect return_type as a list instead of a string
🐛 fix(test_vectorstore_template.py): update assertion to check if all vectorstores in settings are present in the response
This commit is contained in:
Gabriel Luiz Freitas Almeida 2023-08-09 17:50:03 -03:00
commit 8c41415a32
3 changed files with 7 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/backend/langflow/interface/custom/custom_component.py
View file

@ -118,6 +118,8 @@ class CustomComponent(Component, extra=Extra.allow):
build_method = build_methods[0] build_method = build_methods[0]
return_type = build_method["return_type"] return_type = build_method["return_type"]
if not return_type:
return []
# If the return type is not a Union, then we just return it as a list # If the return type is not a Union, then we just return it as a list
if "Union" not in return_type: if "Union" not in return_type:
return [return_type] if return_type in self.return_type_valid_list else [] return [return_type] if return_type in self.return_type_valid_list else []

6
tests/test_custom_component.py
View file

@ -241,7 +241,7 @@ def test_custom_component_get_function_entrypoint_return_type():
code=code_default, function_entrypoint_name="build" code=code_default, function_entrypoint_name="build"
) )
return_type = custom_component.get_function_entrypoint_return_type return_type = custom_component.get_function_entrypoint_return_type
assert return_type == "Document" assert return_type == ["Document"]
def test_custom_component_get_main_class_name(): def test_custom_component_get_main_class_name():
@ -436,7 +436,7 @@ class MyClass(CustomComponent):
custom_component = CustomComponent(code=my_code, function_entrypoint_name="build") custom_component = CustomComponent(code=my_code, function_entrypoint_name="build")
return_type = custom_component.get_function_entrypoint_return_type return_type = custom_component.get_function_entrypoint_return_type
assert return_type is None assert return_type == []
def test_custom_component_get_main_class_name_no_main_class(): def test_custom_component_get_main_class_name_no_main_class():
@ -469,7 +469,7 @@ def test_build_config_no_code():
component = CustomComponent(code=None) component = CustomComponent(code=None)
assert component.get_function_entrypoint_args == "" assert component.get_function_entrypoint_args == ""
assert component.get_function_entrypoint_return_type == "" assert component.get_function_entrypoint_return_type == []
@pytest.fixture @pytest.fixture

3
tests/test_vectorstore_template.py
View file

@ -9,4 +9,5 @@ def test_vectorstores_settings(client: TestClient):
assert response.status_code == 200 assert response.status_code == 200
json_response = response.json() json_response = response.json()
vectorstores = json_response["vectorstores"] vectorstores = json_response["vectorstores"]
assert set(vectorstores.keys()) == set(settings.VECTORSTORES) settings_vecs = set(settings.VECTORSTORES)
assert all(vs in vectorstores for vs in settings_vecs)