From 8c73d5d14779ee71bd73df0c243a7a6cd27219bb Mon Sep 17 00:00:00 2001
From: anovazzi1 <otavio2204@gmail.com>
Date: Thu, 5 Dec 2024 15:00:16 -0300
Subject: [PATCH] Refactor: refactor wait times and selectors in
 filterEdge-shard-1.spec.ts (#5049)

* refactor: Update wait times and selectors in filterEdge-shard-1.spec.ts
---
 .../features/filterEdge-shard-1.spec.ts       | 28 +++++++++++--------
 1 file changed, 16 insertions(+), 12 deletions(-)

diff --git a/src/frontend/tests/extended/features/filterEdge-shard-1.spec.ts b/src/frontend/tests/extended/features/filterEdge-shard-1.spec.ts
index 55eb86748..28b7122cd 100644
--- a/src/frontend/tests/extended/features/filterEdge-shard-1.spec.ts
+++ b/src/frontend/tests/extended/features/filterEdge-shard-1.spec.ts
@@ -25,23 +25,23 @@ test(
 
     while (modalCount === 0) {
       await page.getByText("New Flow", { exact: true }).click();
-      await page.waitForTimeout(3000);
+      await page.waitForSelector('[data-testid="modal-title"]', {
+        timeout: 3000,
+      });
       modalCount = await page.getByTestId("modal-title")?.count();
     }
-    await page.waitForTimeout(1000);
-
-    await page.getByTestId(
-      "input-list-plus-btn-edit_metadata_indexing_include-2",
-    );
 
     await page.getByTestId("blank-flow").click();
 
-    await page.waitForTimeout(1000);
+    await page.waitForSelector('[data-testid="sidebar-options-trigger"]', {
+      timeout: 3000,
+    });
 
     await page.getByTestId("sidebar-options-trigger").click();
-    await page
-      .getByTestId("sidebar-legacy-switch")
-      .isVisible({ timeout: 5000 });
+
+    await expect(page.getByTestId("sidebar-legacy-switch")).toBeVisible({
+      timeout: 5000,
+    });
     await page.getByTestId("sidebar-legacy-switch").click();
     await expect(page.getByTestId("sidebar-legacy-switch")).toBeChecked();
     await page.getByTestId("sidebar-options-trigger").click();
@@ -49,7 +49,12 @@ test(
     await page.getByTestId("sidebar-search-input").click();
     await page.getByTestId("sidebar-search-input").fill("retrievalqa");
 
-    await page.waitForTimeout(1000);
+    await page.waitForSelector(
+      '[data-testid="langchain_utilitiesRetrieval QA"]',
+      {
+        timeout: 3000,
+      },
+    );
     await page
       .getByTestId("langchain_utilitiesRetrieval QA")
       .dragTo(page.locator('//*[@id="react-flow-id"]'));
@@ -59,7 +64,6 @@ test(
     await page.getByTestId("zoom_out").click();
     await page.getByTestId("zoom_out").click();
     await page.getByTestId("zoom_out").click();
-    await page.waitForTimeout(500);
 
     let visibleElementHandle;