From 95314e3fca11c7ffbc3534b280d1cf02f17e82cc Mon Sep 17 00:00:00 2001 From: Gabriel Luiz Freitas Almeida Date: Tue, 7 Jan 2025 09:47:14 -0300 Subject: [PATCH] tests: allow tests to skip version tests if `file_names_mapping` is empty (#5562) fix(tests): update ComponentTestBase to skip tests when file_names_mapping is empty - Modified the test method to skip the test instead of raising an AssertionError when no file names mapping is provided. - Improved user feedback by providing a clear message indicating the reason for skipping the test. --- src/backend/tests/base.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/backend/tests/base.py b/src/backend/tests/base.py index 3e463f962..68c02076c 100644 --- a/src/backend/tests/base.py +++ b/src/backend/tests/base.py @@ -53,11 +53,8 @@ class ComponentTestBase: def test_all_versions_have_a_file_name_defined(self, file_names_mapping: list[VersionComponentMapping]) -> None: """Ensure all supported versions have a file name defined.""" if not file_names_mapping: - msg = ( - f"file_names_mapping is empty for {self.__class__.__name__}. " - "Please define the version mappings for your component." - ) - raise AssertionError(msg) + msg = f"file_names_mapping is empty for {self.__class__.__name__}. Skipping versions test." + pytest.skip(msg) version_mappings = {mapping["version"]: mapping for mapping in file_names_mapping} @@ -94,6 +91,8 @@ class ComponentTestBase: file_names_mapping: list[VersionComponentMapping], ) -> None: """Test if the component works across different versions.""" + if not file_names_mapping: + pytest.skip("No file names mapping defined for this component.") version_mappings = {mapping["version"]: mapping for mapping in file_names_mapping} mapping = version_mappings[version]