From 9c004e76463f9c140a719b55f6594b4edb3a5ed1 Mon Sep 17 00:00:00 2001 From: Cristhian Zanforlin Lousa Date: Tue, 12 Nov 2024 23:09:33 -0300 Subject: [PATCH] refactor: increase search sensitivity and simplify metadata filtering in FlowSidebarComponent (#4546) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 🔧 (traditional-search-metadata.ts): Simplify filtering logic to only consider item metadata for search 🔧 (index.tsx): Adjust search threshold value to improve search accuracy --- .../helpers/traditional-search-metadata.ts | 5 +---- .../pages/FlowPage/components/flowSidebarComponent/index.tsx | 3 +-- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/src/frontend/src/pages/FlowPage/components/flowSidebarComponent/helpers/traditional-search-metadata.ts b/src/frontend/src/pages/FlowPage/components/flowSidebarComponent/helpers/traditional-search-metadata.ts index c7fa6deb6..be8cde919 100644 --- a/src/frontend/src/pages/FlowPage/components/flowSidebarComponent/helpers/traditional-search-metadata.ts +++ b/src/frontend/src/pages/FlowPage/components/flowSidebarComponent/helpers/traditional-search-metadata.ts @@ -11,10 +11,7 @@ export const traditionalSearchMetadata = ( const filteredItems = Object.fromEntries( Object.entries(items).filter( ([key, item]) => - normalizeString(key).includes(searchTerm) || - normalizeString(item.display_name).includes(searchTerm) || - normalizeString(category).includes(searchTerm) || - (item.metadata && searchInMetadata(item.metadata, searchTerm)), + item.metadata && searchInMetadata(item.metadata, searchTerm), ), ); return [category, filteredItems]; diff --git a/src/frontend/src/pages/FlowPage/components/flowSidebarComponent/index.tsx b/src/frontend/src/pages/FlowPage/components/flowSidebarComponent/index.tsx index 32df5a31f..a0a1f788c 100644 --- a/src/frontend/src/pages/FlowPage/components/flowSidebarComponent/index.tsx +++ b/src/frontend/src/pages/FlowPage/components/flowSidebarComponent/index.tsx @@ -133,7 +133,7 @@ export function FlowSidebarComponent() { useEffect(() => { const options = { keys: ["display_name", "description", "type", "category"], - threshold: 0.3, + threshold: 0.2, }; const fuseData = Object.entries(data).flatMap(([category, items]) => @@ -171,7 +171,6 @@ export function FlowSidebarComponent() { if (fuse) { const fuseResults = fuse.search(search); setSortedCategories(fuseResults.map((result) => result.item.category)); - combinedResults = combinedResultsFn(fuseResults, data); const traditionalResults = traditionalSearchMetadata(data, searchTerm);