From 9cfbe0f2162643e69ada1960afe3df814af63cac Mon Sep 17 00:00:00 2001
From: Gabriel Luiz Freitas Almeida <gabriel@logspace.ai>
Date: Sun, 31 Mar 2024 10:38:01 -0300
Subject: [PATCH] Fix rangeSpec bug and handle response error in
 ParameterComponent

---
 .../base/langflow/interface/custom/utils.py      |  6 +++---
 .../components/parameterComponent/index.tsx      | 16 +++++++++++-----
 .../src/components/codeTabsComponent/index.tsx   |  5 +++++
 .../src/components/intComponent/index.tsx        |  4 +++-
 .../components/nodeToolbarComponent/index.tsx    |  2 +-
 src/frontend/src/types/components/index.ts       |  1 +
 6 files changed, 24 insertions(+), 10 deletions(-)

diff --git a/src/backend/base/langflow/interface/custom/utils.py b/src/backend/base/langflow/interface/custom/utils.py
index c6daa4fe2..2935a363a 100644
--- a/src/backend/base/langflow/interface/custom/utils.py
+++ b/src/backend/base/langflow/interface/custom/utils.py
@@ -269,6 +269,9 @@ def run_build_config(
             # Allow user to build TemplateField as well
             # as a dict with the same keys as TemplateField
             field_dict = get_field_dict(field)
+            # Let's check if "rangeSpec" is a RangeSpec object
+            if "rangeSpec" in field_dict and isinstance(field_dict["rangeSpec"], RangeSpec):
+                field_dict["rangeSpec"] = field_dict["rangeSpec"].model_dump()
             build_config[field_name] = field_dict
 
         return build_config, custom_instance
@@ -423,9 +426,6 @@ def update_field_dict(
                 logger.error(f"Error while running update_build_config: {str(exc)}")
                 raise UpdateBuildConfigError(f"Error while running update_build_config: {str(exc)}") from exc
 
-    # Let's check if "range_spec" is a RangeSpec object
-    if "rangeSpec" in field_dict and isinstance(field_dict["rangeSpec"], RangeSpec):
-        field_dict["rangeSpec"] = field_dict["rangeSpec"].model_dump()
     return build_config
 
 
diff --git a/src/frontend/src/CustomNodes/GenericNode/components/parameterComponent/index.tsx b/src/frontend/src/CustomNodes/GenericNode/components/parameterComponent/index.tsx
index 39d13861e..3dd5e3de9 100644
--- a/src/frontend/src/CustomNodes/GenericNode/components/parameterComponent/index.tsx
+++ b/src/frontend/src/CustomNodes/GenericNode/components/parameterComponent/index.tsx
@@ -27,7 +27,11 @@ import useAlertStore from "../../../../stores/alertStore";
 import useFlowStore from "../../../../stores/flowStore";
 import useFlowsManagerStore from "../../../../stores/flowsManagerStore";
 import { useTypesStore } from "../../../../stores/typesStore";
-import { APIClassType, ResponseErrorTypeAPI } from "../../../../types/api";
+import {
+  APIClassType,
+  ResponseErrorDetailAPI,
+  ResponseErrorTypeAPI,
+} from "../../../../types/api";
 import { ParameterComponentType } from "../../../../types/components";
 import {
   handleUpdateValues,
@@ -104,10 +108,11 @@ export default function ParameterComponent({
         });
       }
     } catch (error) {
-      let responseError = error as ResponseErrorTypeAPI;
+      let responseError = error as ResponseErrorDetailAPI;
+
       setErrorData({
         title: "Error while updating the Component",
-        list: [responseError.response.data.detail.error ?? "Unknown error"],
+        list: [responseError.response.data.detail ?? "Unknown error"],
       });
     }
     setIsLoading(false);
@@ -136,10 +141,11 @@ export default function ParameterComponent({
             });
           }
         } catch (error) {
-          let responseError = error as ResponseErrorTypeAPI;
+          let responseError = error as ResponseErrorDetailAPI;
+
           setErrorData({
             title: "Error while updating the Component",
-            list: [responseError.response.data.detail.error ?? "Unknown error"],
+            list: [responseError.response.data.detail ?? "Unknown error"],
           });
         }
         setIsLoading(false);
diff --git a/src/frontend/src/components/codeTabsComponent/index.tsx b/src/frontend/src/components/codeTabsComponent/index.tsx
index eed6e9369..7ebc76626 100644
--- a/src/frontend/src/components/codeTabsComponent/index.tsx
+++ b/src/frontend/src/components/codeTabsComponent/index.tsx
@@ -566,6 +566,11 @@ export default function CodeTabsComponent({
                                                 <IntComponent
                                                   disabled={false}
                                                   editNode={true}
+                                                  rangeSpec={
+                                                    node.data.node.template[
+                                                      templateField
+                                                    ].rangeSpec
+                                                  }
                                                   value={
                                                     !node.data.node.template[
                                                       templateField
diff --git a/src/frontend/src/components/intComponent/index.tsx b/src/frontend/src/components/intComponent/index.tsx
index d2f7b5fbc..348ed997a 100644
--- a/src/frontend/src/components/intComponent/index.tsx
+++ b/src/frontend/src/components/intComponent/index.tsx
@@ -9,6 +9,7 @@ import { Input } from "../ui/input";
 export default function IntComponent({
   value,
   onChange,
+  rangeSpec,
   disabled,
   editNode = false,
   id = "",
@@ -32,7 +33,8 @@ export default function IntComponent({
         }}
         type="number"
         step="1"
-        min={0}
+        min={rangeSpec?.min ?? min}
+        max={rangeSpec?.max ?? undefined}
         onInput={(event: React.ChangeEvent<HTMLInputElement>) => {
           if (Number(event.target.value) < min) {
             event.target.value = min.toString();
diff --git a/src/frontend/src/pages/FlowPage/components/nodeToolbarComponent/index.tsx b/src/frontend/src/pages/FlowPage/components/nodeToolbarComponent/index.tsx
index 2e5ba323f..d15c091a1 100644
--- a/src/frontend/src/pages/FlowPage/components/nodeToolbarComponent/index.tsx
+++ b/src/frontend/src/pages/FlowPage/components/nodeToolbarComponent/index.tsx
@@ -317,7 +317,7 @@ export default function NodeToolbarComponent({
         selected &&
         (event.ctrlKey || event.metaKey) &&
         event.shiftKey &&
-        event.key === "C"
+        event.key === "U"
       ) {
         event.preventDefault();
         if (hasCode) return setOpenModal((state) => !state);
diff --git a/src/frontend/src/types/components/index.ts b/src/frontend/src/types/components/index.ts
index 378fa8674..469749b88 100644
--- a/src/frontend/src/types/components/index.ts
+++ b/src/frontend/src/types/components/index.ts
@@ -170,6 +170,7 @@ export type RangeSpecType = {
 export type IntComponentType = {
   value: string;
   disabled?: boolean;
+  rangeSpec: RangeSpecType;
   onChange: (value: string) => void;
   editNode?: boolean;
   id?: string;