From a30298f0e3dfa455c91b120aab8ff2e904827376 Mon Sep 17 00:00:00 2001 From: anovazzi1 Date: Fri, 29 Nov 2024 14:24:55 -0300 Subject: [PATCH] Refactor: remove timeouts and update selectors in linkComponent.spec.ts (#4917) * fix: update timeouts and selectors in linkComponent.spec.ts --- .../tests/core/unit/linkComponent.spec.ts | 22 ++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/src/frontend/tests/core/unit/linkComponent.spec.ts b/src/frontend/tests/core/unit/linkComponent.spec.ts index 2f358ab5b..67f97fee0 100644 --- a/src/frontend/tests/core/unit/linkComponent.spec.ts +++ b/src/frontend/tests/core/unit/linkComponent.spec.ts @@ -27,7 +27,9 @@ test( while (modalCount === 0) { await page.getByText("New Flow", { exact: true }).click(); - await page.waitForTimeout(3000); + await page.waitForSelector('[data-testid="modal-title"]', { + timeout: 3000, + }); modalCount = await page.getByTestId("modal-title")?.count(); } @@ -39,7 +41,12 @@ test( }); await page.getByTestId("blank-flow").click(); - await page.waitForTimeout(1000); + await page.waitForSelector( + '[data-testid="sidebar-custom-component-button"]', + { + timeout: 3000, + }, + ); await page.getByTestId("sidebar-custom-component-button").click(); await page.getByTitle("fit view").click(); @@ -47,9 +54,11 @@ test( await page.getByTestId("title-Custom Component").first().click(); - await page.waitForTimeout(500); + await page.waitForSelector('[data-testid="code-button-modal"]', { + timeout: 3000, + }); + await page.getByTestId("code-button-modal").click(); - await page.waitForTimeout(500); let cleanCode = await extractAndCleanCode(page); @@ -83,7 +92,10 @@ test( await page.keyboard.press("Backspace"); await page.locator("textarea").last().fill(cleanCode); await page.locator('//*[@id="checkAndSaveBtn"]').click(); - await page.waitForTimeout(500); + + await page.waitForSelector('[data-testid="fit_view"]', { + timeout: 3000, + }); await page.getByTestId("fit_view").click(); await page.getByTestId("zoom_out").click();