Refactor buildVertices function to improve performance and update UI during vertex building
This commit is contained in:
parent
4cfb09a69a
commit
a40dc03a93
1 changed files with 16 additions and 6 deletions
|
|
@ -51,17 +51,20 @@ export async function buildVertices({
|
||||||
|
|
||||||
// Set each vertex state to building
|
// Set each vertex state to building
|
||||||
const buildResults: Array<boolean> = [];
|
const buildResults: Array<boolean> = [];
|
||||||
|
// by not using Promise.all, we can update the UI as we build each vertex
|
||||||
|
// and not wait for all of them to finish
|
||||||
|
// by not using await, we can start building the next vertex without waiting for the previous one to finish
|
||||||
for (let i = 0; i < vertices.length; i += 1) {
|
for (let i = 0; i < vertices.length; i += 1) {
|
||||||
if (onBuildStart) onBuildStart(vertices[i]);
|
if (onBuildStart) onBuildStart(vertices[i]);
|
||||||
for (const id of vertices[i]) {
|
for (const id of vertices[i]) {
|
||||||
buildVertex(
|
await buildVertex({
|
||||||
flowId,
|
flowId,
|
||||||
id,
|
id,
|
||||||
onBuildUpdate,
|
onBuildUpdate,
|
||||||
onBuildError,
|
onBuildError,
|
||||||
verticesIds,
|
verticesIds,
|
||||||
buildResults
|
buildResults,
|
||||||
);
|
});
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
@ -71,14 +74,21 @@ export async function buildVertices({
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
async function buildVertex(
|
async function buildVertex({
|
||||||
flowId,
|
flowId,
|
||||||
id,
|
id,
|
||||||
onBuildUpdate,
|
onBuildUpdate,
|
||||||
onBuildError,
|
onBuildError,
|
||||||
verticesIds,
|
verticesIds,
|
||||||
buildResults
|
buildResults,
|
||||||
) {
|
}: {
|
||||||
|
flowId: string;
|
||||||
|
id: string;
|
||||||
|
onBuildUpdate?: (data: any) => void;
|
||||||
|
onBuildError?: (title, list, idList: string[]) => void;
|
||||||
|
verticesIds: string[];
|
||||||
|
buildResults: boolean[];
|
||||||
|
}) {
|
||||||
try {
|
try {
|
||||||
const buildRes = await postBuildVertex(flowId, id);
|
const buildRes = await postBuildVertex(flowId, id);
|
||||||
const buildData: VertexBuildTypeAPI = buildRes.data;
|
const buildData: VertexBuildTypeAPI = buildRes.data;
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue