Fix: using space in shortcuts table break the app

This commit is contained in:
igorrCarvalho 2024-06-08 20:17:53 -03:00
commit a7187ff723
3 changed files with 24 additions and 19 deletions

View file

@ -46,8 +46,8 @@ export default function NodeToolbarComponent({
setShowState,
onCloseAdvancedModal,
isOutdated,
openWDoubleClick,
setOpenWDoubleClick,
// openWDoubleClick,
// setOpenWDoubleClick,
}: nodeToolbarPropsType): JSX.Element {
const nodeLength = Object.keys(data.node!.template).filter(
(templateField) =>
@ -206,9 +206,9 @@ export default function NodeToolbarComponent({
createFlowComponent(cloneDeep(data), version),
);
useEffect(() => {
if (openWDoubleClick) setShowModalAdvanced(true);
}, [openWDoubleClick, setOpenWDoubleClick]);
// useEffect(() => {
// if (openWDoubleClick) setShowModalAdvanced(true);
// }, [openWDoubleClick, setOpenWDoubleClick]);
const openInNewTab = (url) => {
window.open(url, "_blank", "noreferrer");
@ -697,7 +697,7 @@ export default function NodeToolbarComponent({
</ConfirmationModal>
{showModalAdvanced && (
<EditNodeModal
setOpenWDoubleClick={setOpenWDoubleClick}
// setOpenWDoubleClick={setOpenWDoubleClick}
data={data}
nodeLength={nodeLength}
open={showModalAdvanced}

View file

@ -40,8 +40,6 @@ export default function EditShortcutButton({
const unavaliableShortcuts = useShortcutsStore(
(state) => state.unavailableShortcuts,
);
const a = useShortcutsStore((state) => state.advanced);
console.log(a);
const setErrorData = useAlertStore((state) => state.setErrorData);
function canEditCombination(newCombination: string): boolean {
@ -138,6 +136,11 @@ export default function EditShortcutButton({
if (e.key?.toLowerCase() === "meta") {
fixedKey = "Cmd";
}
if (e.key?.toLowerCase() === " ") {
fixedKey = "Space";
}
if (shortcutInitialValue?.toUpperCase().includes(fixedKey.toUpperCase()))
return;
setKey((oldKey) =>
getFixedCombination({ oldKey: oldKey!, key: fixedKey }),
);

View file

@ -68,17 +68,19 @@ export default function ShortcutsPage() {
<div>
<div className="align-end mb-4 flex w-full justify-end">
<div className="justify center flex items-center">
<EditShortcutButton
disable={selectedRows.length === 0}
defaultCombination={combinationToEdit[0]?.shortcut}
shortcut={selectedRows}
defaultShortcuts={shortcuts}
open={open}
setOpen={setOpen}
setSelected={setSelectedRows}
>
<div style={{ display: "none" }} />
</EditShortcutButton>
{open && (
<EditShortcutButton
disable={selectedRows.length === 0}
defaultCombination={combinationToEdit[0]?.shortcut}
shortcut={selectedRows}
defaultShortcuts={shortcuts}
open={open}
setOpen={setOpen}
setSelected={setSelectedRows}
>
<div style={{ display: "none" }} />
</EditShortcutButton>
)}
<Button
variant="primary"
className="ml-3"