From aa5a4a505c9e63dd9c7af67e2235f20d8694ffd1 Mon Sep 17 00:00:00 2001 From: Edwin Jose Date: Fri, 17 Jan 2025 18:36:41 -0500 Subject: [PATCH] refactor: Deprecate Subflow and Flow as Tool component in favor of RunFlow (#5678) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * depreciated subflow and flow as tool * 🐛 (filterSidebar.spec.ts): update test cases to reflect changes in sidebar item names by adding [Deprecated] suffix --------- Co-authored-by: Gabriel Luiz Freitas Almeida Co-authored-by: cristhianzl --- src/backend/base/langflow/components/logic/flow_tool.py | 4 ++-- src/backend/base/langflow/components/logic/sub_flow.py | 4 ++-- src/frontend/tests/core/features/filterSidebar.spec.ts | 8 +++++--- 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/src/backend/base/langflow/components/logic/flow_tool.py b/src/backend/base/langflow/components/logic/flow_tool.py index 673bbd3d4..a7ed4d19a 100644 --- a/src/backend/base/langflow/components/logic/flow_tool.py +++ b/src/backend/base/langflow/components/logic/flow_tool.py @@ -14,12 +14,12 @@ from langflow.schema.dotdict import dotdict class FlowToolComponent(LCToolComponent): - display_name = "Flow as Tool" + display_name = "Flow as Tool [Deprecated]" description = "Construct a Tool from a function that runs the loaded Flow." field_order = ["flow_name", "name", "description", "return_direct"] trace_type = "tool" name = "FlowTool" - beta = True + legacy: bool = True icon = "hammer" async def get_flow_names(self) -> list[str]: diff --git a/src/backend/base/langflow/components/logic/sub_flow.py b/src/backend/base/langflow/components/logic/sub_flow.py index 1908857f3..c6ddd7946 100644 --- a/src/backend/base/langflow/components/logic/sub_flow.py +++ b/src/backend/base/langflow/components/logic/sub_flow.py @@ -12,10 +12,10 @@ from langflow.schema import Data, dotdict class SubFlowComponent(Component): - display_name = "Sub Flow" + display_name = "Sub Flow [Deprecated]" description = "Generates a Component from a Flow, with all of its inputs, and " name = "SubFlow" - beta: bool = True + legacy: bool = True icon = "Workflow" async def get_flow_names(self) -> list[str]: diff --git a/src/frontend/tests/core/features/filterSidebar.spec.ts b/src/frontend/tests/core/features/filterSidebar.spec.ts index 2fd1437a5..8958fad87 100644 --- a/src/frontend/tests/core/features/filterSidebar.spec.ts +++ b/src/frontend/tests/core/features/filterSidebar.spec.ts @@ -124,7 +124,7 @@ test( await expect(page.getByTestId("helpersMessage History")).toBeVisible(); await expect(page.getByTestId("vectorstoresAstra DB")).toBeVisible(); await expect(page.getByTestId("toolsSearch API")).toBeVisible(); - await expect(page.getByTestId("logicSub Flow")).not.toBeVisible(); + await expect(page.getByTestId("logicSub Flow [Deprecated]")).toBeVisible(); await page.getByTestId("sidebar-options-trigger").click(); await page.getByTestId("sidebar-beta-switch").isVisible({ timeout: 5000 }); @@ -132,7 +132,7 @@ test( await expect(page.getByTestId("sidebar-beta-switch")).toBeChecked(); await page.getByTestId("sidebar-options-trigger").click(); - await expect(page.getByTestId("logicSub Flow")).toBeVisible(); + await expect(page.getByTestId("logicSub Flow [Deprecated]")).toBeVisible(); await expect(page.getByTestId("processingSplit Text")).toBeVisible(); await expect(page.getByTestId("toolsSearch API")).toBeVisible(); @@ -143,7 +143,9 @@ test( await expect(page.getByTestId("helpersMessage History")).not.toBeVisible(); await expect(page.getByTestId("vectorstoresAstra DB")).not.toBeVisible(); await expect(page.getByTestId("toolsSearch API")).not.toBeVisible(); - await expect(page.getByTestId("logicSub Flow")).not.toBeVisible(); + await expect( + page.getByTestId("logicSub Flow [Deprecated]"), + ).not.toBeVisible(); await expect(page.getByTestId("processingSplit Text")).not.toBeVisible(); await expect(page.getByTestId("toolsSearch API")).not.toBeVisible();