From aa7ebb4ae3c7ea3050e0005a1597018b4b05a1c3 Mon Sep 17 00:00:00 2001 From: anovazzi1 Date: Sat, 7 Dec 2024 12:18:44 -0300 Subject: [PATCH] Refactor: remove timeouts from generalbugs-shard10 (#5140) remove timeouts from generalbugs-shard10 --- .../regression/generalBugs-shard-10.spec.ts | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/frontend/tests/extended/regression/generalBugs-shard-10.spec.ts b/src/frontend/tests/extended/regression/generalBugs-shard-10.spec.ts index 50a86f9a9..661e1b2a3 100644 --- a/src/frontend/tests/extended/regression/generalBugs-shard-10.spec.ts +++ b/src/frontend/tests/extended/regression/generalBugs-shard-10.spec.ts @@ -16,7 +16,6 @@ test( } await page.goto("/"); - await page.waitForTimeout(1000); const promptText = "answer as you are a dog"; const newPromptText = "answer as you are a bird"; @@ -33,13 +32,17 @@ test( while (modalCount === 0) { await page.getByText("New Flow", { exact: true }).click(); - await page.waitForTimeout(3000); + await page.waitForSelector('[data-testid="modal-title"]', { + timeout: 3000, + }); modalCount = await page.getByTestId("modal-title")?.count(); } await page.getByTestId("side_nav_options_all-templates").click(); await page.getByRole("heading", { name: "Basic Prompting" }).click(); - await page.waitForTimeout(1000); + await page.waitForSelector('[data-testid="fit_view"]', { + timeout: 3000, + }); await page.getByTestId("fit_view").click(); @@ -70,8 +73,6 @@ test( await page.getByText("Check & Save").click(); - await page.waitForTimeout(1000); - await page.getByTestId("button_run_chat output").click(); await page.waitForSelector("text=built successfully", { timeout: 30000 }); @@ -84,7 +85,6 @@ test( const concatAllText = textContents.join(" "); - await page.waitForTimeout(1000); await page.getByText("Close").last().click(); await page.getByText("Prompt", { exact: true }).click(); @@ -92,7 +92,6 @@ test( await page.getByText("Freeze", { exact: true }).last().click(); - await page.waitForTimeout(1000); await page.locator('//*[@id="react-flow-id"]').click(); expect(page.getByTestId("icon-Snowflake").first()).toBeVisible();