From af66bc69273017bba728c49bafa32bdd0a310d09 Mon Sep 17 00:00:00 2001 From: Igor Carvalho Date: Mon, 24 Jul 2023 16:47:50 -0300 Subject: [PATCH] =?UTF-8?q?Add=20comments=20to=20Ot=C3=A1vio=20help?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/frontend/src/CustomNodes/GenericNode/index.tsx | 1 + .../src/components/genericIconComponent/index.tsx | 1 + src/frontend/src/modals/ApiModal/index.tsx | 12 +++++++----- .../FlowPage/components/PageComponent/index.tsx | 5 +++-- 4 files changed, 12 insertions(+), 7 deletions(-) diff --git a/src/frontend/src/CustomNodes/GenericNode/index.tsx b/src/frontend/src/CustomNodes/GenericNode/index.tsx index ddfea1037..af5f5a996 100644 --- a/src/frontend/src/CustomNodes/GenericNode/index.tsx +++ b/src/frontend/src/CustomNodes/GenericNode/index.tsx @@ -26,6 +26,7 @@ export default function GenericNode({ const { closePopUp, openPopUp } = useContext(PopUpContext); // any to avoid type conflict + // PROBLEM HERE OTAVIO const Icon: any = nodeIconsLucide[data.type] || nodeIconsLucide[types[data.type]]; const name = nodeIconsLucide[data.type] ? data.type : types[data.type]; diff --git a/src/frontend/src/components/genericIconComponent/index.tsx b/src/frontend/src/components/genericIconComponent/index.tsx index 32647f159..e25f5e5a5 100644 --- a/src/frontend/src/components/genericIconComponent/index.tsx +++ b/src/frontend/src/components/genericIconComponent/index.tsx @@ -6,6 +6,7 @@ export default function IconComponent({ className, iconColor, }: IconComponentProps): JSX.Element { + // MAYBE PROBLEM HERE? const TargetIcon = nodeIconsLucide[name] ?? nodeIconsLucide["unknown"]; return ; } diff --git a/src/frontend/src/modals/ApiModal/index.tsx b/src/frontend/src/modals/ApiModal/index.tsx index 6afad22b5..c1071d9c4 100644 --- a/src/frontend/src/modals/ApiModal/index.tsx +++ b/src/frontend/src/modals/ApiModal/index.tsx @@ -45,7 +45,7 @@ import { EXPORT_CODE_DIALOG } from "../../constants/constants"; import { darkContext } from "../../contexts/darkContext"; import { PopUpContext } from "../../contexts/popUpContext"; import { TabsContext } from "../../contexts/tabsContext"; -import { FlowType } from "../../types/flow/index"; +import { FlowType, NodeDataType } from "../../types/flow/index"; import { buildTweaks } from "../../utils/reactflowUtils"; import { classNames, @@ -173,7 +173,8 @@ export default function ApiModal({ flow }: { flow: FlowType }): JSX.Element { }); } - function buildTweakObject(tw, changes, template) { + // DIFICULT IN FIND WHERE TW,CHANGES AND TEMPLATE ARE USED + function buildTweakObject(tw, changes, template): void { if (template.type === "float") { changes = parseFloat(changes); } @@ -221,7 +222,7 @@ export default function ApiModal({ flow }: { flow: FlowType }): JSX.Element { setTweak(tweak.current); } - function buildContent(value) { + function buildContent(value: string): JSX.Element { const htmlContent = (
{value != null && value != "" ? value : "None"} @@ -230,7 +231,8 @@ export default function ApiModal({ flow }: { flow: FlowType }): JSX.Element { return htmlContent; } - function getValue(value, node, template) { + // DIFICULT FINDIND WHERE TEMPLATE IS USED + function getValue(value: string, node: NodeDataType, template): string { let returnValue = value ?? ""; if (getTweak.length > 0) { @@ -252,7 +254,7 @@ export default function ApiModal({ flow }: { flow: FlowType }): JSX.Element { return returnValue; } - function openAccordions() { + function openAccordions(): void { let accordionsToOpen = []; tweak.current.forEach((el) => { Object.keys(el).forEach((key) => { diff --git a/src/frontend/src/pages/FlowPage/components/PageComponent/index.tsx b/src/frontend/src/pages/FlowPage/components/PageComponent/index.tsx index a70ce81ce..f65aa3e4e 100644 --- a/src/frontend/src/pages/FlowPage/components/PageComponent/index.tsx +++ b/src/frontend/src/pages/FlowPage/components/PageComponent/index.tsx @@ -324,7 +324,8 @@ export default function Page({ flow }: { flow: FlowType }): JSX.Element { [reactFlowInstance, setEdges] ); - const onEdgeUpdateEnd = useCallback((_, edge) => { + // IS THIS RIGHT? + const onEdgeUpdateEnd = useCallback((_, edge: { id: string }): void => { if (!edgeUpdateSuccessful.current) { setEdges((eds) => eds.filter((e) => e.id !== edge.id)); } @@ -351,7 +352,7 @@ export default function Page({ flow }: { flow: FlowType }): JSX.Element { } }, [selectionEnded, lastSelection]); - const onSelectionChange = useCallback((flow) => { + const onSelectionChange = useCallback((flow): void => { setLastSelection(flow); }, []);