🐛 fix(base.py): fix import statements for read_secret_from_file and write_secret_to_file functions

🔒 chore(utils.py): add write_secret_to_file and read_secret_from_file functions to handle secret key file read/write operations

src/backend/langflow/services/settings/base.py

@@ -1,7 +1,7 @@
 import contextlib
 import json
 import secrets
-from langflow.services.settings.utils import set_secure_permissions
+from langflow.services.settings.utils import read_secret_from_file, write_secret_to_file
 import orjson
 import os
 from shutil import copy2
@@ -55,31 +55,27 @@ class Settings(BaseSettings):
 
     @validator("SECRET_KEY", pre=True)
     def get_secret_key(cls, value, values):
-        if not value:
+        config_dir = values.get("CONFIG_DIR")
-            logger.debug("No secret key provided, generating a random one")
+
+        if not config_dir:
+            logger.debug("No CONFIG_DIR provided, not saving secret key")
+            return value or secrets.token_urlsafe(32)
 
-            if config_dir := values.get("CONFIG_DIR"):
         secret_key_path = Path(config_dir) / "secret_key"
 
+        if value:
+            logger.debug("Secret key provided")
+            write_secret_to_file(secret_key_path, value)
+        else:
+            logger.debug("No secret key provided, generating a random one")
+
             if secret_key_path.exists():
-                    with open(secret_key_path, "rb") as f:
+                value = read_secret_from_file(secret_key_path)
-                        value = f.read()
                 logger.debug("Loaded secret key")
             else:
                 value = secrets.token_urlsafe(32)
-
+                write_secret_to_file(secret_key_path, value)
-                    with open(secret_key_path, "wb") as f:
-                        f.write(value)
-
-                    # Limit the file permissions
-                    try:
-                        set_secure_permissions(secret_key_path)
-                    except Exception:
-                        logger.error("Failed to set secure permissions on secret key")
-
                 logger.debug("Saved secret key")
-            else:
-                logger.debug("No CONFIG_DIR provided, not saving secret key")
 
         return value
 

src/backend/langflow/services/settings/utils.py

@@ -1,6 +1,9 @@
 import os
+from pathlib import Path
 import platform
 
+from langflow.utils.logger import logger
+
 
 def set_secure_permissions(file_path):
     if platform.system() in ["Linux", "Darwin"]:  # Unix/Linux/Mac
@@ -28,3 +31,17 @@ def set_secure_permissions(file_path):
         )
     else:
         print("Unsupported OS")
+
+
+def write_secret_to_file(path: Path, value: str) -> None:
+    with path.open("wb") as f:
+        f.write(value)
+    try:
+        set_secure_permissions(path)
+    except Exception:
+        logger.error("Failed to set secure permissions on secret key")
+
+
+def read_secret_from_file(path: Path) -> str:
+    with path.open("rb") as f:
+        return f.read()