From b3f82872b0f10a2b1332b5a649654004654f20a1 Mon Sep 17 00:00:00 2001 From: cristhianzl Date: Tue, 20 Feb 2024 10:48:32 -0300 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20fix(GenericNode/index.tsx):=20re?= =?UTF-8?q?name=20getIconComponent=20to=20getIconPlayOrPauseComponent=20fo?= =?UTF-8?q?r=20better=20clarity=20and=20semantics=20=F0=9F=90=9B=20fix(Gen?= =?UTF-8?q?ericNode/index.tsx):=20rename=20renderIconComponents=20to=20ren?= =?UTF-8?q?derIconPlayOrPauseComponents=20for=20better=20clarity=20and=20s?= =?UTF-8?q?emantics=20=F0=9F=90=9B=20fix(GenericNode/index.tsx):=20rename?= =?UTF-8?q?=20getSpecificClass=20to=20getSpecificClassFromBuildStatus=20fo?= =?UTF-8?q?r=20better=20clarity=20and=20semantics=20=F0=9F=90=9B=20fix(Gen?= =?UTF-8?q?ericNode/index.tsx):=20rename=20getNodeClassName=20to=20getNode?= =?UTF-8?q?BorderClassName=20for=20better=20clarity=20and=20semantics?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../src/CustomNodes/GenericNode/index.tsx | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/frontend/src/CustomNodes/GenericNode/index.tsx b/src/frontend/src/CustomNodes/GenericNode/index.tsx index eb16542ef..c7b85c57c 100644 --- a/src/frontend/src/CustomNodes/GenericNode/index.tsx +++ b/src/frontend/src/CustomNodes/GenericNode/index.tsx @@ -157,7 +157,7 @@ export default function GenericNode({ ); }; - const getIconComponent = (name, className) => ( + const getIconPlayOrPauseComponent = (name, className) => ( { if (buildStatus === BuildStatus.BUILDING) { - return getIconComponent("Square", "red-status"); + return getIconPlayOrPauseComponent("Square", "red-status"); } else { const className = getStatusClassName(validationStatus, isBuilding); - return <>{getIconComponent("Play", className)}; + return <>{getIconPlayOrPauseComponent("Play", className)}; } }; - const getSpecificClass = ( + const getSpecificClassFromBuildStatus = ( buildStatus: BuildStatus | undefined, validationStatus: validationStatusType | null ) => { @@ -209,7 +209,7 @@ export default function GenericNode({ } }; - const getNodeClassName = ( + const getNodeBorderClassName = ( selected: boolean, showNode: boolean, buildStatus: BuildStatus | undefined, @@ -219,7 +219,7 @@ export default function GenericNode({ getBaseBorderClass(selected), getNodeSizeClass(showNode), "generic-node-div", - getSpecificClass(buildStatus, validationStatus) + getSpecificClassFromBuildStatus(buildStatus, validationStatus) ); }; @@ -253,7 +253,7 @@ export default function GenericNode({
- {renderIconComponents( + {renderIconPlayOrPauseComponents( data?.build_status, validationStatus, isBuilding