From b83ffc87b28ced5ba1892fe3bfcfb527fca4df76 Mon Sep 17 00:00:00 2001
From: Gabriel Luiz Freitas Almeida <gabriel@logspace.ai>
Date: Sun, 3 Mar 2024 19:19:02 -0300
Subject: [PATCH] Refactor code to improve performance and readability

---
 .../src/CustomNodes/GenericNode/index.tsx     | 101 ++++++++----------
 1 file changed, 43 insertions(+), 58 deletions(-)

diff --git a/src/frontend/src/CustomNodes/GenericNode/index.tsx b/src/frontend/src/CustomNodes/GenericNode/index.tsx
index 8e95946f0..c9844a47d 100644
--- a/src/frontend/src/CustomNodes/GenericNode/index.tsx
+++ b/src/frontend/src/CustomNodes/GenericNode/index.tsx
@@ -138,8 +138,9 @@ export default function GenericNode({
     const iconColor = nodeColors[types[data.type]];
     const iconName =
       iconElement || (data.node?.flow ? "group_components" : name);
-    const iconClassName = `generic-node-icon ${!showNode ? " absolute inset-x-6 h-12 w-12 " : ""
-      }`;
+    const iconClassName = `generic-node-icon ${
+      !showNode ? " absolute inset-x-6 h-12 w-12 " : ""
+    }`;
     if (iconElement && isEmoji) {
       return nodeIconFragment(iconElement);
     } else {
@@ -267,7 +268,7 @@ export default function GenericNode({
           numberOfHandles={handles}
           showNode={showNode}
           openAdvancedModal={false}
-          onCloseAdvancedModal={() => { }}
+          onCloseAdvancedModal={() => {}}
           selected={selected}
         ></NodeToolbarComponent>
       </NodeToolbar>
@@ -389,28 +390,13 @@ export default function GenericNode({
                             })}
                             data={data}
                             color={
-                              data.node?.template[templateField].input_types &&
-                                data.node?.template[templateField].input_types!
-                                  .length > 0
-                                ? nodeColors[
-                                data.node?.template[templateField]
-                                  .input_types![data.node?.template[templateField]
-                                    .input_types!.length - 1]
-                                ] ??
-                                nodeColors[
-                                types[
-                                data.node?.template[templateField]
-                                  .input_types![data.node?.template[templateField]
-                                    .input_types!.length - 1]
-                                ]
-                                ]
-                                : nodeColors[
-                                data.node?.template[templateField].type!
-                                ] ??
-                                nodeColors[
+                              nodeColors[
                                 types[data.node?.template[templateField].type!]
-                                ] ??
-                                nodeColors.unknown
+                              ] ??
+                              nodeColors[
+                                data.node?.template[templateField].type!
+                              ] ??
+                              nodeColors.unknown
                             }
                             title={getFieldTitle(
                               data.node?.template!,
@@ -454,7 +440,7 @@ export default function GenericNode({
                     color={nodeColors[types[data.type]] ?? nodeColors.unknown}
                     title={
                       data.node?.output_types &&
-                        data.node.output_types.length > 0
+                      data.node.output_types.length > 0
                         ? data.node.output_types.join(" | ")
                         : data.type
                     }
@@ -475,6 +461,12 @@ export default function GenericNode({
               <Button
                 variant="secondary"
                 className={"group h-9 px-1.5"}
+                onClick={() => {
+                  if (buildStatus === BuildStatus.BUILDING || isBuilding)
+                    return;
+                  setValidationStatus(null);
+                  buildFlow({ nodeId: data.id });
+                }}
               >
                 <div>
                   <ShadTooltip
@@ -487,22 +479,17 @@ export default function GenericNode({
                         <div className="max-h-96 overflow-auto">
                           {typeof validationStatus.params === "string"
                             ? `${durationString}\n${validationStatus.params}`
-                              .split("\n")
-                              .map((line, index) => (
-                                <div key={index}>{line}</div>
-                              ))
+                                .split("\n")
+                                .map((line, index) => (
+                                  <div key={index}>{line}</div>
+                                ))
                             : durationString}
                         </div>
                       )
                     }
                     side="bottom"
                   >
-                    <div onClick={() => {
-                      if (buildStatus === BuildStatus.BUILDING || isBuilding)
-                        return;
-                      setValidationStatus(null);
-                      buildFlow({ nodeId: data.id });
-                    }} className="generic-node-status-position flex items-center justify-center">
+                    <div className="generic-node-status-position flex items-center justify-center">
                       {renderIconStatus(buildStatus, validationStatus)}
                     </div>
                   </ShadTooltip>
@@ -582,7 +569,7 @@ export default function GenericNode({
                   }}
                 >
                   {(data.node?.description === "" || !data.node?.description) &&
-                    nameEditable
+                  nameEditable
                     ? "Double Click to Edit Description"
                     : data.node?.description}
                 </div>
@@ -603,7 +590,7 @@ export default function GenericNode({
                 .map((templateField: string, idx) => (
                   <div key={idx}>
                     {data.node!.template[templateField].show &&
-                      !data.node!.template[templateField].advanced ? (
+                    !data.node!.template[templateField].advanced ? (
                       <ParameterComponent
                         index={idx.toString()}
                         key={scapedJSONStringfy({
@@ -617,27 +604,25 @@ export default function GenericNode({
                         data={data}
                         color={
                           data.node?.template[templateField].input_types &&
-                            data.node?.template[templateField].input_types!
-                              .length > 0
+                          data.node?.template[templateField].input_types!
+                            .length > 0
                             ? nodeColors[
-                            data.node?.template[templateField]
-                              .input_types![data.node?.template[templateField]
-                                .input_types!.length - 1]
-                            ] ??
-                            nodeColors[
-                            types[
-                            data.node?.template[templateField]
-                              .input_types![data.node?.template[templateField]
-                                .input_types!.length - 1]
-                            ]
-                            ]
+                                data.node?.template[templateField]
+                                  .input_types![0]
+                              ] ??
+                              nodeColors[
+                                types[
+                                  data.node?.template[templateField]
+                                    .input_types![0]
+                                ]
+                              ]
                             : nodeColors[
-                            data.node?.template[templateField].type!
-                            ] ??
-                            nodeColors[
-                            types[data.node?.template[templateField].type!]
-                            ] ??
-                            nodeColors.unknown
+                                data.node?.template[templateField].type!
+                              ] ??
+                              nodeColors[
+                                types[data.node?.template[templateField].type!]
+                              ] ??
+                              nodeColors.unknown
                         }
                         title={getFieldTitle(
                           data.node?.template!,
@@ -689,9 +674,9 @@ export default function GenericNode({
                   data={data}
                   color={
                     (data.node?.output_types &&
-                      data.node.output_types.length > 0
+                    data.node.output_types.length > 0
                       ? nodeColors[data.node.output_types[0]] ??
-                      nodeColors[types[data.node.output_types[0]]]
+                        nodeColors[types[data.node.output_types[0]]]
                       : nodeColors[types[data.type]]) ?? nodeColors.unknown
                   }
                   title={