jyapayne/langflow
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

fix: starter-project was broken in main (#4842)

Browse source 
* fix broken test

* ci: Enhance TypeScript test workflow with debug output and refined release condition

---------

Co-authored-by: Gabriel Luiz Freitas Almeida <gabriel@langflow.org>
This commit is contained in:
anovazzi1 2024-11-25 19:43:34 -03:00 • committed by GitHub
commit b9af310abf
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 13 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

7
.github/workflows/typescript_test.yml vendored
View file

@ -74,6 +74,7 @@ jobs:
id: set-matrix id: set-matrix
run: | run: |
# Start with input suites if provided, otherwise empty array # Start with input suites if provided, otherwise empty array
echo "Changes filter output: ${{ steps.filter.outputs }}"
SUITES='${{ inputs.suites }}' SUITES='${{ inputs.suites }}'
echo "Initial suites: $SUITES" echo "Initial suites: $SUITES"
TEST_GREP="" TEST_GREP=""
@ -81,15 +82,15 @@ jobs:
RELEASE="${{ inputs.release || 'false' }}" RELEASE="${{ inputs.release || 'false' }}"
echo "Release build: $RELEASE" echo "Release build: $RELEASE"
# if release OR steps.filter.outputs.frontend-tests is true # Only set to release if it's explicitly a release build
if [[ "$RELEASE" == "true" || "${{ steps.filter.outputs.frontend-tests }}" == "true" ]]; then if [[ "$RELEASE" == "true" ]]; then
SUITES='["release"]' SUITES='["release"]'
echo "Release build detected - setting suites to: $SUITES" echo "Release build detected - setting suites to: $SUITES"
# No grep pattern for release - run all tests # No grep pattern for release - run all tests
TEST_GREP="" TEST_GREP=""
else else
# If input suites were not provided, determine based on changes # If input suites were not provided, determine based on changes
if [[ "$SUITES" == "[]" ]]; then if [[ "$SUITES" == "[]" ]]; then
echo "No input suites provided - determining from changes" echo "No input suites provided - determining from changes"
TAGS=() TAGS=()
# Add suites and tags based on changed files # Add suites and tags based on changed files

15
src/frontend/tests/core/integrations/starter-projects.spec.ts
View file

@ -66,12 +66,6 @@ test(
modalCount = 0; modalCount = 0;
} }
while (modalCount === 0) {
await page.getByText("New Flow", { exact: true }).click();
await page.waitForTimeout(3000);
modalCount = await page.getByTestId("modal-title")?.count();
}
while (modalCount === 0) { while (modalCount === 0) {
await page.getByText("New Flow", { exact: true }).click(); await page.getByText("New Flow", { exact: true }).click();
await page.waitForSelector('[data-testid="modal-title"]', { await page.waitForSelector('[data-testid="modal-title"]', {
@ -80,6 +74,15 @@ test(
modalCount = await page.getByTestId("modal-title")?.count(); modalCount = await page.getByTestId("modal-title")?.count();
} }
await page.getByTestId("side_nav_options_all-templates").click();
await page
.getByRole("heading", { name: "Vector Store RAG" })
.first()
.click();
await page.waitForSelector('[data-testid="fit_view"]', {
timeout: 100000,
});
await page.getByTestId("fit_view").click(); await page.getByTestId("fit_view").click();
await page.getByTestId("zoom_out").click(); await page.getByTestId("zoom_out").click();