From be712a45afdd51d5b862f18a662dd2f13def54b9 Mon Sep 17 00:00:00 2001 From: Lucas Oliveira Date: Wed, 19 Jul 2023 11:01:23 -0300 Subject: [PATCH] Fixed bug where PromptComponent does not save, but there is no Clean Edges now --- .../components/parameterComponent/index.tsx | 10 ---------- .../src/components/promptComponent/index.tsx | 16 +++++----------- src/frontend/src/modals/genericModal/index.tsx | 2 +- 3 files changed, 6 insertions(+), 22 deletions(-) diff --git a/src/frontend/src/CustomNodes/GenericNode/components/parameterComponent/index.tsx b/src/frontend/src/CustomNodes/GenericNode/components/parameterComponent/index.tsx index e2fb575ab..3516a2242 100644 --- a/src/frontend/src/CustomNodes/GenericNode/components/parameterComponent/index.tsx +++ b/src/frontend/src/CustomNodes/GenericNode/components/parameterComponent/index.tsx @@ -17,7 +17,6 @@ import { MAX_LENGTH_TO_SCROLL_TOOLTIP } from "../../../../constants"; import { TabsContext } from "../../../../contexts/tabsContext"; import { typesContext } from "../../../../contexts/typesContext"; import { ParameterComponentType } from "../../../../types/components"; -import { cleanEdges } from "../../../../util/reactflowUtils"; import { classNames, getRandomKeyByssmm, @@ -314,15 +313,6 @@ export default function ParameterComponent({ field_name={name} setNodeClass={(nodeClass) => { data.node = nodeClass; - if (reactFlowInstance) { - cleanEdges({ - flow: { - edges: reactFlowInstance.getEdges(), - nodes: reactFlowInstance.getNodes(), - }, - updateEdge: (edge) => reactFlowInstance.setEdges(edge), - }); - } }} nodeClass={data.node} disabled={disabled} diff --git a/src/frontend/src/components/promptComponent/index.tsx b/src/frontend/src/components/promptComponent/index.tsx index 49202d3ea..8c4c59038 100644 --- a/src/frontend/src/components/promptComponent/index.tsx +++ b/src/frontend/src/components/promptComponent/index.tsx @@ -1,9 +1,8 @@ -import { useContext, useEffect, useState } from "react"; +import { useEffect } from "react"; import GenericModal from "../../modals/genericModal"; import { TextAreaComponentType } from "../../types/components"; import { ExternalLink } from "lucide-react"; -import { typesContext } from "../../contexts/typesContext"; import { postValidatePrompt } from "../../controllers/API"; export default function PromptAreaComponent({ @@ -15,17 +14,13 @@ export default function PromptAreaComponent({ disabled, editNode = false, }: TextAreaComponentType) { - const [myValue, setMyValue] = useState(value); - const { reactFlowInstance } = useContext(typesContext); useEffect(() => { if (disabled) { - setMyValue(""); onChange(""); } - }, [disabled, onChange]); + }, [disabled]); useEffect(() => { - setMyValue(value); if (value !== "" && !editNode) { postValidatePrompt(field_name, value, nodeClass).then((apiReturn) => { if (apiReturn.data) { @@ -34,17 +29,16 @@ export default function PromptAreaComponent({ } }); } - }, [value, reactFlowInstance]); + }, []); return (
{ - setMyValue(t); onChange(t); }} nodeClass={nodeClass} @@ -59,7 +53,7 @@ export default function PromptAreaComponent({ " input-primary text-muted-foreground " } > - {myValue !== "" ? myValue : "Type your prompt here..."} + {value !== "" ? value : "Type your prompt here..."} {!editNode && ( { if (apiReturn.data) { - setNodeClass(apiReturn.data?.frontend_node); let inputVariables = apiReturn.data.input_variables ?? []; if (inputVariables && inputVariables.length === 0) { setIsEdit(true); @@ -140,6 +139,7 @@ export default function GenericModal({ setSuccessData({ title: "Prompt is ready", }); + setNodeClass(apiReturn.data?.frontend_node); setModalOpen(closeModal); setValue(inputValue); }