bugfix: add steps to delete flows caused by new constraints (#3045)
* 📝 (flows.py): refactor delete_multiple_flows function to improve readability and efficiency ✨ (use-delete-flows.ts): add useDeleteFlows hook to handle deletion of multiple flows in frontend ♻️ (index.tsx): refactor handleDeleteMultiple function to use useDeleteFlows hook for deleting multiple flows 🔧 (actionsMainPage-shard-1.spec.ts): add test for selecting and deleting a flow in end-to-end tests * 📝 (flows.py): Remove unused imports and variables to clean up the code and improve readability ♻️ (flows.py): Refactor code to remove unnecessary import and variable declarations, making the code more concise and maintainable * add unit tests to delete multiple flows with transactions and build * format * add assert on tests
This commit is contained in:
parent
fc73e2c448
commit
c2b5b98b64
5 changed files with 175 additions and 17 deletions
|
|
@ -1,12 +1,13 @@
|
|||
import json
|
||||
from uuid import UUID, uuid4
|
||||
|
||||
from langflow.graph.utils import log_transaction, log_vertex_build
|
||||
import orjson
|
||||
import pytest
|
||||
from fastapi.testclient import TestClient
|
||||
from sqlmodel import Session
|
||||
|
||||
from langflow.api.v1.schemas import FlowListCreate
|
||||
from langflow.api.v1.schemas import FlowListCreate, ResultDataResponse
|
||||
from langflow.initial_setup.setup import load_starter_projects, load_flows_from_directory
|
||||
from langflow.services.database.models.base import orjson_dumps
|
||||
from langflow.services.database.models.flow import Flow, FlowCreate, FlowUpdate
|
||||
|
|
@ -19,6 +20,7 @@ from langflow.services.monitor.utils import (
|
|||
new_duckdb_locked_connection,
|
||||
add_row_to_table,
|
||||
)
|
||||
from collections import namedtuple
|
||||
|
||||
|
||||
@pytest.fixture(scope="module")
|
||||
|
|
@ -133,6 +135,66 @@ def test_delete_flows(client: TestClient, json_flow: str, active_user, logged_in
|
|||
assert response.json().get("deleted") == number_of_flows
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_delete_flows_with_transaction_and_build(
|
||||
client: TestClient, json_flow: str, active_user, logged_in_headers
|
||||
):
|
||||
# Create ten flows
|
||||
number_of_flows = 10
|
||||
flows = [FlowCreate(name=f"Flow {i}", description="description", data={}) for i in range(number_of_flows)]
|
||||
flow_ids = []
|
||||
for flow in flows:
|
||||
response = client.post("api/v1/flows/", json=flow.model_dump(), headers=logged_in_headers)
|
||||
assert response.status_code == 201
|
||||
flow_ids.append(response.json()["id"])
|
||||
|
||||
# Create a transaction for each flow
|
||||
|
||||
for flow_id in flow_ids:
|
||||
VertexTuple = namedtuple("VertexTuple", ["id"])
|
||||
|
||||
await log_transaction(
|
||||
str(flow_id), source=VertexTuple(id="vid"), target=VertexTuple(id="tid"), status="success"
|
||||
)
|
||||
|
||||
# Create a build for each flow
|
||||
for flow_id in flow_ids:
|
||||
build = {
|
||||
"valid": True,
|
||||
"params": {},
|
||||
"data": ResultDataResponse(),
|
||||
"artifacts": {},
|
||||
"vertex_id": "vid",
|
||||
"flow_id": flow_id,
|
||||
}
|
||||
log_vertex_build(
|
||||
flow_id=build["flow_id"],
|
||||
vertex_id=build["vertex_id"],
|
||||
valid=build["valid"],
|
||||
params=build["params"],
|
||||
data=build["data"],
|
||||
artifacts=build.get("artifacts"),
|
||||
)
|
||||
|
||||
response = client.request("DELETE", "api/v1/flows/", headers=logged_in_headers, json=flow_ids)
|
||||
assert response.status_code == 200, response.content
|
||||
assert response.json().get("deleted") == number_of_flows
|
||||
|
||||
for flow_id in flow_ids:
|
||||
response = client.request(
|
||||
"GET", "api/v1/monitor/transactions", params={"flow_id": flow_id}, headers=logged_in_headers
|
||||
)
|
||||
assert response.status_code == 200
|
||||
assert response.json() == []
|
||||
|
||||
for flow_id in flow_ids:
|
||||
response = client.request(
|
||||
"GET", "api/v1/monitor/builds", params={"flow_id": flow_id}, headers=logged_in_headers
|
||||
)
|
||||
assert response.status_code == 200
|
||||
assert response.json() == {"vertex_builds": {}}
|
||||
|
||||
|
||||
def test_create_flows(client: TestClient, session: Session, json_flow: str, logged_in_headers):
|
||||
flow = orjson.loads(json_flow)
|
||||
data = flow["data"]
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue