From c9153b0d824b533bce6b38bb52f456bc8f741a10 Mon Sep 17 00:00:00 2001 From: Edwin Jose Date: Mon, 17 Feb 2025 15:36:39 -0500 Subject: [PATCH] fix: inconsistent text table result for Message Type output (#6633) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Update component.py * 🐛 (loop-component.spec.ts): fix clicking on incorrect element in test causing failure * 🔧 (freeze-path.spec.ts): Remove redundant clicks on "Close" button in multiple test cases to improve test efficiency 🔧 (freeze.spec.ts): Remove redundant clicks on "Close" button in multiple test cases to improve test efficiency --------- Co-authored-by: cristhianzl Co-authored-by: Gabriel Luiz Freitas Almeida --- .../langflow/custom/custom_component/component.py | 3 --- src/frontend/tests/core/features/freeze-path.spec.ts | 9 --------- src/frontend/tests/core/features/freeze.spec.ts | 12 ------------ .../tests/extended/features/loop-component.spec.ts | 1 - 4 files changed, 25 deletions(-) diff --git a/src/backend/base/langflow/custom/custom_component/component.py b/src/backend/base/langflow/custom/custom_component/component.py index 1c502eaea..44e7a3ef2 100644 --- a/src/backend/base/langflow/custom/custom_component/component.py +++ b/src/backend/base/langflow/custom/custom_component/component.py @@ -981,9 +981,6 @@ class Component(CustomComponent): return {"repr": custom_repr, "raw": raw, "type": artifact_type} def _process_raw_result(self, result): - """Process the raw result of the component.""" - if len(self.outputs) == 1: - return self.status or self.extract_data(result) return self.extract_data(result) def extract_data(self, result): diff --git a/src/frontend/tests/core/features/freeze-path.spec.ts b/src/frontend/tests/core/features/freeze-path.spec.ts index 43dbcac5b..3d33b15f9 100644 --- a/src/frontend/tests/core/features/freeze-path.spec.ts +++ b/src/frontend/tests/core/features/freeze-path.spec.ts @@ -62,15 +62,12 @@ test( .first() .click(); - await page.getByRole("gridcell").nth(4).click(); - const randomTextGeneratedByAI = await page .getByPlaceholder("Empty") .first() .inputValue(); await page.getByText("Close").last().click(); - await page.getByText("Close").last().click(); await page.waitForSelector('[data-testid="default_slider_display_value"]', { timeout: 1000, @@ -94,15 +91,12 @@ test( .first() .click(); - await page.getByRole("gridcell").nth(4).click(); - const secondRandomTextGeneratedByAI = await page .getByPlaceholder("Empty") .first() .inputValue(); await page.getByText("Close").last().click(); - await page.getByText("Close").last().click(); await page.waitForSelector("text=OpenAI", { timeout: 1000, @@ -145,15 +139,12 @@ test( .first() .click(); - await page.getByRole("gridcell").nth(4).click(); - const thirdRandomTextGeneratedByAI = await page .getByPlaceholder("Empty") .first() .inputValue(); await page.getByText("Close").last().click(); - await page.getByText("Close").last().click(); expect(randomTextGeneratedByAI).not.toEqual(secondRandomTextGeneratedByAI); expect(randomTextGeneratedByAI).not.toEqual(thirdRandomTextGeneratedByAI); diff --git a/src/frontend/tests/core/features/freeze.spec.ts b/src/frontend/tests/core/features/freeze.spec.ts index a0f05b45e..13d38ea64 100644 --- a/src/frontend/tests/core/features/freeze.spec.ts +++ b/src/frontend/tests/core/features/freeze.spec.ts @@ -189,16 +189,12 @@ test( .first() .click(); - await page.getByRole("gridcell").nth(4).click(); - const firstRunWithoutFreezing = await page .getByPlaceholder("Empty") .textContent(); await page.getByText("Close").last().click(); - await page.getByTestId("btn-close-modal").click(); - await page.getByTestId("textarea_str_input_value").first().fill(","); await page.getByTestId("button_run_chat output").click(); @@ -221,14 +217,11 @@ test( .first() .click(); - await page.getByRole("gridcell").nth(4).click(); - const secondRunWithoutFreezing = await page .getByPlaceholder("Empty") .textContent(); await page.getByText("Close").last().click(); - await page.getByText("Close").last().click(); await page.getByText("Split Text", { exact: true }).last().click(); @@ -277,11 +270,8 @@ test( .first() .click(); - await page.getByRole("gridcell").nth(4).click(); - const firstTextFreezed = await page.getByPlaceholder("Empty").textContent(); - await page.getByText("Close").last().click(); await page.getByText("Close").last().click(); await page.getByText("Split Text", { exact: true }).click(); @@ -322,8 +312,6 @@ test( .first() .click(); - await page.getByRole("gridcell").nth(4).click(); - const thirdTextWithoutFreezing = await page .getByPlaceholder("Empty") .textContent(); diff --git a/src/frontend/tests/extended/features/loop-component.spec.ts b/src/frontend/tests/extended/features/loop-component.spec.ts index dfa401105..d7342a44a 100644 --- a/src/frontend/tests/extended/features/loop-component.spec.ts +++ b/src/frontend/tests/extended/features/loop-component.spec.ts @@ -231,7 +231,6 @@ test( .getByTestId("output-inspection-message-chatoutput") .first() .click(); - await page.getByRole("gridcell").nth(4).click(); const output = await page.getByPlaceholder("Empty").textContent(); expect(output).toContain("modified_value");