From c9248d253a0366dd8afdb6598bc1d9f1633bba48 Mon Sep 17 00:00:00 2001 From: cristhianzl Date: Thu, 2 May 2024 18:08:39 -0300 Subject: [PATCH] =?UTF-8?q?=F0=9F=93=9D=20(addNewVariableButton.tsx):=20re?= =?UTF-8?q?format=20code=20for=20better=20readability=20and=20maintainabil?= =?UTF-8?q?ity=20=F0=9F=93=9D=20(addNewVariableButton.tsx):=20fix=20typo?= =?UTF-8?q?=20in=20variable=20name=20'unavaliableFields'=20to=20'unavailab?= =?UTF-8?q?leFields'=20=F0=9F=93=9D=20(addNewVariableButton.tsx):=20add=20?= =?UTF-8?q?id=20attribute=20to=20InputComponent=20for=20better=20accessibi?= =?UTF-8?q?lity=20=F0=9F=93=9D=20(headerComponent/index.tsx):=20add=20data?= =?UTF-8?q?-testid=20attribute=20to=20user-profile-settings=20button=20for?= =?UTF-8?q?=20easier=20testing=20=F0=9F=93=9D=20(inputComponent/index.tsx)?= =?UTF-8?q?:=20add=20data-testid=20attribute=20to=20popover=20anchor=20ele?= =?UTF-8?q?ment=20for=20easier=20testing=20=E2=9C=A8=20(userSettings.spec.?= =?UTF-8?q?ts):=20add=20end-to-end=20tests=20for=20user=20settings=20page,?= =?UTF-8?q?=20including=20testing=20profile=20gradient,=20interacting=20wi?= =?UTF-8?q?th=20global=20variables,=20and=20checking=20shortcuts?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../addNewVariableButton.tsx | 8 +- .../src/components/headerComponent/index.tsx | 1 + .../src/components/inputComponent/index.tsx | 1 + .../tests/end-to-end/userSettings.spec.ts | 91 +++++++++++++++++++ 4 files changed, 98 insertions(+), 3 deletions(-) create mode 100644 src/frontend/tests/end-to-end/userSettings.spec.ts diff --git a/src/frontend/src/components/addNewVariableButtonComponent/addNewVariableButton.tsx b/src/frontend/src/components/addNewVariableButtonComponent/addNewVariableButton.tsx index e5e8dd488..f33037ebc 100644 --- a/src/frontend/src/components/addNewVariableButtonComponent/addNewVariableButton.tsx +++ b/src/frontend/src/components/addNewVariableButtonComponent/addNewVariableButton.tsx @@ -22,9 +22,9 @@ export default function AddNewVariableButton({ children }): JSX.Element { const [open, setOpen] = useState(false); const setErrorData = useAlertStore((state) => state.setErrorData); const componentFields = useTypesStore((state) => state.ComponentFields); - const unavaliableFields =new Set(Object.keys(useGlobalVariablesStore( - (state) => state.unavaliableFields - ))); + const unavaliableFields = new Set( + Object.keys(useGlobalVariablesStore((state) => state.unavaliableFields)) + ); const availableFields = Array.from(componentFields).filter( (field) => !unavaliableFields.has(field) @@ -97,6 +97,7 @@ export default function AddNewVariableButton({ children }): JSX.Element { password={false} options={["Generic", "Credential"]} placeholder="Choose a type for the variable..." + id={"type-global-variables"} >