From cd2517f7e24cf9b19b768dccb680535bd5a42357 Mon Sep 17 00:00:00 2001
From: anovazzi1 <otavio2204@gmail.com>
Date: Mon, 18 Nov 2024 19:09:24 -0300
Subject: [PATCH] refactor: improve tests for group and keyBoardComponentSearch
 tests (#4621)

* refactor: Remove unnecessary wait in group.spec.ts

* refactor: Improve keyboard component search tests

Improve the keyboard component search tests by using waitForSelector instead of waitForTimeout for better reliability and stability.
---
 .../tests/core/features/group.spec.ts         |  1 -
 .../features/keyboardComponentSearch.spec.ts  | 23 +++++++++++--------
 2 files changed, 13 insertions(+), 11 deletions(-)

diff --git a/src/frontend/tests/core/features/group.spec.ts b/src/frontend/tests/core/features/group.spec.ts
index 04217fee4..67f32ec29 100644
--- a/src/frontend/tests/core/features/group.spec.ts
+++ b/src/frontend/tests/core/features/group.spec.ts
@@ -25,7 +25,6 @@ test.describe("group node test", () => {
       .getByRole("heading", { name: "Basic Prompting" })
       .first()
       .click();
-    await page.waitForTimeout(1000);
     await page.getByTestId("fit_view").first().click();
 
     await page.getByTestId("title-OpenAI").click();
diff --git a/src/frontend/tests/core/features/keyboardComponentSearch.spec.ts b/src/frontend/tests/core/features/keyboardComponentSearch.spec.ts
index 6b93bf235..0a0e2503e 100644
--- a/src/frontend/tests/core/features/keyboardComponentSearch.spec.ts
+++ b/src/frontend/tests/core/features/keyboardComponentSearch.spec.ts
@@ -21,25 +21,33 @@ test("user can search and add components using keyboard shortcuts", async ({
 
   while (modalCount === 0) {
     await page.getByText("New Flow", { exact: true }).click();
-    await page.waitForTimeout(3000);
+    await page.waitForSelector('[data-testid="modal-title"]', {
+      timeout: 3000,
+    });
     modalCount = await page.getByTestId("modal-title")?.count();
   }
 
   // Start with blank flow
   await page.getByTestId("blank-flow").click();
-  await page.waitForTimeout(1000);
+  await page.waitForSelector('[data-testid="sidebar-search-input"]', {
+    timeout: 1000,
+  });
 
   // Press "/" to activate search
   await page.keyboard.press("/");
-  await page.waitForTimeout(500);
 
   // Verify search is focused and disclosures are closed when search is empty
-  await expect(page.getByTestId("sidebar-search-input")).toBeFocused();
+  await expect(page.getByTestId("sidebar-search-input")).toBeFocused({
+    timeout: 1000,
+  });
   await expect(page.getByTestId("inputsChat Input")).not.toBeVisible();
 
   // Type "chat" to search for chat components
   await page.keyboard.type("chat");
-  await page.waitForTimeout(500);
+
+  await expect(page.getByTestId("inputsChat Input")).toBeVisible({
+    timeout: 1000,
+  });
 
   // Verify disclosures open when search has content
   await expect(page.getByTestId("inputsChat Input")).toBeVisible();
@@ -54,7 +62,6 @@ test("user can search and add components using keyboard shortcuts", async ({
 
   // Press Space to select the component
   await page.keyboard.press("Space");
-  await page.waitForTimeout(500);
 
   // Verify component was added to flow
   const addedComponent = await page.locator(".react-flow__node").first();
@@ -62,13 +69,11 @@ test("user can search and add components using keyboard shortcuts", async ({
 
   // Clear search input and verify disclosures are closed
   await page.getByTestId("sidebar-search-input").clear();
-  await page.waitForTimeout(500);
   await expect(page.getByTestId("inputsChat Input")).not.toBeVisible();
 
   // Test Enter key selection
   await page.keyboard.press("/");
   await page.keyboard.type("prompt");
-  await page.waitForTimeout(500);
 
   // Verify disclosures open with new search
   await expect(page.getByTestId("promptsPrompt")).toBeVisible();
@@ -76,7 +81,6 @@ test("user can search and add components using keyboard shortcuts", async ({
   await page.keyboard.press("Tab");
   await page.keyboard.press("Tab");
   await page.keyboard.press("Enter");
-  await page.waitForTimeout(500);
 
   // Verify second component was added
   const nodeCount = await page.locator(".react-flow__node").count();
@@ -85,7 +89,6 @@ test("user can search and add components using keyboard shortcuts", async ({
   // Verify search is cleared and disclosures are closed after adding component
   await page.keyboard.press("/");
   await page.getByTestId("sidebar-search-input").clear();
-  await page.waitForTimeout(500);
   await expect(page.getByTestId("sidebar-search-input")).toHaveValue("");
   await expect(page.getByTestId("inputsChat Input")).not.toBeVisible();