From ced8d6d8e55cbffae7ffd971e3fedf739a347e52 Mon Sep 17 00:00:00 2001 From: Lucas Oliveira <62335616+lucaseduoli@users.noreply.github.com> Date: Mon, 7 Apr 2025 16:15:55 -0300 Subject: [PATCH] fix: removed file uploaded successfully message when no file is picked, fixed nvidia ingest message (#7441) * Removed msg from nvidia_ingest * Added default file picker timeout * Use bigger timeout for file picker * Added condition to only say that file was uploaded successfully if there are files --- .../components/nvidia/nvidia_ingest.py | 2 +- src/frontend/src/constants/constants.ts | 1 + .../src/helpers/create-file-upload.ts | 4 +++- .../components/dragFilesComponent/index.tsx | 20 +++++++++++-------- 4 files changed, 17 insertions(+), 10 deletions(-) diff --git a/src/backend/base/langflow/components/nvidia/nvidia_ingest.py b/src/backend/base/langflow/components/nvidia/nvidia_ingest.py index 9aa7c805b..3be2ce383 100644 --- a/src/backend/base/langflow/components/nvidia/nvidia_ingest.py +++ b/src/backend/base/langflow/components/nvidia/nvidia_ingest.py @@ -24,7 +24,7 @@ class NvidiaIngestComponent(Component): "NVIDIA Ingest dependencies missing. " "Please install them using your package manager. (e.g. uv pip install langflow[nv-ingest])" ) - file_types = [msg] + file_types = [] supported_file_types_info = msg inputs = [ diff --git a/src/frontend/src/constants/constants.ts b/src/frontend/src/constants/constants.ts index a7625eab0..b101f7fc8 100644 --- a/src/frontend/src/constants/constants.ts +++ b/src/frontend/src/constants/constants.ts @@ -1066,3 +1066,4 @@ export const OPENAI_VOICES = [ export const DEFAULT_POLLING_INTERVAL = 5000; export const DEFAULT_TIMEOUT = 30000; +export const DEFAULT_FILE_PICKER_TIMEOUT = 60000; diff --git a/src/frontend/src/helpers/create-file-upload.ts b/src/frontend/src/helpers/create-file-upload.ts index 6f309499e..e7ed7a708 100644 --- a/src/frontend/src/helpers/create-file-upload.ts +++ b/src/frontend/src/helpers/create-file-upload.ts @@ -1,3 +1,5 @@ +import { DEFAULT_FILE_PICKER_TIMEOUT } from "@/constants/constants"; + export function createFileUpload(props?: { accept?: string; multiple?: boolean; @@ -64,6 +66,6 @@ export function createFileUpload(props?: { cleanup(); resolve([]); } - }, 30000); + }, DEFAULT_FILE_PICKER_TIMEOUT); }); } diff --git a/src/frontend/src/modals/fileManagerModal/components/dragFilesComponent/index.tsx b/src/frontend/src/modals/fileManagerModal/components/dragFilesComponent/index.tsx index 624da7f8a..6c9492de0 100644 --- a/src/frontend/src/modals/fileManagerModal/components/dragFilesComponent/index.tsx +++ b/src/frontend/src/modals/fileManagerModal/components/dragFilesComponent/index.tsx @@ -53,10 +53,12 @@ export default function DragFilesComponent({ const filesIds = await uploadFile({ files: droppedFiles, }); - onUpload(filesIds); - setSuccessData({ - title: `File${filesIds.length > 1 ? "s" : ""} uploaded successfully`, - }); + if (filesIds.length > 0) { + onUpload(filesIds); + setSuccessData({ + title: `File${filesIds.length > 1 ? "s" : ""} uploaded successfully`, + }); + } } catch (error: any) { setErrorData({ title: "Error uploading file", @@ -69,10 +71,12 @@ export default function DragFilesComponent({ const handleClick = async () => { try { const filesIds = await uploadFile({}); - onUpload(filesIds); - setSuccessData({ - title: `File${filesIds.length > 1 ? "s" : ""} uploaded successfully`, - }); + if (filesIds.length > 0) { + onUpload(filesIds); + setSuccessData({ + title: `File${filesIds.length > 1 ? "s" : ""} uploaded successfully`, + }); + } } catch (error: any) { setErrorData({ title: "Error uploading file",