From cf8df6c62be0630cb775201b14fba74645c35881 Mon Sep 17 00:00:00 2001 From: anovazzi1 Date: Tue, 29 Aug 2023 16:44:15 -0300 Subject: [PATCH] fix(users.py): update error message to be more generic and not reveal specific reason for username unavailability fix(AdminPage/index.tsx): fix nullish assertion for create_at and updated_at properties to avoid potential errors fix(signUpPage/index.tsx): fix error handling to correctly display error message fix(types/components/index.ts): make id, create_at, and updated_at properties optional in UserInputType --- src/backend/langflow/api/v1/users.py | 2 +- src/frontend/src/pages/AdminPage/index.tsx | 4 ++-- src/frontend/src/pages/signUpPage/index.tsx | 2 +- src/frontend/src/types/components/index.ts | 6 +++--- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/backend/langflow/api/v1/users.py b/src/backend/langflow/api/v1/users.py index 268b1f47b..7365e7cc1 100644 --- a/src/backend/langflow/api/v1/users.py +++ b/src/backend/langflow/api/v1/users.py @@ -43,7 +43,7 @@ def add_user( db.refresh(new_user) except IntegrityError as e: db.rollback() - raise HTTPException(status_code=400, detail="This username is unavailable as it has already been claimed. Please choose a different username.") from e + raise HTTPException(status_code=400, detail="This username is unavailable.") from e return new_user diff --git a/src/frontend/src/pages/AdminPage/index.tsx b/src/frontend/src/pages/AdminPage/index.tsx index ca2b0ec82..fc963fee8 100644 --- a/src/frontend/src/pages/AdminPage/index.tsx +++ b/src/frontend/src/pages/AdminPage/index.tsx @@ -348,14 +348,14 @@ export default function AdminPage() { { - new Date(user.create_at) + new Date(user.create_at!) .toISOString() .split("T")[0] } { - new Date(user.updated_at) + new Date(user.updated_at!) .toISOString() .split("T")[0] } diff --git a/src/frontend/src/pages/signUpPage/index.tsx b/src/frontend/src/pages/signUpPage/index.tsx index 02b725a14..92f3eff97 100644 --- a/src/frontend/src/pages/signUpPage/index.tsx +++ b/src/frontend/src/pages/signUpPage/index.tsx @@ -51,7 +51,7 @@ export default function SignUp(): JSX.Element { } = error; setErrorData({ title: "Error signing up", - list: [detail[0].msg], + list: [detail], }); return; }); diff --git a/src/frontend/src/types/components/index.ts b/src/frontend/src/types/components/index.ts index 3f8096618..f7b974a93 100644 --- a/src/frontend/src/types/components/index.ts +++ b/src/frontend/src/types/components/index.ts @@ -266,9 +266,9 @@ export type UserInputType = { password: string; is_active?: boolean; is_superuser?: boolean; - id: string; - create_at: string; - updated_at:string; + id?: string; + create_at?: string; + updated_at?:string; }; export type ApiKeyType = {