refactor: Improve variable creation logic in VariableService (#1875)

* refactor: Improve variable creation logic in VariableService
This commit is contained in:
Gabriel Luiz Freitas Almeida 2024-05-10 12:34:24 -03:00 • committed by GitHub
commit da256785d0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -29,17 +29,20 @@ class VariableService(Service):
for var in self.settings_service.settings.variables_to_get_from_environment: for var in self.settings_service.settings.variables_to_get_from_environment:
if var in os.environ: if var in os.environ:
logger.debug(f"Creating {var} variable from environment.") logger.debug(f"Creating {var} variable from environment.")
try: if not session.exec(
self.create_variable( select(Variable).where(Variable.user_id == user_id, Variable.name == var)
user_id=user_id, ).first():
name=var, try:
value=os.environ[var], self.create_variable(
default_fields=[], user_id=user_id,
_type="Credential", name=var,
session=session, value=os.environ[var],
) default_fields=[],
except Exception as e: _type="Credential",
logger.error(f"Error creating {var} variable: {e}") session=session,
)
except Exception as e:
logger.error(f"Error creating {var} variable: {e}")
else: else:
logger.info("Skipping environment variable storage.") logger.info("Skipping environment variable storage.")