From dc80513691178c0aa28f123877a417b0851d9f1f Mon Sep 17 00:00:00 2001 From: Gabriel Luiz Freitas Almeida Date: Sun, 9 Jul 2023 11:09:19 -0300 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20fix(types.py):=20change=20variab?= =?UTF-8?q?le=20name=20from=20'name'=20to=20'display=5Fname'=20in=20add=5F?= =?UTF-8?q?new=5Fcustom=5Ffield=20function=20to=20improve=20clarity=20?= =?UTF-8?q?=F0=9F=94=A7=20chore(types.py):=20add=20warning=20when=20'name'?= =?UTF-8?q?=20key=20is=20used=20in=20field=5Fconfig=20to=20inform=20that?= =?UTF-8?q?=20it=20can't=20be=20changed?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/backend/langflow/interface/types.py | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/backend/langflow/interface/types.py b/src/backend/langflow/interface/types.py index 9b8b8cebe..8b6d78f9a 100644 --- a/src/backend/langflow/interface/types.py +++ b/src/backend/langflow/interface/types.py @@ -21,7 +21,7 @@ from langflow.template.frontend_node.tools import CustomComponentNode from langflow.interface.retrievers.base import retriever_creator from langflow.utils.util import get_base_classes - +import warnings from fastapi import HTTPException import traceback @@ -82,20 +82,26 @@ def add_new_custom_field( ): # Check field_config if any of the keys are in it # if it is, update the value - name = field_config.pop("name", field_name) + display_name = field_config.pop("display_name", field_name) field_type = field_config.pop("field_type", field_type) field_type = process_type(field_type) + if "name" in field_config: + warnings.warn( + "The 'name' key in field_config is used to build the object and can't be changed." + ) + field_config.pop("name", None) required = field_config.pop("required", True) placeholder = field_config.pop("placeholder", "") new_field = TemplateField( - name=name, + name=field_name, field_type=field_type, show=True, required=required, advanced=False, placeholder=placeholder, + display_name=display_name, **field_config, ) template.get("template")[field_name] = new_field.to_dict()