From fb98cc6e51670fdff8366d80cfa64a81da4b15e5 Mon Sep 17 00:00:00 2001 From: cristhianzl Date: Fri, 23 Feb 2024 12:30:30 -0300 Subject: [PATCH 1/2] start fix tests --- src/frontend/package-lock.json | 2 +- src/frontend/package.json | 2 +- src/frontend/tests/end-to-end/codeAreaModalComponent.spec.ts | 5 ++++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/frontend/package-lock.json b/src/frontend/package-lock.json index 99e4eadd5..f18616611 100644 --- a/src/frontend/package-lock.json +++ b/src/frontend/package-lock.json @@ -76,7 +76,7 @@ "zustand": "^4.4.7" }, "devDependencies": { - "@playwright/test": "^1.38.0", + "@playwright/test": "^1.41.2", "@swc/cli": "^0.1.62", "@swc/core": "^1.3.80", "@tailwindcss/typography": "^0.5.9", diff --git a/src/frontend/package.json b/src/frontend/package.json index 1d74df9a3..8eaf5080b 100644 --- a/src/frontend/package.json +++ b/src/frontend/package.json @@ -98,7 +98,7 @@ }, "proxy": "http://127.0.0.1:7860", "devDependencies": { - "@playwright/test": "^1.38.0", + "@playwright/test": "^1.41.2", "@swc/cli": "^0.1.62", "@swc/core": "^1.3.80", "@tailwindcss/typography": "^0.5.9", diff --git a/src/frontend/tests/end-to-end/codeAreaModalComponent.spec.ts b/src/frontend/tests/end-to-end/codeAreaModalComponent.spec.ts index 8a604bd3d..66cebf6a1 100644 --- a/src/frontend/tests/end-to-end/codeAreaModalComponent.spec.ts +++ b/src/frontend/tests/end-to-end/codeAreaModalComponent.spec.ts @@ -18,7 +18,8 @@ test("CodeAreaModalComponent", async ({ page }) => { await page.mouse.up(); await page.mouse.down(); - await page.locator('//*[@id="code-input-0"]').click(); + await page.getByTestId("div-generic-node").click(); + await page.getByTestId("code-button-modal").click(); let value = await page.locator('//*[@id="codeValue"]').inputValue(); @@ -31,6 +32,8 @@ test("CodeAreaModalComponent", async ({ page }) => { await page.locator('//*[@id="checkAndSaveBtn"]').click(); + await page.getByTestId("div-generic-node").click(); + await page.getByTestId("more-options-modal").click(); await page.getByTestId("edit-button-modal").click(); From 795436d1a3dea986b69be7597f9589929463b7ff Mon Sep 17 00:00:00 2001 From: cristhianzl Date: Fri, 23 Feb 2024 17:30:51 -0300 Subject: [PATCH 2/2] =?UTF-8?q?=F0=9F=94=A5=20refactor(genericModal/index.?= =?UTF-8?q?tsx):=20remove=20unused=20imports=20and=20code=20to=20improve?= =?UTF-8?q?=20code=20cleanliness=20and=20performance?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/frontend/src/modals/genericModal/index.tsx | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/frontend/src/modals/genericModal/index.tsx b/src/frontend/src/modals/genericModal/index.tsx index 6a68f6aef..44173057f 100644 --- a/src/frontend/src/modals/genericModal/index.tsx +++ b/src/frontend/src/modals/genericModal/index.tsx @@ -15,7 +15,6 @@ import { import { TypeModal } from "../../constants/enums"; import { postValidatePrompt } from "../../controllers/API"; import useAlertStore from "../../stores/alertStore"; -import useFlowStore from "../../stores/flowStore"; import { genericModalPropsType } from "../../types/components"; import { handleKeyDown } from "../../utils/reactflowUtils"; import { classNames, varHighlightHTML } from "../../utils/utils"; @@ -47,7 +46,6 @@ export default function GenericModal({ const textRef = useRef(null); const divRef = useRef(null); const divRefPrompt = useRef(null); - const unselectAll = useFlowStore((state) => state.unselectAll); function checkVariables(valueToCheck: string): void { const regex = /\{([^{}]+)\}/g; @@ -91,7 +89,6 @@ export default function GenericModal({ useEffect(() => { setInputValue(value); - unselectAll(); }, [value, modalOpen]); const coloredContent = (inputValue || "")