From dd95a0c69934fd976c93c7b608b6f07d545b89c2 Mon Sep 17 00:00:00 2001 From: cristhianzl Date: Thu, 11 Jan 2024 17:47:34 -0300 Subject: [PATCH 1/9] chore(playwright-report): fix indentation and formatting in index.html file style(App.css): add overflow: hidden to body and fix indentation and formatting --- src/frontend/playwright-report/index.html | 26 +++++++++++------------ 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/src/frontend/playwright-report/index.html b/src/frontend/playwright-report/index.html index d65e584e4..e634446de 100644 --- a/src/frontend/playwright-report/index.html +++ b/src/frontend/playwright-report/index.html @@ -1,18 +1,18 @@ - - - + + + Document - - + + - - \ No newline at end of file + + From 59de3fe50b39bfc6ed4c5b9457339514090578b5 Mon Sep 17 00:00:00 2001 From: anovazzi1 Date: Mon, 15 Jan 2024 16:11:56 -0300 Subject: [PATCH 2/9] fix(App.tsx): increase the timer interval for fetching data to 20 seconds for better performance feat(App.tsx): add cleanup function to clean up flow state when component unmounts feat(PageComponent/index.tsx): add cleanFlow function to reset flow state when component unmounts fix(PageComponent/index.tsx): fix bug where newEdges were not being set correctly in onConnect function fix(PageComponent/index.tsx): remove unnecessary dependencies from onConnect function fix(PageComponent/index.tsx): fix bug where setEdges was not returning the newEdges array correctly feat(flowStore.ts): add cleanFlow function to reset flow state to initial values feat(flowStore.ts): add cleanFlow function to reset flow state to initial values in flowStore type --- src/frontend/src/App.tsx | 2 +- .../components/PageComponent/index.tsx | 53 +++++++++++-------- src/frontend/src/stores/flowStore.ts | 9 ++++ src/frontend/src/types/zustand/flow/index.ts | 1 + 4 files changed, 43 insertions(+), 22 deletions(-) diff --git a/src/frontend/src/App.tsx b/src/frontend/src/App.tsx index 3b88ee14c..2bbab91f7 100644 --- a/src/frontend/src/App.tsx +++ b/src/frontend/src/App.tsx @@ -149,7 +149,7 @@ export default function App() { .catch(() => { setFetchError(true); }); - }, 5000); + }, 20000); // Clean up the timer on component unmount return () => { diff --git a/src/frontend/src/pages/FlowPage/components/PageComponent/index.tsx b/src/frontend/src/pages/FlowPage/components/PageComponent/index.tsx index ae030e0b7..5852d6999 100644 --- a/src/frontend/src/pages/FlowPage/components/PageComponent/index.tsx +++ b/src/frontend/src/pages/FlowPage/components/PageComponent/index.tsx @@ -64,6 +64,7 @@ export default function Page({ const onEdgesChange = useFlowStore((state) => state.onEdgesChange); const setNodes = useFlowStore((state) => state.setNodes); const setEdges = useFlowStore((state) => state.setEdges); + const cleanFlow = useFlowStore((state) => state.cleanFlow); const deleteNode = useFlowStore((state) => state.deleteNode); const deleteEdge = useFlowStore((state) => state.deleteEdge); const undo = useFlowsManagerStore((state) => state.undo); @@ -170,6 +171,12 @@ export default function Page({ } }, [currentFlowId, reactFlowInstance]); + useEffect(() => { + return () => { + cleanFlow(); + } + }, []) + const onConnectMod = useCallback( (params: Connection) => { takeSnapshot(); @@ -210,26 +217,30 @@ export default function Page({ const onConnect = useCallback( (connection: Connection) => { - const newEdges = addEdge( - { - ...connection, - data: { - targetHandle: scapeJSONParse(connection.targetHandle!), - sourceHandle: scapeJSONParse(connection.sourceHandle!), + let newEdges:Edge[] = [] + setEdges((oldEdges) => { + newEdges = addEdge( + { + ...connection, + data: { + targetHandle: scapeJSONParse(connection.targetHandle!), + sourceHandle: scapeJSONParse(connection.sourceHandle!), + }, + style: { stroke: "#555" }, + className: + ((scapeJSONParse(connection.targetHandle!) as targetHandleType) + .type === "Text" + ? "stroke-foreground " + : "stroke-foreground ") + " stroke-connection", + animated: + (scapeJSONParse(connection.targetHandle!) as targetHandleType) + .type === "Text", }, - style: { stroke: "#555" }, - className: - ((scapeJSONParse(connection.targetHandle!) as targetHandleType) - .type === "Text" - ? "stroke-foreground " - : "stroke-foreground ") + " stroke-connection", - animated: - (scapeJSONParse(connection.targetHandle!) as targetHandleType) - .type === "Text", - }, - edges - ); - setEdges(newEdges); + oldEdges + ); + return newEdges; + + }) useFlowsManagerStore .getState() .autoSaveCurrentFlow( @@ -238,7 +249,7 @@ export default function Page({ reactFlowInstance?.getViewport() ?? { x: 0, y: 0, zoom: 1 } ); }, - [nodes, edges, setEdges, reactFlowInstance, addEdge] + [nodes, setEdges, reactFlowInstance, addEdge] ); const onDrop = useCallback( @@ -357,7 +368,7 @@ export default function Page({
{Object.keys(templates).length > 0 && - Object.keys(types).length > 0 ? ( + Object.keys(types).length > 0 ? (
((set, get) => ({ setLastCopiedSelection: (newSelection) => { set({ lastCopiedSelection: newSelection }); }, + cleanFlow: () => { + set({ + nodes: [], + edges: [], + flowState: undefined, + sseData: {}, + isBuilt: false, + }); + }, })); export default useFlowStore; diff --git a/src/frontend/src/types/zustand/flow/index.ts b/src/frontend/src/types/zustand/flow/index.ts index 9c331892f..50d2fd45b 100644 --- a/src/frontend/src/types/zustand/flow/index.ts +++ b/src/frontend/src/types/zustand/flow/index.ts @@ -49,4 +49,5 @@ export type FlowStoreType = { ) => void; isBuilt: boolean; setIsBuilt: (isBuilt: boolean) => void; + cleanFlow: () => void; }; From cbea369c2cf9d94159704d00e20e13a8cdd96576 Mon Sep 17 00:00:00 2001 From: anovazzi1 Date: Mon, 15 Jan 2024 16:20:15 -0300 Subject: [PATCH 3/9] Update setFilterEdge references in code --- .../GenericNode/components/parameterComponent/index.tsx | 2 +- .../src/pages/FlowPage/components/PageComponent/index.tsx | 2 +- .../FlowPage/components/extraSidebarComponent/index.tsx | 4 ++-- src/frontend/src/stores/flowStore.ts | 5 +++++ src/frontend/src/stores/typesStore.ts | 5 +---- src/frontend/src/types/zustand/flow/index.ts | 2 ++ src/frontend/src/types/zustand/types/index.ts | 2 -- 7 files changed, 12 insertions(+), 10 deletions(-) diff --git a/src/frontend/src/CustomNodes/GenericNode/components/parameterComponent/index.tsx b/src/frontend/src/CustomNodes/GenericNode/components/parameterComponent/index.tsx index a76a15d17..9c1b4bbf1 100644 --- a/src/frontend/src/CustomNodes/GenericNode/components/parameterComponent/index.tsx +++ b/src/frontend/src/CustomNodes/GenericNode/components/parameterComponent/index.tsx @@ -71,7 +71,7 @@ export default function ParameterComponent({ const groupedEdge = useRef(null); - const setFilterEdge = useTypesStore((state) => state.setFilterEdge); + const setFilterEdge = useFlowStore((state) => state.setFilterEdge); let disabled = edges.some( diff --git a/src/frontend/src/pages/FlowPage/components/PageComponent/index.tsx b/src/frontend/src/pages/FlowPage/components/PageComponent/index.tsx index 5852d6999..2e2c2bac7 100644 --- a/src/frontend/src/pages/FlowPage/components/PageComponent/index.tsx +++ b/src/frontend/src/pages/FlowPage/components/PageComponent/index.tsx @@ -50,7 +50,7 @@ export default function Page({ ); const types = useTypesStore((state) => state.types); const templates = useTypesStore((state) => state.templates); - const setFilterEdge = useTypesStore((state) => state.setFilterEdge); + const setFilterEdge = useFlowStore((state) => state.setFilterEdge); const reactFlowWrapper = useRef(null); const reactFlowInstance = useFlowStore((state) => state.reactFlowInstance); diff --git a/src/frontend/src/pages/FlowPage/components/extraSidebarComponent/index.tsx b/src/frontend/src/pages/FlowPage/components/extraSidebarComponent/index.tsx index b610663ac..f9e904581 100644 --- a/src/frontend/src/pages/FlowPage/components/extraSidebarComponent/index.tsx +++ b/src/frontend/src/pages/FlowPage/components/extraSidebarComponent/index.tsx @@ -29,8 +29,8 @@ import SidebarDraggableComponent from "./sideBarDraggableComponent"; export default function ExtraSidebar(): JSX.Element { const data = useTypesStore((state) => state.data); const templates = useTypesStore((state) => state.templates); - const getFilterEdge = useTypesStore((state) => state.getFilterEdge); - const setFilterEdge = useTypesStore((state) => state.setFilterEdge); + const getFilterEdge = useFlowStore((state) => state.getFilterEdge); + const setFilterEdge = useFlowStore((state) => state.setFilterEdge); const uploadFlow = useFlowsManagerStore((state) => state.uploadFlow); const currentFlow = useFlowsManagerStore((state) => state.currentFlow); const hasStore = useStoreStore((state) => state.hasStore); diff --git a/src/frontend/src/stores/flowStore.ts b/src/frontend/src/stores/flowStore.ts index 76929cba1..cf041ee0f 100644 --- a/src/frontend/src/stores/flowStore.ts +++ b/src/frontend/src/stores/flowStore.ts @@ -257,8 +257,13 @@ const useFlowStore = create((set, get) => ({ flowState: undefined, sseData: {}, isBuilt: false, + getFilterEdge: [], }); }, + setFilterEdge: (newState) => { + set({ getFilterEdge: newState }); + }, + getFilterEdge: [] })); export default useFlowStore; diff --git a/src/frontend/src/stores/typesStore.ts b/src/frontend/src/stores/typesStore.ts index e2ab3dfc4..90f2c5b9b 100644 --- a/src/frontend/src/stores/typesStore.ts +++ b/src/frontend/src/stores/typesStore.ts @@ -9,7 +9,6 @@ export const useTypesStore = create((set, get) => ({ types: {}, templates: {}, data: {}, - getFilterEdge: [], getTypes: () => { return new Promise(async (resolve, reject) => { getAll() @@ -44,7 +43,5 @@ export const useTypesStore = create((set, get) => ({ let newChange = typeof change === "function" ? change(get().data) : change; set({ data: newChange }); }, - setFilterEdge: (newState) => { - set({ getFilterEdge: newState }); - }, + })); diff --git a/src/frontend/src/types/zustand/flow/index.ts b/src/frontend/src/types/zustand/flow/index.ts index 50d2fd45b..9b76a5347 100644 --- a/src/frontend/src/types/zustand/flow/index.ts +++ b/src/frontend/src/types/zustand/flow/index.ts @@ -50,4 +50,6 @@ export type FlowStoreType = { isBuilt: boolean; setIsBuilt: (isBuilt: boolean) => void; cleanFlow: () => void; + setFilterEdge: (newState) => void; + getFilterEdge: any[]; }; diff --git a/src/frontend/src/types/zustand/types/index.ts b/src/frontend/src/types/zustand/types/index.ts index f18d8b22e..133afbda1 100644 --- a/src/frontend/src/types/zustand/types/index.ts +++ b/src/frontend/src/types/zustand/types/index.ts @@ -8,6 +8,4 @@ export type TypesStoreType = { data: APIDataType; setData: (newState: {}) => void; getTypes: () => Promise; - setFilterEdge: (newState) => void; - getFilterEdge: any[]; }; From 41aec50819fa77f08b6473b43f63b2160bc15422 Mon Sep 17 00:00:00 2001 From: igorrCarvalho Date: Mon, 15 Jan 2024 17:46:24 -0300 Subject: [PATCH 4/9] Refactor: Change onConnection function to zustand store --- .../components/PageComponent/index.tsx | 38 +------------------ src/frontend/src/stores/flowStore.ts | 35 ++++++++++++++++- src/frontend/src/types/zustand/flow/index.ts | 2 + 3 files changed, 37 insertions(+), 38 deletions(-) diff --git a/src/frontend/src/pages/FlowPage/components/PageComponent/index.tsx b/src/frontend/src/pages/FlowPage/components/PageComponent/index.tsx index 2e2c2bac7..57716b5b5 100644 --- a/src/frontend/src/pages/FlowPage/components/PageComponent/index.tsx +++ b/src/frontend/src/pages/FlowPage/components/PageComponent/index.tsx @@ -78,6 +78,7 @@ export default function Page({ const setLastCopiedSelection = useFlowStore( (state) => state.setLastCopiedSelection ); + const onConnect = useFlowStore((state) => state.onConnect); const position = useRef({ x: 0, y: 0 }); const [lastSelection, setLastSelection] = @@ -215,43 +216,6 @@ export default function Page({ } }, []); - const onConnect = useCallback( - (connection: Connection) => { - let newEdges:Edge[] = [] - setEdges((oldEdges) => { - newEdges = addEdge( - { - ...connection, - data: { - targetHandle: scapeJSONParse(connection.targetHandle!), - sourceHandle: scapeJSONParse(connection.sourceHandle!), - }, - style: { stroke: "#555" }, - className: - ((scapeJSONParse(connection.targetHandle!) as targetHandleType) - .type === "Text" - ? "stroke-foreground " - : "stroke-foreground ") + " stroke-connection", - animated: - (scapeJSONParse(connection.targetHandle!) as targetHandleType) - .type === "Text", - }, - oldEdges - ); - return newEdges; - - }) - useFlowsManagerStore - .getState() - .autoSaveCurrentFlow( - nodes, - newEdges, - reactFlowInstance?.getViewport() ?? { x: 0, y: 0, zoom: 1 } - ); - }, - [nodes, setEdges, reactFlowInstance, addEdge] - ); - const onDrop = useCallback( (event: React.DragEvent) => { event.preventDefault(); diff --git a/src/frontend/src/stores/flowStore.ts b/src/frontend/src/stores/flowStore.ts index cf041ee0f..d8338428b 100644 --- a/src/frontend/src/stores/flowStore.ts +++ b/src/frontend/src/stores/flowStore.ts @@ -263,7 +263,40 @@ const useFlowStore = create((set, get) => ({ setFilterEdge: (newState) => { set({ getFilterEdge: newState }); }, - getFilterEdge: [] + getFilterEdge: [], + onConnect: (connection) => { + let newEdges: Edge[] = [] + get().setEdges((oldEdges) => { + newEdges = addEdge( + { + ...connection, + data: { + targetHandle: scapeJSONParse(connection.targetHandle!), + sourceHandle: scapeJSONParse(connection.sourceHandle!), + }, + style: { stroke: "#555" }, + className: + ((scapeJSONParse(connection.targetHandle!) as targetHandleType) + .type === "Text" + ? "stroke-foreground " + : "stroke-foreground ") + " stroke-connection", + animated: + (scapeJSONParse(connection.targetHandle!) as targetHandleType) + .type === "Text", + }, + oldEdges + ); + return newEdges; + + }) + useFlowsManagerStore + .getState() + .autoSaveCurrentFlow( + get().nodes, + newEdges, + get().reactFlowInstance?.getViewport() ?? { x: 0, y: 0, zoom: 1 } + ); + }, })); export default useFlowStore; diff --git a/src/frontend/src/types/zustand/flow/index.ts b/src/frontend/src/types/zustand/flow/index.ts index 9b76a5347..273a1958f 100644 --- a/src/frontend/src/types/zustand/flow/index.ts +++ b/src/frontend/src/types/zustand/flow/index.ts @@ -1,4 +1,5 @@ import { + Connection, Edge, Node, OnEdgesChange, @@ -52,4 +53,5 @@ export type FlowStoreType = { cleanFlow: () => void; setFilterEdge: (newState) => void; getFilterEdge: any[]; + onConnect: (connection: Connection) => void; }; From c3a0dfbd970eb1a10b2ce83d3fa8c7b335209b01 Mon Sep 17 00:00:00 2001 From: Lucas Oliveira Date: Mon, 15 Jan 2024 22:12:55 +0100 Subject: [PATCH 5/9] Fixed handles not showing when changing the output of the custom code --- .../components/parameterComponent/index.tsx | 23 ++++++++++++++----- .../components/PageComponent/index.tsx | 2 +- 2 files changed, 18 insertions(+), 7 deletions(-) diff --git a/src/frontend/src/CustomNodes/GenericNode/components/parameterComponent/index.tsx b/src/frontend/src/CustomNodes/GenericNode/components/parameterComponent/index.tsx index 9c1b4bbf1..09af96c6f 100644 --- a/src/frontend/src/CustomNodes/GenericNode/components/parameterComponent/index.tsx +++ b/src/frontend/src/CustomNodes/GenericNode/components/parameterComponent/index.tsx @@ -1,6 +1,6 @@ import { cloneDeep } from "lodash"; import React, { ReactNode, useEffect, useRef, useState } from "react"; -import { Handle, Position } from "reactflow"; +import { Handle, Position, useUpdateNodeInternals } from "reactflow"; import ShadTooltip from "../../../../components/ShadTooltipComponent"; import CodeAreaComponent from "../../../../components/codeAreaComponent"; import DictComponent from "../../../../components/dictComponent"; @@ -124,27 +124,32 @@ export default function ParameterComponent({ renderTooltips(); }; + const updateNodeInternals = useUpdateNodeInternals(); + const handleNodeClass = (newNodeClass: APIClassType, code?: string): void => { if (!data.node) return; if (data.node!.template[name].value !== code) { takeSnapshot(); } - + + setNode(data.id, (oldNode) => { let newNode = cloneDeep(oldNode); - + newNode.data = { ...newNode.data, node: newNodeClass, description: newNodeClass.description ?? data.node!.description, display_name: newNodeClass.display_name ?? data.node!.display_name, }; - + newNode.data.node.template[name].value = code; - + return newNode; }); - + + updateNodeInternals(data.id); + renderTooltips(); }; @@ -268,6 +273,9 @@ export default function ParameterComponent({ { From 8d86d6208ca29b04b90b640b2efcff42e6dfe1a5 Mon Sep 17 00:00:00 2001 From: igorrCarvalho Date: Tue, 16 Jan 2024 16:16:06 -0300 Subject: [PATCH 6/9] Fix: Input list doesnt show up when template value are empty --- src/frontend/src/components/inputListComponent/index.tsx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/frontend/src/components/inputListComponent/index.tsx b/src/frontend/src/components/inputListComponent/index.tsx index e98bba304..b82d37f63 100644 --- a/src/frontend/src/components/inputListComponent/index.tsx +++ b/src/frontend/src/components/inputListComponent/index.tsx @@ -23,6 +23,8 @@ export default function InputListComponent({ value = [value]; } + if (!value.length) value = [""]; + return (
Date: Tue, 16 Jan 2024 18:55:59 -0300 Subject: [PATCH 7/9] Fix: Transform empty object to array without opening 'editNode' modal to prevent flow build breakage. --- src/frontend/src/utils/reactflowUtils.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/frontend/src/utils/reactflowUtils.ts b/src/frontend/src/utils/reactflowUtils.ts index 7c8a0b7c0..8d222349a 100644 --- a/src/frontend/src/utils/reactflowUtils.ts +++ b/src/frontend/src/utils/reactflowUtils.ts @@ -474,6 +474,8 @@ export function convertArrayToObj(arrayOfObjects) { export function hasDuplicateKeys(array) { const keys = {}; + // Transforms an empty object into an object array without opening the 'editNode' modal to prevent the flow build from breaking. + if (!Array.isArray(array)) array = [{"": ""}]; for (const obj of array) { for (const key in obj) { if (keys[key]) { @@ -486,6 +488,8 @@ export function hasDuplicateKeys(array) { } export function hasEmptyKey(objArray) { + // Transforms an empty object into an array without opening the 'editNode' modal to prevent the flow build from breaking. + if (!Array.isArray(objArray)) objArray = []; for (const obj of objArray) { for (const key in obj) { if (obj.hasOwnProperty(key) && key === "") { From 65d8b59885a614174dfd3a77af19be497e3646aa Mon Sep 17 00:00:00 2001 From: igorrCarvalho Date: Tue, 16 Jan 2024 20:09:18 -0300 Subject: [PATCH 8/9] Fix: Add select trigger to Saved components to make toolbar open again --- .../extraSidebarComponent/sideBarDraggableComponent/index.tsx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/frontend/src/pages/FlowPage/components/extraSidebarComponent/sideBarDraggableComponent/index.tsx b/src/frontend/src/pages/FlowPage/components/extraSidebarComponent/sideBarDraggableComponent/index.tsx index d7d3ee925..c2d550e60 100644 --- a/src/frontend/src/pages/FlowPage/components/extraSidebarComponent/sideBarDraggableComponent/index.tsx +++ b/src/frontend/src/pages/FlowPage/components/extraSidebarComponent/sideBarDraggableComponent/index.tsx @@ -4,6 +4,7 @@ import { Select, SelectContent, SelectItem, + SelectTrigger } from "../../../../../components/ui/select-custom"; import { useDarkStore } from "../../../../../stores/darkStore"; import useFlowsManagerStore from "../../../../../stores/flowsManagerStore"; @@ -117,6 +118,7 @@ export const SidebarDraggableComponent = forwardRef( name="Menu" className="side-bar-components-icon " /> + Date: Wed, 17 Jan 2024 13:42:36 -0300 Subject: [PATCH 9/9] Fix: Add value prop initial value to prevent it from breaking when open edit node modal --- src/frontend/src/components/dictComponent/index.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/frontend/src/components/dictComponent/index.tsx b/src/frontend/src/components/dictComponent/index.tsx index 066819ba1..2cf622e93 100644 --- a/src/frontend/src/components/dictComponent/index.tsx +++ b/src/frontend/src/components/dictComponent/index.tsx @@ -6,7 +6,7 @@ import { classNames } from "../../utils/utils"; import { Input } from "../ui/input"; export default function DictComponent({ - value, + value = [], onChange, disabled, editNode = false,