feat: deprecate freeze and rename freeze path button (#6821)
* Removed Freeze shortcut and Renamed Freeze path to Freeze * Removed freeze shortcut * Removed freeze type on shortcut * Removed freeze shortcut logic * Remove freeze option from node toolbar * Fixed freeze test
This commit is contained in:
parent
d28f5ba391
commit
e99d5948e1
6 changed files with 3 additions and 50 deletions
|
|
@ -870,11 +870,6 @@ export const defaultShortcuts = [
|
|||
},
|
||||
{
|
||||
display_name: "Freeze",
|
||||
name: "Freeze",
|
||||
shortcut: "mod+f",
|
||||
},
|
||||
{
|
||||
display_name: "Freeze Path",
|
||||
name: "Freeze Path",
|
||||
shortcut: "mod+shift+f",
|
||||
},
|
||||
|
|
|
|||
|
|
@ -8,7 +8,6 @@ export default function useShortcuts({
|
|||
openModal,
|
||||
showconfirmShare,
|
||||
FreezeAllVertices,
|
||||
Freeze,
|
||||
downloadFunction,
|
||||
displayDocs,
|
||||
saveComponent,
|
||||
|
|
@ -25,7 +24,6 @@ export default function useShortcuts({
|
|||
openModal?: boolean;
|
||||
showconfirmShare?: boolean;
|
||||
FreezeAllVertices?: () => void;
|
||||
Freeze?: () => void;
|
||||
downloadFunction?: () => void;
|
||||
displayDocs?: () => void;
|
||||
saveComponent?: () => void;
|
||||
|
|
@ -45,7 +43,6 @@ export default function useShortcuts({
|
|||
const code = useShortcutsStore((state) => state.code);
|
||||
const group = useShortcutsStore((state) => state.group);
|
||||
const download = useShortcutsStore((state) => state.download);
|
||||
const freeze = useShortcutsStore((state) => state.freeze);
|
||||
const freezeAll = useShortcutsStore((state) => state.freezePath);
|
||||
const toolMode = useShortcutsStore((state) => state.toolMode);
|
||||
|
||||
|
|
@ -55,12 +52,6 @@ export default function useShortcuts({
|
|||
FreezeAllVertices();
|
||||
}
|
||||
|
||||
function handleFreeze(e: KeyboardEvent) {
|
||||
if (isWrappedWithClass(e, "noflow") || !Freeze) return;
|
||||
e.preventDefault();
|
||||
Freeze();
|
||||
}
|
||||
|
||||
function handleDownloadWShortcut(e: KeyboardEvent) {
|
||||
if (!downloadFunction) return;
|
||||
e.preventDefault();
|
||||
|
|
@ -136,7 +127,6 @@ export default function useShortcuts({
|
|||
useHotkeys(save, handleSaveWShortcut, { preventDefault: true });
|
||||
useHotkeys(docs, handleDocsWShortcut, { preventDefault: true });
|
||||
useHotkeys(download, handleDownloadWShortcut, { preventDefault: true });
|
||||
useHotkeys(freeze, handleFreeze);
|
||||
useHotkeys(freezeAll, handleFreezeAll);
|
||||
useHotkeys(toolMode, (e) => handleToolModeWShortcut(e, hasToolMode), {
|
||||
preventDefault: true,
|
||||
|
|
|
|||
|
|
@ -263,19 +263,6 @@ const NodeToolbarComponent = memo(
|
|||
});
|
||||
}, [data.id, data.node?.documentation, openInNewTab]);
|
||||
|
||||
const freezeFunction = useCallback(() => {
|
||||
setNode(data.id, (old) => ({
|
||||
...old,
|
||||
data: {
|
||||
...old.data,
|
||||
node: {
|
||||
...old.data.node,
|
||||
frozen: old.data?.node?.frozen ? false : true,
|
||||
},
|
||||
},
|
||||
}));
|
||||
}, [data.id, setNode]);
|
||||
|
||||
useShortcuts({
|
||||
showOverrideModal,
|
||||
showModalAdvanced,
|
||||
|
|
@ -284,7 +271,6 @@ const NodeToolbarComponent = memo(
|
|||
FreezeAllVertices: () => {
|
||||
FreezeAllVertices({ flowId: currentFlowId, stopNodeId: data.id });
|
||||
},
|
||||
Freeze: freezeFunction,
|
||||
downloadFunction: () => downloadNode(flowComponent!),
|
||||
displayDocs: openDocs,
|
||||
saveComponent,
|
||||
|
|
@ -333,9 +319,6 @@ const NodeToolbarComponent = memo(
|
|||
case "save":
|
||||
saveComponent();
|
||||
break;
|
||||
case "freeze":
|
||||
freezeFunction();
|
||||
break;
|
||||
case "freezeAll":
|
||||
FreezeAllVertices({ flowId: currentFlowId, stopNodeId: data.id });
|
||||
break;
|
||||
|
|
@ -405,7 +388,6 @@ const NodeToolbarComponent = memo(
|
|||
},
|
||||
[
|
||||
saveComponent,
|
||||
freezeFunction,
|
||||
FreezeAllVertices,
|
||||
setOpenModal,
|
||||
setShowModalAdvanced,
|
||||
|
|
@ -713,24 +695,12 @@ const NodeToolbarComponent = memo(
|
|||
/>
|
||||
</SelectItem>
|
||||
)}
|
||||
<SelectItem value="freeze">
|
||||
<SelectItem value="freezeAll">
|
||||
<ToolbarSelectItem
|
||||
shortcut={
|
||||
shortcuts.find((obj) => obj.name === "Freeze")?.shortcut!
|
||||
}
|
||||
value={"Freeze"}
|
||||
icon={"Snowflake"}
|
||||
dataTestId="freeze-button"
|
||||
style={`${frozen ? " text-ice" : ""} transition-all`}
|
||||
/>
|
||||
</SelectItem>
|
||||
<SelectItem value="freezeAll">
|
||||
<ToolbarSelectItem
|
||||
shortcut={
|
||||
shortcuts.find((obj) => obj.name === "Freeze Path")
|
||||
?.shortcut!
|
||||
}
|
||||
value={"Freeze Path"}
|
||||
icon={"FreezeAll"}
|
||||
dataTestId="freeze-path-button"
|
||||
style={`${frozen ? " text-ice" : ""} transition-all`}
|
||||
|
|
|
|||
|
|
@ -31,7 +31,6 @@ export const useShortcutsStore = create<shortcutsStoreType>((set, get) => ({
|
|||
api: "r",
|
||||
update: "mod+u",
|
||||
download: "mod+j",
|
||||
freeze: "mod+f",
|
||||
freezePath: "mod+shift+f",
|
||||
toolMode: "mod+shift+m",
|
||||
toggleSidebar: "mod+b",
|
||||
|
|
|
|||
|
|
@ -45,7 +45,6 @@ export type shortcutsStoreType = {
|
|||
delete: string;
|
||||
update: string;
|
||||
download: string;
|
||||
freeze: string;
|
||||
toggleSidebar: string;
|
||||
freezePath: string;
|
||||
toolMode: string;
|
||||
|
|
|
|||
|
|
@ -231,11 +231,11 @@ test(
|
|||
|
||||
await page.getByTestId("more-options-modal").click();
|
||||
|
||||
await page.waitForSelector('[data-testid="icon-Snowflake"]', {
|
||||
await page.waitForSelector('[data-testid="icon-FreezeAll"]', {
|
||||
timeout: 1000,
|
||||
});
|
||||
|
||||
await page.getByTestId("icon-Snowflake").click();
|
||||
await page.getByTestId("icon-FreezeAll").last().click();
|
||||
|
||||
await page.keyboard.press("Escape");
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue