jyapayne/langflow
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

fix: handle PydanticSerializationError that generates generic errors in the UI (#3108)

Browse source 
* fix(main.py): handle PydanticSerializationError in JavaScriptMIMETypeMiddleware to provide detailed error message in case of serialization error

* fix(main.py): handle PydanticSerializationError in JavaScriptMIMETypeMiddleware to provide detailed error message in case of serialization error

* improve error handling

* feat: Handle PydanticSerializationError in JavaScriptMIMETypeMiddleware

Refactor the `JavaScriptMIMETypeMiddleware` class in `main.py` to handle the `PydanticSerializationError` exception. This change ensures that a detailed error message is provided in case of a serialization error. The error message is now serialized as a JSON string and included in the `detail` field of the `HTTPException` raised.

* feat: Add tryParseJson function to utils.ts

This commit adds a new function called `tryParseJson` to the `utils.ts` file. The function attempts to parse a JSON string and returns the parsed object. If parsing fails, it returns undefined. This function can be used to safely parse JSON strings without throwing an error.

* fix: Handle error message in buildVertex function

This commit modifies the buildVertex function in buildUtils.ts to handle error messages more effectively. It adds logic to extract the error message from the AxiosError response and parse it as JSON if possible. If the error message is not an array, it converts it into an array. This change ensures that the error message is properly displayed when building a component fails.

* remove console.log

* remove not related code

---------

Co-authored-by: anovazzi1 <otavio2204@gmail.com>
This commit is contained in:
Gabriel Luiz Freitas Almeida 2024-07-31 15:23:19 -03:00 • committed by GitHub
commit f08467d84b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 37 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/frontend/src/utils/buildUtils.ts
View file

@ -7,6 +7,7 @@ import useFlowStore from "../stores/flowStore";
import { VertexBuildTypeAPI } from "../types/api";
import { isErrorLogType } from "../types/utils/typeCheckingUtils";
import { VertexLayerElementType } from "../types/zustand/flow";
import { tryParseJson } from "./utils";
type BuildVerticesParams = {
setLockChat?: (lock: boolean) => void;
@ -306,12 +307,17 @@ async function buildVertex({
buildResults.push(buildData.valid);
} catch (error) {
console.error(error);
let errorMessage: string | string[] =
(error as AxiosError<any>).response?.data?.detail ||
(error as AxiosError<any>).response?.data?.message ||
"An unexpected error occurred while building the Component. Please try again.";
errorMessage = tryParseJson(errorMessage as string) ?? errorMessage;
if (!Array.isArray(errorMessage)) {
errorMessage = [errorMessage];
}
onBuildError!(
"Error Building Component",
[
(error as AxiosError<any>).response?.data?.detail ??
"An unexpected error occurred while building the Component. Please try again.",
],
errorMessage,
verticesIds.map((id) => ({ id })),
);
buildResults.push(false);

16
src/frontend/src/utils/utils.ts
View file

@ -546,3 +546,19 @@ export function generateBackendColumnsFromValue(rows: Object[]): ColumnField[] {
return newColumn;
});
}
/**
* Tries to parse a JSON string and returns the parsed object.
* If parsing fails, returns undefined.
*
* @param json - The JSON string to parse.
* @returns The parsed JSON object, or undefined if parsing fails.
*/
export function tryParseJson(json: string) {
try {
const parsedJson = JSON.parse(json);
return parsedJson;
} catch (error) {
return;
}
}