From f2abb944f620f675c50e5e3fd1c1330e5faba00a Mon Sep 17 00:00:00 2001 From: Lucas Oliveira <62335616+lucaseduoli@users.noreply.github.com> Date: Mon, 2 Sep 2024 18:48:05 -0300 Subject: [PATCH] fix: console reported issues (#3660) * Added key to sidebar buttons * Added key directrly to sidebar category * Removed key definition on sidebar category * Fix error of nested buttons on secretKeyModal * Fix nested buttons on output modal * Fix clip-path warning on components * Fix components cannot be given refs on nodeOutputField * Removed unused console.log * Added key on profile pictures map * Fixed hideOverlay being called when the table is destroyed * Fixed valueFormatter error on Apply To Fields field on GlobalVariables page * Updated headers on config page to ensure consistent design --- .../components/NodeOutputfield/index.tsx | 65 ++++++------- .../components/outputModal/index.tsx | 3 +- .../components/sideBarButtons/index.tsx | 4 +- .../src/components/tableComponent/index.tsx | 4 +- src/frontend/src/icons/AstraDB/AstraDB.jsx | 2 +- .../src/icons/Unstructured/Unstructured.jsx | 2 +- .../src/modals/secretKeyModal/index.tsx | 2 +- .../SidebarCategoryComponent/index.tsx | 94 +++++++++---------- .../extraSidebarComponent/index.tsx | 6 +- .../components/tabsComponent/index.tsx | 1 - .../components/ApiKeyHeader/index.tsx | 2 +- .../profilePictureChooserComponent/index.tsx | 5 +- .../pages/GlobalVariablesPage/index.tsx | 5 +- .../pages/ShortcutsPage/index.tsx | 4 +- 14 files changed, 97 insertions(+), 102 deletions(-) diff --git a/src/frontend/src/CustomNodes/GenericNode/components/NodeOutputfield/index.tsx b/src/frontend/src/CustomNodes/GenericNode/components/NodeOutputfield/index.tsx index ed8bc3aa2..d27fdb7e2 100644 --- a/src/frontend/src/CustomNodes/GenericNode/components/NodeOutputfield/index.tsx +++ b/src/frontend/src/CustomNodes/GenericNode/components/NodeOutputfield/index.tsx @@ -5,14 +5,10 @@ import { useUpdateNodeInternals } from "reactflow"; import { default as IconComponent } from "../../../../components/genericIconComponent"; import ShadTooltip from "../../../../components/shadTooltipComponent"; import { Button } from "../../../../components/ui/button"; -import { Case } from "../../../../shared/components/caseComponent"; import useFlowStore from "../../../../stores/flowStore"; import { useShortcutsStore } from "../../../../stores/shortcuts"; import { useTypesStore } from "../../../../stores/typesStore"; -import { - NodeOutputFieldComponentType, - ParameterComponentType, -} from "../../../../types/components"; +import { NodeOutputFieldComponentType } from "../../../../types/components"; import { getGroupOutputNodeId, scapedJSONStringfy, @@ -20,7 +16,6 @@ import { import { classNames, cn, - isThereModal, logHasMessage, logTypeIsError, logTypeIsUnknown, @@ -194,36 +189,38 @@ export default function NodeOutputField({ : "Please build the component first" } > - - - + + + diff --git a/src/frontend/src/CustomNodes/GenericNode/components/outputModal/index.tsx b/src/frontend/src/CustomNodes/GenericNode/components/outputModal/index.tsx index f8496e1ea..1aa48efe7 100644 --- a/src/frontend/src/CustomNodes/GenericNode/components/outputModal/index.tsx +++ b/src/frontend/src/CustomNodes/GenericNode/components/outputModal/index.tsx @@ -1,6 +1,5 @@ import { Tabs, TabsList, TabsTrigger } from "@/components/ui/tabs"; import { useState } from "react"; -import { Button } from "../../../../components/ui/button"; import BaseModal from "../../../../modals/baseModal"; import SwitchOutputView from "./components/switchOutputView"; @@ -38,7 +37,7 @@ export default function OutputModal({ /> - {children} + {children} ); } diff --git a/src/frontend/src/components/sidebarComponent/components/sideBarButtons/index.tsx b/src/frontend/src/components/sidebarComponent/components/sideBarButtons/index.tsx index 8324620aa..128d80fa7 100644 --- a/src/frontend/src/components/sidebarComponent/components/sideBarButtons/index.tsx +++ b/src/frontend/src/components/sidebarComponent/components/sideBarButtons/index.tsx @@ -17,8 +17,8 @@ const SideBarButtonsComponent = ({ }: SideBarButtonsComponentProps) => { return (
- {items.map((item) => ( - + {items.map((item, index) => ( +
{ - realRef?.current?.api?.hideOverlay(); + if (!realRef?.current?.api?.isDestroyed) { + realRef?.current?.api?.hideOverlay(); + } }, 1000); if (props.onGridReady) props.onGridReady(params); }; diff --git a/src/frontend/src/icons/AstraDB/AstraDB.jsx b/src/frontend/src/icons/AstraDB/AstraDB.jsx index c54bee90a..e32ec6996 100644 --- a/src/frontend/src/icons/AstraDB/AstraDB.jsx +++ b/src/frontend/src/icons/AstraDB/AstraDB.jsx @@ -7,7 +7,7 @@ const AstraSVG = (props) => ( xmlns="http://www.w3.org/2000/svg" {...props} > - + {/* */} ( xmlns="http://www.w3.org/2000/svg" {...props} > - + - {children} + {children} - -
- {Object.keys(category) - .sort((a, b) => - sensitiveSort(category[a].display_name, category[b].display_name), - ) - .map((SBItemName: string, index) => ( - - - onDragStart(event, { - //split type to remove type in nodes saved with same name removing it's - type: removeCountFromString(SBItemName), - node: category[SBItemName], - }) - } - color={nodeColors[name]} - itemName={SBItemName} - //convert error to boolean - error={!!category[SBItemName].error} - display_name={category[SBItemName].display_name} - official={ - category[SBItemName].official === false ? false : true - } - /> - - ))} -
- - +
+ {Object.keys(category) + .sort((a, b) => + sensitiveSort(category[a].display_name, category[b].display_name), + ) + .map((SBItemName: string, idx) => ( + + + onDragStart(event, { + //split type to remove type in nodes saved with same name removing it's + type: removeCountFromString(SBItemName), + node: category[SBItemName], + }) + } + color={nodeColors[name]} + itemName={SBItemName} + //convert error to boolean + error={!!category[SBItemName].error} + display_name={category[SBItemName].display_name} + official={ + category[SBItemName].official === false ? false : true + } + /> + + ))} +
+ ); } diff --git a/src/frontend/src/pages/FlowPage/components/extraSidebarComponent/index.tsx b/src/frontend/src/pages/FlowPage/components/extraSidebarComponent/index.tsx index 8138008c5..3d086849c 100644 --- a/src/frontend/src/pages/FlowPage/components/extraSidebarComponent/index.tsx +++ b/src/frontend/src/pages/FlowPage/components/extraSidebarComponent/index.tsx @@ -233,7 +233,7 @@ export default function ExtraSidebar(): JSX.Element { .map((SBSectionName: keyof APIObjectType, index) => Object.keys(dataFilter[SBSectionName]).length > 0 ? ( Object.keys(dataFilter[SBSectionName]).length > 0 ? ( Object.keys(dataFilter[SBSectionName]).length > 0 ? ( { return ( <> -
+

Langflow API diff --git a/src/frontend/src/pages/SettingsPage/pages/GeneralPage/components/ProfilePictureForm/components/profilePictureChooserComponent/index.tsx b/src/frontend/src/pages/SettingsPage/pages/GeneralPage/components/ProfilePictureForm/components/profilePictureChooserComponent/index.tsx index 32a6057bd..24ef1324b 100644 --- a/src/frontend/src/pages/SettingsPage/pages/GeneralPage/components/ProfilePictureForm/components/profilePictureChooserComponent/index.tsx +++ b/src/frontend/src/pages/SettingsPage/pages/GeneralPage/components/ProfilePictureForm/components/profilePictureChooserComponent/index.tsx @@ -37,8 +37,8 @@ export default function ProfilePictureChooserComponent({ {loading || !imagesLoaded ? ( ) : ( - Object.keys(profilePictures!).map((folder, idx) => ( -
+ Object.keys(profilePictures!).map((folder, index) => ( +
{folder}
@@ -46,6 +46,7 @@ export default function ProfilePictureChooserComponent({
{profilePictures![folder].map((path, idx) => (