jyapayne/langflow
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

refactor: ⚡️ Speed up function _truncate_value by 45% (main) (#6334)

Browse source 
⚡️ Speed up function `_truncate_value` by 45% in PR #6323 (`test-smol`)
To optimize the Python program for faster performance, we should make a few adjustments. Specifically, the use of multiple `isinstance` checks and logical conditioning can be streamlined to reduce the runtime overhead. Here's the optimized version of the program.



### Explanation.

1. **Order and Conditions**: We adjusted the order to check the limit first. This way, we only perform the `isinstance` check if the limit is set, thereby potentially reducing the number of checks needed.
2. **Combined Types**: Instead of using `isinstance(value, list | tuple)`, which uses the `|` operator for a union type, we use the more traditional tuple form `isinstance(value, (list, tuple))`. This makes it explicit that we’re checking against multiple types and can be a bit faster.
  
These changes should result in slight performance improvements by reducing the number of checks and short-circuiting earlier.

Co-authored-by: codeflash-ai[bot] <148906541+codeflash-ai[bot]@users.noreply.github.com>
Co-authored-by: Gabriel Luiz Freitas Almeida <gabriel@langflow.org>
This commit is contained in:
codeflash-ai[bot] 2025-02-13 11:49:15 +00:00 • committed by GitHub
commit f3ddbcf1a8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/backend/base/langflow/serialization/serialization.py
View file

@ -109,9 +109,9 @@ def _serialize_instance(obj: Any, *_) -> str:
def _truncate_value(value: Any, max_length: int | None, max_items: int | None) -> Any:
"""Truncate value based on its type and provided limits."""
if isinstance(value, str) and max_length is not None and len(value) > max_length:
if max_length is not None and isinstance(value, str) and len(value) > max_length:
return value[:max_length]
if isinstance(value, list | tuple) and max_items is not None and len(value) > max_items:
if max_items is not None and isinstance(value, (list, tuple)) and len(value) > max_items:
return value[:max_items]
return value