jyapayne/langflow
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

refactor: Improve handling of inputValue in GenericModal component

Browse source 
This commit improves the handling of the inputValue in the GenericModal component. It checks if the inputValue is a string before assigning it to coloredContent. Additionally, it updates the classNames in the JSX elements to ensure consistent ordering. These changes enhance the reliability and maintainability of the code.
This commit is contained in:
ogabrielluiz 2024-06-19 01:02:55 -03:00
commit f4b369b837
1 changed files with 11 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

15
src/frontend/src/modals/genericModal/index.tsx
View file

@ -96,9 +96,16 @@ export default function GenericModal({
}, [inputValue, type]);
useEffect(() => {
setInputValue(value);
if (typeof value === "string") setInputValue(value);
}, [value, modalOpen]);
const coloredContent = (inputValue || "")
let coloredContent = inputValue || "";
// Check if coloredContent is a string
// calling toString on undefined will throw an error
// so we need to check if it is a string first
if (typeof coloredContent !== "string") {
coloredContent = "";
}
coloredContent
.replace(/</g, "&lt;")
.replace(/>/g, "&gt;")
.replace(regexHighlight, (match, p1, p2) => {
@ -205,7 +212,7 @@ export default function GenericModal({
/>
</BaseModal.Header>
<BaseModal.Content overflowHidden>
<div className={classNames("rounded-lg border flex h-full w-full")}>
<div className={classNames("flex h-full w-full rounded-lg border")}>
{type === TypeModal.PROMPT && isEdit && !readonly ? (
<Textarea
id={"modal-" + id}
@ -228,7 +235,7 @@ export default function GenericModal({
/>
) : type === TypeModal.PROMPT && (!isEdit || readonly) ? (
<SanitizedHTMLWrapper
className={getClassByNumberLength()+ " bg-muted"}
className={getClassByNumberLength() + " bg-muted"}
content={coloredContent}
onClick={() => {
setIsEdit(true);