🔧 chore(vector_store.py): refactor initialize_chroma function to remove unnecessary if conditions and improve code readability
🔧 chore(vector_store.py): remove chroma_server_ keys from params dictionary if not needed to avoid potential conflicts
This commit is contained in:
parent
239811dbff
commit
f61d265e77
1 changed files with 9 additions and 5 deletions
|
|
@ -171,11 +171,7 @@ def initialize_pinecone(class_object: Type[Pinecone], params: dict):
|
||||||
def initialize_chroma(class_object: Type[Chroma], params: dict):
|
def initialize_chroma(class_object: Type[Chroma], params: dict):
|
||||||
"""Initialize a ChromaDB object from the params"""
|
"""Initialize a ChromaDB object from the params"""
|
||||||
if ( # type: ignore
|
if ( # type: ignore
|
||||||
"chroma_server_host" in params
|
"chroma_server_host" in params or "chroma_server_http_port" in params
|
||||||
or "chroma_server_http_port" in params
|
|
||||||
or "chroma_server_ssl_enabled" in params
|
|
||||||
or "chroma_server_grpc_port" in params
|
|
||||||
or "chroma_server_cors_allow_origins" in params
|
|
||||||
):
|
):
|
||||||
import chromadb # type: ignore
|
import chromadb # type: ignore
|
||||||
|
|
||||||
|
|
@ -186,6 +182,14 @@ def initialize_chroma(class_object: Type[Chroma], params: dict):
|
||||||
}
|
}
|
||||||
chroma_settings = chromadb.config.Settings(**settings_params)
|
chroma_settings = chromadb.config.Settings(**settings_params)
|
||||||
params["client_settings"] = chroma_settings
|
params["client_settings"] = chroma_settings
|
||||||
|
else:
|
||||||
|
# remove all chroma_server_ keys from params
|
||||||
|
params = {
|
||||||
|
key: value
|
||||||
|
for key, value in params.items()
|
||||||
|
if not key.startswith("chroma_server_")
|
||||||
|
}
|
||||||
|
|
||||||
persist = params.pop("persist", False)
|
persist = params.pop("persist", False)
|
||||||
if not docs_in_params(params):
|
if not docs_in_params(params):
|
||||||
params.pop("documents", None)
|
params.pop("documents", None)
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue