From f90e980cb52a3cedc7d50cee61c0bb3305bd4c0e Mon Sep 17 00:00:00 2001
From: anovazzi1 <otavio2204@gmail.com>
Date: Tue, 26 Nov 2024 10:09:17 -0300
Subject: [PATCH] Refactor: floatComponent.spec.ts for improved readability,
 performance, and reliability (#4857)

Refactor floatComponent.spec.ts to improve readability, performance and reliability
---
 .../tests/core/unit/floatComponent.spec.ts    | 28 +++++++------------
 1 file changed, 10 insertions(+), 18 deletions(-)

diff --git a/src/frontend/tests/core/unit/floatComponent.spec.ts b/src/frontend/tests/core/unit/floatComponent.spec.ts
index 4c74bc11f..92ddbcb0c 100644
--- a/src/frontend/tests/core/unit/floatComponent.spec.ts
+++ b/src/frontend/tests/core/unit/floatComponent.spec.ts
@@ -25,7 +25,9 @@ test(
 
     while (modalCount === 0) {
       await page.getByText("New Flow", { exact: true }).click();
-      await page.waitForTimeout(3000);
+      await page.waitForSelector('[data-testid="modal-title"]', {
+        timeout: 3000,
+      });
       modalCount = await page.getByTestId("modal-title")?.count();
     }
     await page.waitForSelector('[data-testid="blank-flow"]', {
@@ -35,7 +37,9 @@ test(
     await page.getByTestId("sidebar-search-input").click();
     await page.getByTestId("sidebar-search-input").fill("ollama");
 
-    await page.waitForTimeout(1000);
+    await page.waitForSelector('[data-testid="modelsOllama"]', {
+      timeout: 30000,
+    });
 
     await page
       .getByTestId("modelsOllama")
@@ -47,33 +51,25 @@ test(
     await page.getByTestId("zoom_out").click();
     await page.getByTestId("zoom_out").click();
 
-    await page.waitForTimeout(1000);
     await page.locator('//*[@id="float_float_temperature"]').click();
     await page.locator('//*[@id="float_float_temperature"]').fill("");
-    await page.waitForTimeout(1000);
     await page.locator('//*[@id="float_float_temperature"]').fill("3");
 
     let value = await page
       .locator('//*[@id="float_float_temperature"]')
       .inputValue();
 
-    if (value != "2") {
-      expect(false).toBeTruthy();
-    }
+    expect(value).toBe("2");
 
-    await page.waitForTimeout(1000);
     await page.locator('//*[@id="float_float_temperature"]').click();
     await page.locator('//*[@id="float_float_temperature"]').fill("");
-    await page.waitForTimeout(1000);
     await page.locator('//*[@id="float_float_temperature"]').fill("-3");
 
     value = await page
       .locator('//*[@id="float_float_temperature"]')
       .inputValue();
 
-    if (value != "-2") {
-      expect(false).toBeTruthy();
-    }
+    expect(value).toBe("-2");
 
     await page.getByTestId("more-options-modal").click();
     await page.getByTestId("advanced-button-modal").click();
@@ -136,9 +132,7 @@ test(
         .locator('//*[@id="float_float_temperature"]')
         .inputValue();
 
-      if (value != "1") {
-        expect(false).toBeTruthy();
-      }
+      expect(value).toBe("1");
 
       await page.locator('//*[@id="float_float_temperature"]').click();
       await page.getByTestId("float_float_temperature").fill("");
@@ -149,9 +143,7 @@ test(
         .locator('//*[@id="float_float_temperature"]')
         .inputValue();
 
-      if (value != "-1") {
-        expect(false).toBeTruthy();
-      }
+      expect(value).toBe("-1");
     }
   },
 );