jyapayne/langflow
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

fix: silent error fix in KB components (#9433)

Browse source 
* silent error fix

* silent error fix

* Raise value error if configured column is not available

* [autofix.ci] apply automated fixes

* Remove silent error tests with option gone

* Update test_kb_ingest.py

---------

Co-authored-by: Eric Hare <ericrhare@gmail.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
This commit is contained in:
Edwin Jose 2025-08-19 16:03:54 -04:00 • committed by GitHub
commit fbb0012045
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 8 additions and 44 deletions
Download patch file Download diff file Expand all files Collapse all files

33
src/backend/tests/unit/components/data/test_kb_ingest.py
View file

@ -1,5 +1,4 @@
import json
from pathlib import Path
from unittest.mock import MagicMock, patch
import pandas as pd
@ -87,26 +86,14 @@ class TestKBIngestionComponent(ComponentTestBaseWithoutClient):
invalid_config = [{"column_name": "nonexistent", "vectorize": True, "identifier": False}]
default_kwargs["column_config"] = invalid_config
# Instantiate the component with the modified config
component = component_class(**default_kwargs)
data_df = default_kwargs["input_df"]
# Should raise ValueError since column does not exist in DataFrame
with pytest.raises(ValueError, match="Column 'nonexistent' not found in DataFrame"):
component._validate_column_config(data_df)
def test_validate_column_config_silent_errors(self, component_class, default_kwargs):
"""Test column configuration validation with silent errors enabled."""
# Modify column config to include non-existent column
invalid_config = [{"column_name": "nonexistent", "vectorize": True, "identifier": False}]
default_kwargs["column_config"] = invalid_config
default_kwargs["silent_errors"] = True
component = component_class(**default_kwargs)
data_df = default_kwargs["input_df"]
# Should not raise exception with silent_errors=True
config_list = component._validate_column_config(data_df)
assert isinstance(config_list, list)
def test_get_embedding_provider(self, component_class, default_kwargs):
"""Test embedding provider detection."""
component = component_class(**default_kwargs)
@ -308,22 +295,6 @@ class TestKBIngestionComponent(ComponentTestBaseWithoutClient):
assert "rows" in result.data
assert result.data["rows"] == 2
def test_build_kb_info_with_silent_errors(self, component_class, default_kwargs):
"""Test KB info building with silent errors enabled."""
default_kwargs["silent_errors"] = True
component = component_class(**default_kwargs)
# Remove the metadata file to cause an error
kb_path = Path(default_kwargs["kb_root_path"]) / default_kwargs["knowledge_base"]
metadata_file = kb_path / "embedding_metadata.json"
if metadata_file.exists():
metadata_file.unlink()
# Should not raise exception with silent_errors=True
result = component.build_kb_info()
assert isinstance(result, Data)
assert "error" in result.data
def test_get_knowledge_bases(self, component_class, default_kwargs, tmp_path):
"""Test getting list of knowledge bases."""
component = component_class(**default_kwargs)