langflow/src/backend/tests/unit/components/logic/test_loop.py
Gabriel Luiz Freitas Almeida 6403a8f564
fix(graph): fixes bug that caused simple flows with Loop to fail (#8809)
* fix: improve predecessors check for loop component

- Enhanced the handling of cycle vertices to prevent infinite loops by ensuring that a vertex can only run if all pending predecessors have completed.
- Updated conditions for the first execution of cycle vertices to allow running only if all pending predecessors are also cycle vertices.
- This refactor improves the robustness of the vertex management system in asynchronous workflows.

* fix: update _mark_branch method to return visited vertices and refine predecessor mapping

* fix: prevent duplicate item dependencies in LoopComponent

* feat: add loop connection handling in Component class

- Introduced methods to process loop feedback connections, allowing components to connect outputs to loop-enabled inputs.
- Implemented checks to validate loop connections and ensure proper handling of callable methods from other components.
- Enhanced the edge creation logic to support special loop feedback edges targeting outputs instead of inputs.

* fix: enhance name overlap validation in FrontendNode

- Updated the validate_name_overlap method to exclude outputs that allow loops from the overlap check.
- Improved error message to include the display name of the component, along with detailed lists of input and output names for better debugging.

* fix: correct condition for executing cycle vertices in RunnableVerticesManager

- Updated the logic to ensure that a cycle vertex can only execute if it is a loop and all pending predecessors are cycle vertices. This change enhances the robustness of the vertex management system in asynchronous workflows.

* feat: implement comprehensive loop flow for URL processing

- Added a new loop flow that processes multiple URLs through a series of components including URLComponent, SplitTextComponent, LoopComponent, ParserComponent, PromptComponent, OpenAIModelComponent, StructuredOutputComponent, and ChatOutput.
- Enhanced the StructuredOutputComponent to include a detailed system prompt and refined output schema to ensure proper JSON formatting.
- Introduced a test case to validate the creation and execution of the loop flow, ensuring all components are correctly integrated and the expected execution order is maintained.

* refactor: enhance loop target handling in Component and Edge classes

- Introduced LoopTargetHandleDict to better manage loop target structures in the Component and Edge classes.
- Updated the Component class to utilize type casting for loop target handles, improving type safety.
- Refactored the Edge class to accommodate the new loop target handling, ensuring compatibility with existing edge structures.
- Removed deprecated message handling methods from the Component class to streamline the codebase and improve maintainability.

* test: skip OpenAI model integration test if API key is not set

- Added a conditional skip to the test_build_model_integration_reasoning method to prevent execution when the OPENAI_API_KEY environment variable is not set, ensuring tests run only in appropriate environments.

* [autofix.ci] apply automated fixes

* chore: add required secrets for OpenAI and Anthropic APIs in CI workflows

* Updated ci.yml to include OPENAI_API_KEY and ANTHROPIC_API_KEY secrets.
* Modified python_test.yml to mark these secrets as required for workflow execution.

* fix: update OPENAI_API_KEY check in test_loop.py to handle dummy values

* Modified the condition in the pytest skipif decorator to also skip tests when OPENAI_API_KEY is set to "dummy", ensuring more robust test execution.

* refactor: streamline component setup in test_loop.py

* Removed redundant comments and improved formatting for component initialization in the loop_flow function.
* Added missing system_prompt to StructuredOutputComponent to resolve "Multiple structured outputs" error.
* Updated test_loop_flow to ensure it tests the graph creation with proper loop feedback connection.

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
2025-07-03 14:39:09 +00:00

250 lines
9.7 KiB
Python

import json
import os
from uuid import UUID
import orjson
import pytest
from httpx import AsyncClient
from langflow.components.data.url import URLComponent
from langflow.components.input_output import ChatOutput
from langflow.components.logic import LoopComponent
from langflow.components.openai.openai_chat_model import OpenAIModelComponent
from langflow.components.processing import (
ParserComponent,
PromptComponent,
SplitTextComponent,
StructuredOutputComponent,
)
from langflow.graph import Graph
from langflow.memory import aget_messages
from langflow.schema.data import Data
from langflow.services.database.models.flow import FlowCreate
from tests.base import ComponentTestBaseWithClient
from tests.unit.build_utils import build_flow, get_build_events
TEXT = (
"lorem ipsum dolor sit amet lorem ipsum dolor sit amet lorem ipsum dolor sit amet. "
"lorem ipsum dolor sit amet lorem ipsum dolor sit amet lorem ipsum dolor sit amet. "
"lorem ipsum dolor sit amet lorem ipsum dolor sit amet lorem ipsum dolor sit amet."
)
class TestLoopComponentWithAPI(ComponentTestBaseWithClient):
@pytest.fixture
def component_class(self):
"""Return the component class to test."""
return LoopComponent
@pytest.fixture
def file_names_mapping(self):
"""Return an empty list since this component doesn't have version-specific files."""
return []
@pytest.fixture
def default_kwargs(self):
"""Return the default kwargs for the component."""
return {
"data": [[Data(text="Hello World")]],
"loop_input": [Data(text=TEXT)],
}
def test_latest_version(self, component_class, default_kwargs) -> None:
"""Test that the component works with the latest version."""
result = component_class(**default_kwargs)
assert result is not None, "Component returned None for the latest version."
async def _create_flow(self, client, json_loop_test, logged_in_headers):
vector_store = orjson.loads(json_loop_test)
data = vector_store["data"]
vector_store = FlowCreate(name="Flow", description="description", data=data, endpoint_name="f")
response = await client.post("api/v1/flows/", json=vector_store.model_dump(), headers=logged_in_headers)
response.raise_for_status()
return response.json()["id"]
async def check_messages(self, flow_id):
messages = await aget_messages(flow_id=UUID(flow_id), order="ASC")
assert len(messages) == 1
assert messages[0].session_id == flow_id
assert messages[0].sender == "Machine"
assert messages[0].sender_name == "AI"
assert len(messages[0].text) > 0
return messages
async def test_build_flow_loop(self, client, json_loop_test, logged_in_headers):
"""Test building a flow with a loop component."""
# Create the flow
flow_id = await self._create_flow(client, json_loop_test, logged_in_headers)
# Start the build and get job_id
build_response = await build_flow(client, flow_id, logged_in_headers)
job_id = build_response["job_id"]
assert job_id is not None
# Get the events stream
events_response = await get_build_events(client, job_id, logged_in_headers)
assert events_response.status_code == 200
# Process the events stream
chat_output = None
lines = []
async for line in events_response.aiter_lines():
if not line: # Skip empty lines
continue
lines.append(line)
if "ChatOutput" in line:
chat_output = json.loads(line)
# Process events if needed
# We could add specific assertions here for loop-related events
assert chat_output is not None
messages = await self.check_messages(flow_id)
ai_message = messages[0].text
json_data = orjson.loads(ai_message)
# Use a for loop for better debugging
found = []
json_data = [(data["text"], q_dict) for data, q_dict in json_data]
for text, q_dict in json_data:
expected_text = f"==> {q_dict['q']}"
assert expected_text in text, (
f"Found {found} until now, but expected '{expected_text}' not found in '{text}',"
f"and the json_data is {json_data}"
)
found.append(expected_text)
async def test_run_flow_loop(self, client: AsyncClient, created_api_key, json_loop_test, logged_in_headers):
flow_id = await self._create_flow(client, json_loop_test, logged_in_headers)
headers = {"x-api-key": created_api_key.api_key}
payload = {
"input_value": TEXT,
"input_type": "chat",
"session_id": f"{flow_id}run",
"output_type": "chat",
"tweaks": {},
}
response = await client.post(f"/api/v1/run/{flow_id}", json=payload, headers=headers)
data = response.json()
assert "outputs" in data
assert "session_id" in data
assert len(data["outputs"][-1]["outputs"]) > 0
@pytest.mark.skipif(os.getenv("OPENAI_API_KEY") in {None, "dummy"}, reason="OPENAI_API_KEY is not set")
def loop_flow():
"""Complete loop flow that processes multiple URLs through a loop."""
# Create URL component to fetch content from multiple sources
url_component = URLComponent()
url_component.set(urls=["https://docs.langflow.org/"])
# Create SplitText component to chunk the content
split_text_component = SplitTextComponent()
split_text_component.set(
data_inputs=url_component.fetch_content,
chunk_size=1000,
chunk_overlap=200,
separator="\n\n",
)
# Create Loop component to iterate through the chunks
loop_component = LoopComponent()
loop_component.set(data=split_text_component.split_text)
# Create Parser component to format the current loop item
parser_component = ParserComponent()
parser_component.set(
input_data=loop_component.item_output,
pattern="Content: {text}",
sep="\n",
)
# Create Prompt component to create processing instructions
prompt_component = PromptComponent()
prompt_component.set(
template="Analyze and summarize this content: {context}",
input_text=parser_component.parse_combined_text,
)
# Create OpenAI model component for processing
openai_component = OpenAIModelComponent()
openai_component.set(
api_key=os.getenv("OPENAI_API_KEY"),
model_name="gpt-4.1-mini",
temperature=0.7,
)
# Create StructuredOutput component to process content
structured_output = StructuredOutputComponent()
structured_output.set(
llm=openai_component.build_model,
input_value=prompt_component.build_prompt,
schema_name="ProcessedContent",
system_prompt=( # Added missing system_prompt - this was causing the "Multiple structured outputs" error
"You are an AI that extracts one structured JSON object from unstructured text. "
"Use a predefined schema with expected types (str, int, float, bool, dict). "
"If multiple structures exist, extract only the first most complete one. "
"Fill missing or ambiguous values with defaults: null for missing values. "
"Ignore duplicates and partial repeats. "
"Always return one valid JSON, never throw errors or return multiple objects."
"Output: A single well-formed JSON object, and nothing else."
),
output_schema=[ # Fixed schema types to match expected format
{"name": "summary", "type": "str", "description": "Key summary of the content", "multiple": False},
{"name": "topics", "type": "list", "description": "Main topics covered", "multiple": False},
{"name": "source_url", "type": "str", "description": "Source URL of the content", "multiple": False},
],
)
# Connect the feedback loop - StructuredOutput back to Loop item input
# Note: 'item' is a special dynamic input for LoopComponent feedback loops
loop_component.set(item=structured_output.build_structured_output)
# Create ChatOutput component to display final results
chat_output = ChatOutput()
chat_output.set(input_value=loop_component.done_output)
return Graph(start=url_component, end=chat_output)
@pytest.mark.xfail
async def test_loop_flow():
"""Test that loop_flow creates a working graph with proper loop feedback connection."""
flow = loop_flow()
assert flow is not None
assert flow._start is not None
assert flow._end is not None
# Verify all expected components are present
expected_vertices = {
"URLComponent",
"SplitTextComponent",
"LoopComponent",
"ParserComponent",
"PromptComponent",
"OpenAIModelComponent",
"StructuredOutputComponent",
"ChatOutput",
}
assert all(vertex.id.split("-")[0] in expected_vertices for vertex in flow.vertices)
expected_execution_order = [
"OpenAIModelComponent",
"URLComponent",
"SplitTextComponent",
"LoopComponent",
"ParserComponent",
"PromptComponent",
"StructuredOutputComponent",
"LoopComponent",
"ParserComponent",
"PromptComponent",
"StructuredOutputComponent",
"LoopComponent",
"ParserComponent",
"PromptComponent",
"StructuredOutputComponent",
"LoopComponent",
"ChatOutput",
]
results = [result async for result in flow.async_start()]
result_order = [result.vertex.id.split("-")[0] for result in results if hasattr(result, "vertex")]
assert result_order == expected_execution_order