* langflow port search and error handling * [autofix.ci] apply automated fixes * Update mcp_component.py * Update util.py * ✨ (test_mcp_component.py): add support for validating URL and setting max retries to improve connection handling 🐛 (test_mcp_component.py): fix incorrect exception type in test_connect_timeout method to match expected behavior * [autofix.ci] apply automated fixes * ✅ (test_mcp_component.py): refactor test_connect_to_server method for better readability and maintainability 🔧 (test_mcp_component.py): refactor test_connect_timeout method for improved error message formatting * [autofix.ci] apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: cristhianzl <cristhian.lousa@gmail.com>
269 lines
11 KiB
Python
269 lines
11 KiB
Python
import asyncio
|
|
from unittest.mock import AsyncMock, MagicMock, patch
|
|
|
|
import pytest
|
|
from langflow.components.tools.mcp_component import MCPSseClient, MCPStdioClient, MCPToolsComponent
|
|
|
|
from tests.base import ComponentTestBaseWithoutClient, VersionComponentMapping
|
|
|
|
|
|
class TestMCPToolsComponent(ComponentTestBaseWithoutClient):
|
|
@pytest.fixture
|
|
def component_class(self):
|
|
"""Return the component class to test."""
|
|
return MCPToolsComponent
|
|
|
|
@pytest.fixture
|
|
def default_kwargs(self):
|
|
"""Return the default kwargs for the component."""
|
|
return {
|
|
"mode": "Stdio",
|
|
"command": "uvx mcp-server-fetch",
|
|
"sse_url": "http://localhost:7860/api/v1/mcp/sse",
|
|
"tool": "",
|
|
}
|
|
|
|
@pytest.fixture
|
|
def file_names_mapping(self) -> list[VersionComponentMapping]:
|
|
"""Return the file names mapping for different versions."""
|
|
return []
|
|
|
|
@pytest.fixture
|
|
def mock_tool(self):
|
|
"""Create a mock MCP tool."""
|
|
tool = MagicMock()
|
|
tool.name = "test_tool"
|
|
tool.description = "Test tool description"
|
|
tool.inputSchema = {
|
|
"type": "object",
|
|
"properties": {"test_param": {"type": "string", "description": "Test parameter"}},
|
|
}
|
|
return tool
|
|
|
|
@pytest.fixture
|
|
def mock_stdio_client(self, mock_tool):
|
|
"""Create a mock stdio client."""
|
|
stdio_client = AsyncMock()
|
|
stdio_client.connect_to_server = AsyncMock(return_value=[mock_tool])
|
|
stdio_client.session = AsyncMock()
|
|
return stdio_client
|
|
|
|
@pytest.fixture
|
|
def mock_sse_client(self, mock_tool):
|
|
"""Create a mock SSE client."""
|
|
sse_client = AsyncMock()
|
|
sse_client.connect_to_server = AsyncMock(return_value=[mock_tool])
|
|
sse_client.session = AsyncMock()
|
|
return sse_client
|
|
|
|
async def test_validate_connection_params_invalid_mode(self, component_class, default_kwargs):
|
|
"""Test validation with invalid mode."""
|
|
component = component_class(**default_kwargs)
|
|
with pytest.raises(ValueError, match="Invalid mode: invalid. Must be either 'Stdio' or 'SSE'"):
|
|
await component._validate_connection_params("invalid")
|
|
|
|
async def test_validate_connection_params_missing_command(self, component_class, default_kwargs):
|
|
"""Test validation with missing command in Stdio mode."""
|
|
component = component_class(**default_kwargs)
|
|
with pytest.raises(ValueError, match="Command is required for Stdio mode"):
|
|
await component._validate_connection_params("Stdio", command=None)
|
|
|
|
async def test_validate_connection_params_missing_url(self, component_class, default_kwargs):
|
|
"""Test validation with missing URL in SSE mode."""
|
|
component = component_class(**default_kwargs)
|
|
with pytest.raises(ValueError, match="URL is required for SSE mode"):
|
|
await component._validate_connection_params("SSE", url=None)
|
|
|
|
async def test_update_build_config_mode_change(self, component_class, default_kwargs):
|
|
"""Test build config updates when mode changes."""
|
|
component = component_class(**default_kwargs)
|
|
build_config = {
|
|
"command": {"show": False},
|
|
"sse_url": {"show": True},
|
|
"tool": {"options": [], "show": True}, # Add tool field since component uses it
|
|
}
|
|
|
|
# Test switching to Stdio mode
|
|
updated_config = await component.update_build_config(build_config, "Stdio", "mode")
|
|
assert updated_config["command"]["show"] is True
|
|
assert updated_config["sse_url"]["show"] is False
|
|
|
|
# Test switching to SSE mode
|
|
updated_config = await component.update_build_config(build_config, "SSE", "mode")
|
|
assert updated_config["command"]["show"] is False
|
|
assert updated_config["sse_url"]["show"] is True
|
|
|
|
# Test tool options are updated
|
|
assert "options" in updated_config["tool"]
|
|
|
|
@patch("langflow.components.tools.mcp_component.create_tool_coroutine")
|
|
async def test_build_output(self, mock_create_coroutine, component_class, default_kwargs, mock_tool):
|
|
"""Test building output with a tool."""
|
|
component = component_class(**default_kwargs)
|
|
component.tool = "test_tool"
|
|
component.tools = [mock_tool]
|
|
|
|
# Mock the coroutine response
|
|
mock_response = AsyncMock()
|
|
mock_response.content = [MagicMock(text="Test response")]
|
|
mock_create_coroutine.return_value = AsyncMock(return_value=mock_response)
|
|
|
|
# Create a mock tool and add it to the cache
|
|
mock_structured_tool = MagicMock()
|
|
mock_structured_tool.coroutine = mock_create_coroutine.return_value
|
|
component._tool_cache = {"test_tool": mock_structured_tool}
|
|
|
|
# Set the test parameter value
|
|
component.test_param = "test value"
|
|
|
|
# Mock get_inputs_for_all_tools to return our mock input
|
|
mock_input = MagicMock()
|
|
mock_input.name = "test_param"
|
|
with patch.object(component, "get_inputs_for_all_tools") as mock_get_inputs:
|
|
mock_get_inputs.return_value = {"test_tool": [mock_input]}
|
|
output = await component.build_output()
|
|
|
|
assert output.text == "Test response"
|
|
# Verify the mocks were called correctly
|
|
mock_get_inputs.assert_called_once_with(component.tools)
|
|
mock_structured_tool.coroutine.assert_called_once_with(test_param="test value")
|
|
|
|
async def test_get_inputs_for_all_tools(self, component_class, default_kwargs, mock_tool):
|
|
"""Test getting input schemas for all tools."""
|
|
component = component_class(**default_kwargs)
|
|
inputs = component.get_inputs_for_all_tools([mock_tool])
|
|
|
|
assert "test_tool" in inputs
|
|
assert len(inputs["test_tool"]) > 0 # Should have at least one input parameter
|
|
|
|
async def test_remove_non_default_keys(self, component_class, default_kwargs):
|
|
"""Test removing non-default keys from build config."""
|
|
component = component_class(**default_kwargs)
|
|
build_config = {"code": {}, "mode": {}, "command": {}, "custom_key": {}}
|
|
|
|
component.remove_non_default_keys(build_config)
|
|
assert "custom_key" not in build_config
|
|
assert all(key in build_config for key in ["code", "mode", "command"])
|
|
|
|
|
|
class TestMCPStdioClient:
|
|
@pytest.fixture
|
|
def stdio_client(self):
|
|
return MCPStdioClient()
|
|
|
|
async def test_connect_to_server(self, stdio_client):
|
|
"""Test connecting to server via Stdio."""
|
|
# Create mock for stdio transport
|
|
mock_stdio = AsyncMock()
|
|
mock_write = AsyncMock()
|
|
mock_stdio_transport = (mock_stdio, mock_write)
|
|
mock_stdio_cm = AsyncMock()
|
|
mock_stdio_cm.__aenter__.return_value = mock_stdio_transport
|
|
|
|
# Mock the stdio_client function to return our mock context manager
|
|
with patch("mcp.client.stdio.stdio_client", return_value=mock_stdio_cm):
|
|
# Mock ClientSession
|
|
mock_session = AsyncMock()
|
|
mock_session.initialize = AsyncMock()
|
|
mock_session.list_tools.return_value.tools = [MagicMock()]
|
|
|
|
# Mock the AsyncExitStack
|
|
mock_exit_stack = AsyncMock()
|
|
mock_exit_stack.enter_async_context = AsyncMock()
|
|
mock_exit_stack.enter_async_context.side_effect = [
|
|
mock_stdio_transport, # For stdio_client
|
|
mock_session, # For ClientSession
|
|
]
|
|
stdio_client.exit_stack = mock_exit_stack
|
|
|
|
tools = await stdio_client.connect_to_server("test_command")
|
|
|
|
assert len(tools) == 1
|
|
assert stdio_client.session is not None
|
|
# Verify the exit stack was used correctly
|
|
assert mock_exit_stack.enter_async_context.call_count == 2
|
|
# Verify the stdio transport was properly set
|
|
assert stdio_client.stdio == mock_stdio
|
|
assert stdio_client.write == mock_write
|
|
|
|
|
|
class TestMCPSseClient:
|
|
@pytest.fixture
|
|
def sse_client(self):
|
|
return MCPSseClient()
|
|
|
|
async def test_pre_check_redirect(self, sse_client):
|
|
"""Test pre-checking URL for redirects."""
|
|
test_url = "http://test.url"
|
|
redirect_url = "http://redirect.url"
|
|
|
|
with patch("httpx.AsyncClient") as mock_client:
|
|
mock_response = MagicMock()
|
|
mock_response.status_code = 307
|
|
mock_response.headers.get.return_value = redirect_url
|
|
mock_client.return_value.__aenter__.return_value.request.return_value = mock_response
|
|
|
|
result = await sse_client.pre_check_redirect(test_url)
|
|
assert result == redirect_url
|
|
|
|
async def test_connect_to_server(self, sse_client):
|
|
"""Test connecting to server via SSE."""
|
|
# Mock the pre_check_redirect first
|
|
with (
|
|
patch.object(sse_client, "pre_check_redirect", return_value="http://test.url"),
|
|
patch.object(sse_client, "validate_url", return_value=(True, "")),
|
|
):
|
|
# Create mock for sse_client context manager
|
|
mock_sse = AsyncMock()
|
|
mock_write = AsyncMock()
|
|
mock_sse_transport = (mock_sse, mock_write)
|
|
mock_sse_cm = AsyncMock()
|
|
mock_sse_cm.__aenter__.return_value = mock_sse_transport
|
|
|
|
# Mock the sse_client function to return our mock context manager
|
|
with patch("mcp.client.sse.sse_client", return_value=mock_sse_cm):
|
|
# Mock ClientSession
|
|
mock_session = AsyncMock()
|
|
mock_session.initialize = AsyncMock()
|
|
mock_session.list_tools.return_value.tools = [MagicMock()]
|
|
|
|
# Mock the AsyncExitStack
|
|
mock_exit_stack = AsyncMock()
|
|
mock_exit_stack.enter_async_context = AsyncMock()
|
|
mock_exit_stack.enter_async_context.side_effect = [
|
|
mock_sse_transport, # For sse_client
|
|
mock_session, # For ClientSession
|
|
]
|
|
sse_client.exit_stack = mock_exit_stack
|
|
|
|
tools = await sse_client.connect_to_server("http://test.url", {})
|
|
|
|
assert len(tools) == 1
|
|
assert sse_client.session is not None
|
|
# Verify the exit stack was used correctly
|
|
assert mock_exit_stack.enter_async_context.call_count == 2
|
|
# Verify the SSE transport was properly set
|
|
assert sse_client.sse == mock_sse
|
|
assert sse_client.write == mock_write
|
|
|
|
async def test_connect_timeout(self, sse_client):
|
|
"""Test connection timeout handling."""
|
|
# Set max_retries to 1 to avoid multiple retry attempts
|
|
sse_client.max_retries = 1
|
|
|
|
with (
|
|
patch.object(sse_client, "pre_check_redirect", return_value="http://test.url"),
|
|
patch.object(sse_client, "validate_url", return_value=(True, "")), # Mock URL validation
|
|
patch.object(sse_client, "_connect_with_timeout") as mock_connect,
|
|
):
|
|
mock_connect.side_effect = asyncio.TimeoutError()
|
|
|
|
# Expect ConnectionError instead of TimeoutError
|
|
with pytest.raises(
|
|
ConnectionError,
|
|
match=(
|
|
"Failed to connect after 1 attempts. "
|
|
"Last error: Connection to http://test.url timed out after 1 seconds"
|
|
),
|
|
):
|
|
await sse_client.connect_to_server("http://test.url", {}, timeout_seconds=1)
|