jyapayne/moonlight-common-c
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Don't lock the ENet mutex when querying for RTT information

Browse source
This commit is contained in:
Cameron Gutman 2025-11-25 17:26:01 -06:00
commit 20c05eda6a
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/ControlStream.c
View file

@ -1670,7 +1670,10 @@ bool isControlDataInTransit(void) {
bool LiGetEstimatedRttInfo(uint32_t* estimatedRtt, uint32_t* estimatedRttVariance) { bool LiGetEstimatedRttInfo(uint32_t* estimatedRtt, uint32_t* estimatedRttVariance) {
bool ret = false; bool ret = false;
PltLockMutex(&enetMutex); // We do not acquire enetMutex here because we're just reading metrics
// and observing a torn write every once in a while is totally fine.
// The peer pointer points to memory reserved inside the client object,
// so it's guaranteed that it will never go away underneath us.
if (peer != NULL && peer->state == ENET_PEER_STATE_CONNECTED) { if (peer != NULL && peer->state == ENET_PEER_STATE_CONNECTED) {
if (estimatedRtt != NULL) { if (estimatedRtt != NULL) {
*estimatedRtt = peer->roundTripTime; *estimatedRtt = peer->roundTripTime;
@ -1682,7 +1685,6 @@ bool LiGetEstimatedRttInfo(uint32_t* estimatedRtt, uint32_t* estimatedRttVarianc
ret = true; ret = true;
} }
PltUnlockMutex(&enetMutex);
return ret; return ret;
} }